<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 23.07.2014 23:27, Phil Race wrote:<br>
</div>
<blockquote cite="mid:53D00CBD.90603@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">I had started on this but there was a
lot to wade through<br>
<br>
Here
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html">http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html</a><br>
<br>
you changed 'public static class Info' -> 'class Info'<br>
<br>
This made me think. I presume the point is that a class nested
within an interface<br>
is implicitly static even if not declared so, so you removed it.<br>
</div>
</blockquote>
Right.<br>
<blockquote cite="mid:53D00CBD.90603@oracle.com" type="cite">
<div class="moz-cite-prefix"> However I have no idea if JCK
signature tests will need to be updated.<br>
I suggest you inquire.<br>
</div>
</blockquote>
At least class file is not changed.<br>
<blockquote cite="mid:53D00CBD.90603@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
You may want to correct the (pre-existing) spelling mistake<br>
here before you push :-<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html">http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html</a><br>
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<pre><span class="changed">48 * {@code MidiSystem.getTransmitter} is implementation-dependant unless the
dependant->dependent
</span></pre>
<br>
Changes (like) this one surprised me too :-<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8050852/webrev.02/src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java.sdiff.html">http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java.sdiff.html</a><br>
<br>
So we add an import statement just to keep some javadoc tool
happy ?<br>
</div>
</blockquote>
No, it just to make a reader of this javadoc happy.<br>
<blockquote cite="mid:53D00CBD.90603@oracle.com" type="cite">
<div class="moz-cite-prefix"> Was this from doclint ? Did you
question whether that was really something<br>
doclint should enforce rather than just allowing the fully
qualified name ?<br>
<br>
It wouldn't surprise me if some other tool were to consider this
an un-used import<br>
and delete it.<br>
</div>
</blockquote>
We had a bunch of unused imports in the past in these files, and now
all of them are removed/used. I guess, if some tool recognize this
as unused import, it will be a bad tool.<br>
<blockquote cite="mid:53D00CBD.90603@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
-phil<br>
<br>
On 7/23/14 2:44 AM, Sergey Bylokhov wrote:<br>
</div>
<blockquote cite="mid:53CF83EB.9010607@oracle.com" type="cite">Hello,
<br>
Any volunteers to be a second reviewer? <br>
<br>
On 17.07.2014 12:18, Petr Pchelko wrote: <br>
<blockquote type="cite">Hello, Sergey. <br>
<br>
The fix looks good to me. <br>
<br>
With best regards. Petr. <br>
<br>
On 16 июля 2014 г., at 20:56, Sergey Bylokhov <a
moz-do-not-send="true" class="moz-txt-link-rfc2396E"
href="mailto:Sergey.Bylokhov@oracle.com"><Sergey.Bylokhov@oracle.com></a>
wrote: <br>
<br>
<blockquote type="cite">Hello. <br>
Please review another one javadoc cleanup in jdk 9 in sound
area: <br>
- @param, @return should not end with a dot, except a case
when more than one sentences are used. <br>
- @param, @throws, @return now align, to be more readable. <br>
- @see tags simplified in some places. <br>
- Description of the class/method/field should be followed
by dot. <br>
- Broken links/typos fixed <br>
- 80 column limit. <br>
- sets of spaces in the middle of text were deleted. <br>
- <tag> replaced by {@tag }. <br>
- unnecessary imports were removed. <br>
<br>
Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8050852">https://bugs.openjdk.java.net/browse/JDK-8050852</a>
<br>
See the full specdiff: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8050852/javadoc/overview-summary.html">http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html</a>
<br>
Webrev can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8050852/webrev.02">http://cr.openjdk.java.net/~serb/8050852/webrev.02</a>
<br>
<br>
-- <br>
Best regards, Sergey. <br>
<br>
</blockquote>
</blockquote>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</body>
</html>