<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Hello.<br>
Please review the fix for jdk9. Two issues were fixed:</tt><br>
<tt>
<meta name="qrichtext" content="1">
8013586: audioInputStream.close() does not release the resource<br>
8130305: AudioSystem behavior depends on order that providers are
located<br>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css">
p, li { white-space: pre-wrap; }</style><br>
Description:<br>
- Streams were not closed when necessary(ex: </tt><tt>
<meta name="qrichtext" content="1">
WaveFloatFileReader.
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css">
p, li { white-space: pre-wrap; }
</style>getAudioInputStream(File)). In the fix they are closed always in
case of any exceptions.<br>
- Some of the readers do not reset the streams when they throw an
UnsupportedAudioFileException exception.<br>
- Some of the readers(like AiffFileReader) do not wrap
(FileInputStream, etc) in BufferedInputStream. <br>
<br>
In the fix I merge all implementations of getAudioXXX to the
SunFileReader.<br>
<br>
Note that I added a comment to the
SunFileReader.getAudioFileFormat(InputStream) that implementation
contradicts the specification, and it seems the javadoc should be
updated? And I created a new issue about EOFException:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8131974">https://bugs.openjdk.java.net/browse/JDK-8131974</a><br>
</tt><br>
<tt>Also I have a related question about WaveExtensibleFileReader
why it was not added to the spi.AudioFileReader? Because of this
WaveExtensibleFileReader actually is never used. Is that
intentionally?<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8013586">https://bugs.openjdk.java.net/browse/JDK-8013586</a><br>
Webrev can be found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8013586/webrev.02">http://cr.openjdk.java.net/~serb/8013586/webrev.02</a></tt><br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</body>
</html>