<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">This change fixes some minor issues found in our code scans.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">I hope this correctly addresses corelib and serviceability issues.
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Please review: <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><a href="http://cr.openjdk.java.net/~goetz/wr16/8170798-java2d_sound/webrev.01/">http://cr.openjdk.java.net/~goetz/wr16/8170798-java2d_sound/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> Goetz.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Changes in detail:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN" style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333">hg-ot-font.cc
<br>
<br>
Looks like assignment instead of compare. Use extra if(). <br>
<br>
<br>
hg-ot_layout-gpos-table.hh <br>
<br>
valueFormat is passed to apply(), where it is used as an array with two elements:
<br>
line 621: valueFormats[1].get_len(); <br>
It was correct as there are actually two fields in the struct that have the <br>
same layout as an array. <br>
<br>
<br>
ScriptAndLanguageTags.cpp, ThaiShaping.cpp/.h <br>
<br>
<br>
In ThaiShaping.cpp:307 conState is passed to getNextState() where it is in the end used to index to thaiStateTable.
<br>
thaiStateTable has 52 elements. But conState is initialized to 0xFF == 255 in ThaiShaping.cpp:296. This can result in an out-of-bounds access.
<br>
<br>
OpenTypeLayoutEngine::scriptTags[scriptCodeCount] is accessed with index < scriptCodeCount, but only contains scriptCodeCount-1 elements.
<br>
<br>
I added a size entry to the enums, and use that for sizing the array and checking the size.
<br>
<br>
<br>
jctrans.c <br>
<br>
if cinfo->entropy->encode_mcu resolves to encode_mcu_AC_first() it will access MCU_buffer[0]. (jcphuff.c:487)
<br>
<br>
<br>
<br>
cmserr.c <br>
<br>
Must check return value of ftell. <br>
<br>
<br>
cmsgamma.c <br>
<br>
Out/out/in are used as arrays in called function. <br>
<br>
<br>
cmslut.c <br>
<br>
Out[] may be used uninitialized. <br>
<br>
<br>
cmstypes.c <br>
<br>
Must check return value of Tell. The negative outcome should not be passed to Seek.
<br>
<br>
<br>
cmsxform.c <br>
<br>
Using uninitialized element of array wIn when calling *p->FromInput. (The function pointer resolves to Pack1Byte.)
<br>
Using uninitialized element of array fIn when calling *p->FromInputFloat. (The function pointer resolves to PackDoublesFromFloat.)
<br>
Using uninitialized element of array fIn when calling *p->FromInputFloat. (The function pointer resolves to PackDoublesFromFloat.)
<br>
<br>
<br>
PLATFORM_API_LinuxOS_ALSA_Ports.c <br>
<br>
Using uninitialized element of array controls when calling *creator->newCompoundControl. (The function pointer resolves to PORT_NewCompoundControl.)
</span><span lang="EN-US"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</body>
</html>