<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8181566/webrev.00/src/java.desktop/share/classes/javax/sound/sampled/AudioSystem.java.sdiff.html">http://cr.openjdk.java.net/~serb/8181566/webrev.00/src/java.desktop/share/classes/javax/sound/sampled/AudioSystem.java.sdiff.html</a><br>
<br>
<pre><span class="changed">1338 * No default are specified,
Either are -> is, or "default" -> "defaults"
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8181566/webrev.00/src/java.desktop/share/classes/javax/sound/sampled/LineEvent.java.sdiff.html">http://cr.openjdk.java.net/~serb/8181566/webrev.00/src/java.desktop/share/classes/javax/sound/sampled/LineEvent.java.sdiff.html</a>
I don't see the point of prettying up the docs on the un-used, commented out constants.
Can't we just delete them ? Seems like the decision was made years ago not to include them in the API
-phil.
</span></pre>
<div class="moz-cite-prefix">On 07/05/2017 11:38 AM, Sergey Bylokhov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4cc166e1-d8e7-4abb-8b3d-4d9c929f5ba7@default">
<pre wrap="">Thanks for review! I am still waiting for one +1.
Note that I'll re-target the fix to jdk10.
----- <a class="moz-txt-link-abbreviated" href="mailto:danrollo@gmail.com">danrollo@gmail.com</a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Sergey,
Looks good to me. +1.
These javadocs reminded me of the “old days” when we were expecting
more controls to evolve. :) I don’t think I ever did find a reliable
way to identify surround sound outputs, other than assuming a certain
platform specific order.
-Dan
</pre>
<blockquote type="cite">
<pre wrap="">On Jun 12, 2017, at 7:29 PM, Sergey Bylokhov
</pre>
</blockquote>
<pre wrap=""><a class="moz-txt-link-rfc2396E" href="mailto:sergey.bylokhov@oracle.com"><sergey.bylokhov@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Hello,
Any volunteers to review?
</pre>
<blockquote type="cite">
<pre wrap="">
Hello,
Please review the documentation fix for jdk9.
In the previous fixes the javadoc for javasound was cleared, but
</pre>
</blockquote>
</blockquote>
<pre wrap="">there are some small window for improvements.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">I suggest to check the specdiff first, because for some methods the
</pre>
</blockquote>
</blockquote>
<pre wrap="">specification was reworked.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8181566">https://bugs.openjdk.java.net/browse/JDK-8181566</a>
Specdiff:
</pre>
</blockquote>
</blockquote>
<pre wrap=""><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8181566/specdiff.00/overview-summary.html">http://cr.openjdk.java.net/~serb/8181566/specdiff.00/overview-summary.html</a>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Webrev can be found at:
</pre>
</blockquote>
</blockquote>
<pre wrap=""><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8181566/webrev.00">http://cr.openjdk.java.net/~serb/8181566/webrev.00</a>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">
Common issues:
- equals(),hashCode() have unusual description like "Finalizes the
</pre>
</blockquote>
</blockquote>
<pre wrap="">hashcode method"
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">- Some classes like "Type" in "CompoundControl.java" has a notion
</pre>
</blockquote>
</blockquote>
<pre wrap="">about static instances, while there are no such instances(I assume
this sentence a copied from other classes like from "Type" in
BooleanControl.java).
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">- In previous cleanup some classes and fields were not marked via
</pre>
</blockquote>
</blockquote>
<pre wrap="">{@code } tag.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">- In [1] Jonathan pointed to the documentation of html5 when the
</pre>
</blockquote>
</blockquote>
<pre wrap=""></p> is optional. I applied the similar existed html5 rule [2] for
other tags </li>,</tr>,</td> - since we have no complicated
tables/lists/layouts this stuff became smaller.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">- In some cases I updated the private specs as well, because I have
</pre>
</blockquote>
</blockquote>
<pre wrap="">an idea to enable (someday) doclint for private fields/methods in
public packages.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">
ccc will be filed after technical review.
[1]
</pre>
</blockquote>
</blockquote>
<pre wrap=""><a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/2d-dev/2017-May/008335.html">http://mail.openjdk.java.net/pipermail/2d-dev/2017-May/008335.html</a>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">[2] <a class="moz-txt-link-freetext" href="https://www.w3.org/TR/html5/syntax.html#syntax-tag-omission">https://www.w3.org/TR/html5/syntax.html#syntax-tag-omission</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
</blockquote>
</blockquote>
<br>
</body>
</html>