<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<pre><span class="removed">- * are examples of typical and acceptable run time exceptions for such cases.</span>
<span class="new">+ * are the examples of typical and acceptable run time exceptions for such</span>
<span class="new">+ * cases.</span></pre>
<br>
all changes like this make the grammar WRONG.<br>
<br>
"the examples" means you've enumerated all of them in which<br>
case they are no longer examples. They are the full list.<br>
<br>
<br>
So revert all of these in javax.print.<br>
<br>
The sound ones look fine.<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 03/08/2018 03:20 PM, Sergey Bylokhov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:52047a4b-d990-2178-f8b5-4768d4ffe7f6@oracle.com">Thank
you for review.
<br>
An updated version:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/4912693/webrev.01/">http://cr.openjdk.java.net/~serb/4912693/webrev.01/</a>
<br>
I also have updated the text in the "javax/print" package
<br>
<br>
On 18/01/2018 16:18, Dan Rollo wrote:
<br>
<blockquote type="cite">Hi Sergey,
<br>
<br>
Looks good to me. One minor grammar thought: “an example of a”.
<br>
<br>
Maybe: {@code NullPointerException} is example of typical...
<br>
Should be: {@code NullPointerException} is an example of a
typical…
<br>
<br>
-Dan
<br>
<br>
<blockquote type="cite">On Jan 17, 2018, at 10:55 PM, Sergey
Bylokhov <a class="moz-txt-link-rfc2396E" href="mailto:Sergey.Bylokhov@oracle.com"><Sergey.Bylokhov@oracle.com></a> wrote:
<br>
<br>
Hello, Audio Guru.
<br>
<br>
Please review the fix for jdk11.
<br>
<br>
The text for behavior of null arguments is added to the
package-info files as suggested in the first step in the bug
report. The text is copied from the javax.print package:
<br>
<a class="moz-txt-link-freetext" href="https://docs.oracle.com/javase/9/docs/api/javax/print/package-summary.html">https://docs.oracle.com/javase/9/docs/api/javax/print/package-summary.html</a>
<br>
<br>
The CSR will be filed after the technical review.
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-4912693">https://bugs.openjdk.java.net/browse/JDK-4912693</a>
<br>
Webrev can be found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/4912693/webrev.00">http://cr.openjdk.java.net/~serb/4912693/webrev.00</a>
<br>
<br>
-- <br>
Best regards, Sergey.
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</body>
</html>