<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Assuming Dan gets a satisfactory answer, this is OK by me.<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 06/21/2018 02:44 PM, Dan Rollo
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:BF4CDA38-0C57-4CEA-B95F-349D8BFB15D0@gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="">Hi Sergey, </div>
<div class=""><br class="">
</div>
Nifty.
<div class="">The “<span style="background-color: rgb(255, 255,
255);" class=""><font class="" face="Arial, sans-serif"
color="#333333">Arrays.stream” approach handles the case
where the passed in parameter is null? Assuming, yes, then
looks good to me.</font></span>
<div class=""><font class="" face="Arial, sans-serif"
color="#333333"><span style="caret-color: rgb(51, 51, 51);
background-color: rgb(255, 255, 255);" class=""><br
class="">
</span></font></div>
<div class=""><font class="" face="Arial, sans-serif"
color="#333333"><span style="caret-color: rgb(51, 51, 51);
background-color: rgb(255, 255, 255);" class="">Dan<br
class="">
</span></font>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Jun 20, 2018, at 10:27 PM, Sergey
Bylokhov <<a href="mailto:Sergey.Bylokhov@oracle.com"
class="" moz-do-not-send="true">Sergey.Bylokhov@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Hello, Audio Guru.<br class="">
<br class="">
Please review the small cleanup for jdk11.<br class="">
<br class="">
Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8205456"
class="" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8205456</a><br
class="">
Webrev: <a
href="http://cr.openjdk.java.net/%7Eserb/8205456/webrev.00"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~serb/8205456/webrev.00</a><br
class="">
<br class="">
Currently we have a few patters to work with arrays in
JavaSound.<br class="">
- Iterates using the for loop<br class="">
- Iterates using Arrays.asList<br class="">
- Iterates using Stream.of<br class="">
<br class="">
- I suggest to unify this and use Arrays.stream in all
cases, because it works for arrays of objects and
primitives(I have skip AudioSystem/MidiSystem in this
fix, I will update them some time later)<br class="">
- In a few places I also changed manual iteration over
array to ".clone()"<br class="">
- small cleanup is done(empty lines/unused vars/etc
are removed)<br class="">
<br class="">
-- <br class="">
Best regards, Sergey.<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
<br>
</body>
</html>