<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
First thing you need is a bug :<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8224056">https://bugs.openjdk.java.net/browse/JDK-8224056</a><br>
<br>
Second is a sponsor. I can help there.<br>
<br>
Can you resubmit with your patch in-line (not an attachment) and the
subject line:<br>
RFR: 8224056: Fix some assignments of string literals to LPSTR
(instead of LPCSTR)<br>
<br>
You said "a few issues" and "some of these" but you only have one
that I see<br>
<br>
-LPSTR TranslateDSError(HRESULT hr) {
<br>
+LPCSTR TranslateDSError(HRESULT hr) {<br>
<br>
What am I missing ? I don't want a patch per case, I'd like just one
patch for all of java sound.<br>
<br>
We should also test this builds in the standard mode although I
don't see why it should not.<br>
<br>
<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 5/13/19 5:36 PM, Andrew Luo wrote:<br>
</div>
<blockquote type="cite"
cite="mid:MWHPR13MB16965BC679B27254BA62A93EA1080@MWHPR13MB1696.namprd13.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">I’ve been trying to get the JDK to compile
with the new /permissive- switch in VS2017 (<a
href="https://devblogs.microsoft.com/cppblog/permissive-switch/"
moz-do-not-send="true">https://devblogs.microsoft.com/cppblog/permissive-switch/</a>)
however there have been a few issues in various parts of the
code. There are a few issues in the libjsound code where we
attempt to assign string literals to LPSTR variables (instead
of LPCSTR). I took some time to fix some of these and
attached a patch. Let me know if you have any
comments/feedback. I’m assuming that libjsound is owned by
sound-dev, but if I’m mistaken, please do let me know the
right team/mailing list to send this to.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363):
error C2440: 'return': cannot convert from 'const char [16]'
to 'LPSTR'<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">-Andrew<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>