<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8236980/webrev.00/src/java.desktop/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html">http://cr.openjdk.java.net/~serb/8236980/webrev.00/src/java.desktop/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html</a><br>
<pre><span class="removed">- * Provides a string representation of the device information.</span>
<span class="new">+ * Returns a string representation of the info object.</span>
*
<span class="removed">- * @return a description of the info object</span>
<span class="new">+ * @return a string representation of the info object
Why is this better ?
What is an "info object" ?
Why not ?
</span>
<span class="new"><span class="new">"Returns a string representation of the device"?</span>
And it returns the same thing as "name" anyway.
Are you avoiding over-specifying to that extent ?
Yet you preserve that same behaviour here (and elsewhere) :-
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8236980/webrev.00/src/java.desktop/share/classes/javax/sound/midi/Sequencer.java.udiff.html">http://cr.openjdk.java.net/~serb/8236980/webrev.00/src/java.desktop/share/classes/javax/sound/midi/Sequencer.java.udiff.html</a>
Are you intending a CSR for any of this ?
-phil
</span></pre>
<div class="moz-cite-prefix">On 1/12/20 12:14 PM, Sergey Bylokhov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:318540c8-7d86-c185-41dd-e9520e411f51@oracle.com">Hello.
<br>
Please review a "weekend cleanup" for JDK 15.
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8236980">https://bugs.openjdk.java.net/browse/JDK-8236980</a>
<br>
Fix: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8236980/webrev.00">http://cr.openjdk.java.net/~serb/8236980/webrev.00</a>
<br>
<br>
I have made these changes:
<br>
- The words in the specs are unified across the different methods
<br>
- All toString() implementations now use getXXX() methods instead
<br>
of direct access to the fields(the getxxx() methods are skipped
<br>
only if the getxxx() method is final)
<br>
- A few tests were added to check some spec, and its
implementations
<br>
<br>
</blockquote>
<br>
</body>
</html>