<Swing Dev> [PATCH] fix GTKLookAndFeel crash on recent versions of GTK

Kirill Kirichenko Kirill.Kirichenko at Sun.COM
Tue Nov 27 12:51:03 UTC 2007


Hi Thomas.

I'm responsible for GTK L&F.

I's a bit straightforward way. At least we can add a GtkEntry there. We 
add Entry and Button in a ComboBoxEntry because we render JComboBox by 
parts in Java and in previous versions Entry and Button had to be in a 
ComboBoxEntry because they rendered differently if their parent was a 
ComboBoxEntry. Best way here is to find out how ArrowButtons are 
rendered in native gtk and do the same in our code.

Unfortunately I'm busy at another project for 100% of my time. Such are 
priorities.

It you find another solution I'd like to have a look.

Thanks for your comments.
Kirill

Thomas Fitzsimmons wrote:
> Hi,
> 
> With OpenJDK build b23, on recent GTK versions, showing a JComboBox when 
> GTKLookAndFeel is active causes this assertion failure:
> 
> (<unknown>:11755): Gtk-WARNING **: Attempting to add a widget with type
> GtkButton to a GtkComboBoxEntry (need an instance of GtkEntry or of a 
> subclass)
> 
> The assertion was added in this commit:
> 
> http://svn.gnome.org/viewcvs/gtk+?view=revision&revision=17657
> 
> Attached is a test case demonstrating the failure and a patch to fix 
> it.  The
> patch eliminates theme engines' ability to special-case the arrow 
> button/text
> field combination but given the new assertion this appears to be the best
> option.  Visually, JComboBox still looks fine under the theme engines 
> shipped
> with Fedora 8.
> 
> Tom
> 



More information about the swing-dev mailing list