<Swing Dev> [PATCH] 6179357-related: Working on warnings removal

Pavel Porvatov Pavel.Porvatov at Sun.COM
Tue Oct 16 19:39:46 UTC 2007


Hi Roman,

Hmm. It's copy.paste mistake:) This comment relatives to 2 . I meant:


1. DesktopProperty:
Can You change declaration into
private final static ReferenceQueue<Object> queue = new 
ReferenceQueue<Object>();
and remove a static section?

2. WindowsScrollBarUI:
Can You change declaration into
         private final static Map<String, WeakReference<Grid>> map = new 
HashMap<String, WeakReference<Grid>>();
(note that I added final and replaced HashMap by Map) and remove a 
static section?

Thanks, Pavel.

> Hi there,
> 
> 
>> 1. DesktopProperty:
>> Can You change declaration into
>> private final static ReferenceQueue<Object> queue = new 
>> ReferenceQueue<Object>();
>> (note that I added final and replaced HashMap by Map) and remove a 
>> static section?
> 
> This isn't exactly correct. The equivalent of a ReferenceQueue in
> generics notation is ReferenceQueue<?>. See: 
> 
> http://java.sun.com/docs/books/tutorial/java/generics/subtyping.html
> 
> Correct me if I'm wrong on this.
> 
> /Roman
> 




More information about the swing-dev mailing list