<Swing Dev> [PATCH] 6179357-related: warnings removal in com.sun.java.swing.plaf.motif

[Florian Brunner]

Hi Pavel!

> Your patch looks good. I've only one notice: we don't use "TAB"
> characters in our sources. Can you remove all TABs from your fix?

Yes, of course! I wonder in which step I changed them to TABs!? I send you 
here the same patch but without the TABs.

-Florian

Am Freitag, 11. Januar 2008 schrieb Pavel Porvatov:
> Hi Florian,
>
> > Hi Pavel!
> >
> > As you remember I'm working on adding generics to the Swing-framework. To
> > see if I introduce new warnings while working on this task (especially
> > unchecked and cast warnings) I need to reduce the number of warnings in
> > the Swing-project first.
> >
> > I cloned the following repository:
> > http://hg.openjdk.java.net/jdk7/jdk7/jdk Is this correct?
>
> Yes.
>
> > When compiling with
> > -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
> > -Xlint:-fallthrough -Xmaxwarns 2300
> > this patch reduces the number of reported warnings from 1277 to 1262.
>
> Your patch looks good. I've only one notice: we don't use "TAB"
> characters in our sources. Can you remove all TABs from your fix?
>
> > The basis of this patch is  the changeset 99a06bc7fdb5. It has been
> > created with 'hg diff'. NetBeans' 'Tools->Apply Diff Patch' does not work
> > unfortunatly but 'hg import' should work.
> >
> > And now: Happy New Year! :-)
>
> Thanks. Our holidays finished a couple days ago. Sorry for delay...
>
> Pavel.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: swing-patch-20080119-warnings_com-sun-java-swing-plaf-motif.patch
Type: text/x-diff
Size: 5479 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20080119/784ec377/swing-patch-20080119-warnings_com-sun-java-swing-plaf-motif.patch>