From Octavian.Tanase at Sun.COM  Mon Nov  3 22:44:40 2008
From: Octavian.Tanase at Sun.COM (Octavian Tanase)
Date: Mon, 03 Nov 2008 14:44:40 -0800
Subject: <Swing Dev> are you there ...
Message-ID: <490F7ED8.7090705@sun.com>

What are you guys working on?

--Octavian


From Alexander.Potochkin at Sun.COM  Wed Nov  5 17:37:32 2008
From: Alexander.Potochkin at Sun.COM (Alexander Potochkin)
Date: Wed, 05 Nov 2008 20:37:32 +0300
Subject: <Swing Dev> are you there ...
In-Reply-To: <490F7ED8.7090705@sun.com>
References: <490F7ED8.7090705@sun.com>
Message-ID: <4911D9DC.6080206@sun.com>

Hello Octavian

> What are you guys working on?

We are working on Swing bugs
(consulting, evaluating and fixing)
and Swing features (e.g. JSR 295 & 296)

please let me know if need any specific information

Thanks
alexp

> 
> --Octavian



From Artem.Ananiev at Sun.COM  Thu Nov  6 12:27:27 2008
From: Artem.Ananiev at Sun.COM (Artem Ananiev)
Date: Thu, 06 Nov 2008 15:27:27 +0300
Subject: <Swing Dev> <AWT Dev> Bad component spacing
In-Reply-To: <4912D242.1010404@sun.com>
References: <4912D242.1010404@sun.com>
Message-ID: <4912E2AF.6090708@sun.com>

Hi, Marek,

as your test uses Swing menus, it looks like a Swing (or probably 
Java2D, because of font metrics) problem, rather than AWT one.

Thanks,

Artem

Marek Slama wrote:
> Hello,
> 
> we encounter problem with too big spacing around text in Swing 
> components in openjdk. I attach
> 2 snapshots of MenuLookDemo on openjdk and Sun JDK 6u10 on Ubuntu 
> 8.10/Metal L&F. I was pointed
> to this maling list. Is it known problem? I do not know if it is 
> specific to Ubuntu only.
> 
> java version "1.6.0_10"
> Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Java HotSpot(TM) Client VM (build 11.0-b15, mixed mode, sharing)
> 
> java version "1.6.0_0"
> IcedTea6 1.3.1 (6b12-0ubuntu6) Runtime Environment (build 1.6.0_0-b12)
> OpenJDK Client VM (build 1.6.0_0-b12, mixed mode, sharing)
> 
> Both use the same font:
> javax.swing.plaf.FontUIResource[family=Dialog,name=Dialog,style=bold,size=12] 
> 
> 
> Original issue report is https://bugs.launchpad.net/bugs/289784
> 
> Thanks
> 
> Marek


From Igor.Nekrestyanov at Sun.COM  Thu Nov  6 17:47:40 2008
From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov)
Date: Thu, 06 Nov 2008 20:47:40 +0300
Subject: <Swing Dev> [OpenJDK 2D-Dev] <AWT Dev> Bad component spacing
In-Reply-To: <4912E2AF.6090708@sun.com>
References: <4912D242.1010404@sun.com> <4912E2AF.6090708@sun.com>
Message-ID: <49132DBC.5080106@sun.com>

This is likely to be same as
  http://monaco.sfbay.sun.com/detail.jsf?cr=6761856
that was recently fixed and did not make it into main openjdk ws yet but 
you can pull these changes from 2D workspace to test.

-igor

Artem Ananiev wrote:
> Hi, Marek,
>
> as your test uses Swing menus, it looks like a Swing (or probably 
> Java2D, because of font metrics) problem, rather than AWT one.
>
> Thanks,
>
> Artem
>
> Marek Slama wrote:
>> Hello,
>>
>> we encounter problem with too big spacing around text in Swing 
>> components in openjdk. I attach
>> 2 snapshots of MenuLookDemo on openjdk and Sun JDK 6u10 on Ubuntu 
>> 8.10/Metal L&F. I was pointed
>> to this maling list. Is it known problem? I do not know if it is 
>> specific to Ubuntu only.
>>
>> java version "1.6.0_10"
>> Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
>> Java HotSpot(TM) Client VM (build 11.0-b15, mixed mode, sharing)
>>
>> java version "1.6.0_0"
>> IcedTea6 1.3.1 (6b12-0ubuntu6) Runtime Environment (build 1.6.0_0-b12)
>> OpenJDK Client VM (build 1.6.0_0-b12, mixed mode, sharing)
>>
>> Both use the same font:
>> javax.swing.plaf.FontUIResource[family=Dialog,name=Dialog,style=bold,size=12] 
>>
>>
>> Original issue report is https://bugs.launchpad.net/bugs/289784
>>
>> Thanks
>>
>> Marek



From mark at klomp.org  Fri Nov  7 13:05:47 2008
From: mark at klomp.org (Mark Wielaard)
Date: Fri, 07 Nov 2008 14:05:47 +0100
Subject: <Swing Dev> <AWT Dev> [OpenJDK 2D-Dev]  Bad component spacing
In-Reply-To: <49132DBC.5080106@sun.com>
References: <4912D242.1010404@sun.com> <4912E2AF.6090708@sun.com>
	<49132DBC.5080106@sun.com>
Message-ID: <1226063147.3310.12.camel@dijkstra.wildebeest.org>

Hi,

On Thu, 2008-11-06 at 20:47 +0300, Igor Nekrestyanov wrote:
> This is likely to be same as
>   http://monaco.sfbay.sun.com/detail.jsf?cr=6761856
> that was recently fixed and did not make it into main openjdk ws yet but 
> you can pull these changes from 2D workspace to test.

For those in the community without access to internal sun machines this
is: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6761856
and: http://hg.openjdk.java.net/jdk7/2d-gate/jdk/rev/9cdababf6179

This was also reported against IcedTea as:
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=227

I have imported the patch into IcedTea6 and tested that it fixes the
mentioned issues:

2008-10-29  Mark Wielaard  <mark at klomp.org>

   * patches/icedtea-6761856-freetypescaler.patch: New patch.
   * Makefile.am (ICEDTEA_PATCHES): Add new patch.
   * HACKING: Document new patch.

Cheers,

Mark



From Igor.Nekrestyanov at Sun.COM  Fri Nov  7 14:10:14 2008
From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov)
Date: Fri, 07 Nov 2008 17:10:14 +0300
Subject: <Swing Dev> [OpenJDK 2D-Dev] <AWT Dev>   Bad component spacing
In-Reply-To: <1226063147.3310.12.camel@dijkstra.wildebeest.org>
References: <4912D242.1010404@sun.com> <4912E2AF.6090708@sun.com>
	<49132DBC.5080106@sun.com>
	<1226063147.3310.12.camel@dijkstra.wildebeest.org>
Message-ID: <49144C46.9090303@sun.com>

Thank you Mark!

i keep forgetting that bug database is not available to everyone yet :(

-igor

Mark Wielaard wrote:
> Hi,
>
> On Thu, 2008-11-06 at 20:47 +0300, Igor Nekrestyanov wrote:
>   
>> This is likely to be same as
>>   http://monaco.sfbay.sun.com/detail.jsf?cr=6761856
>> that was recently fixed and did not make it into main openjdk ws yet but 
>> you can pull these changes from 2D workspace to test.
>>     
>
> For those in the community without access to internal sun machines this
> is: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6761856
> and: http://hg.openjdk.java.net/jdk7/2d-gate/jdk/rev/9cdababf6179
>
> This was also reported against IcedTea as:
> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=227
>
> I have imported the patch into IcedTea6 and tested that it fixes the
> mentioned issues:
>
> 2008-10-29  Mark Wielaard  <mark at klomp.org>
>
>    * patches/icedtea-6761856-freetypescaler.patch: New patch.
>    * Makefile.am (ICEDTEA_PATCHES): Add new patch.
>    * HACKING: Document new patch.
>
> Cheers,
>
> Mark
>
>   



From Marek.Slama at Sun.COM  Fri Nov  7 14:22:02 2008
From: Marek.Slama at Sun.COM (Marek Slama)
Date: Fri, 07 Nov 2008 15:22:02 +0100
Subject: <Swing Dev> <AWT Dev> [OpenJDK 2D-Dev]  Bad component spacing
In-Reply-To: <49132DBC.5080106@sun.com>
References: <4912D242.1010404@sun.com> <4912E2AF.6090708@sun.com>
	<49132DBC.5080106@sun.com>
Message-ID: <49144F0A.4080902@sun.com>

Igor Nekrestyanov wrote:
> This is likely to be same as
>  http://monaco.sfbay.sun.com/detail.jsf?cr=6761856
> that was recently fixed and did not make it into main openjdk ws yet 
> but you can pull these changes from 2D workspace to test.
>
I can confirm spacing issue is fixed. I tested on 2D workspace.

Marek
> -igor
>
> Artem Ananiev wrote:
>> Hi, Marek,
>>
>> as your test uses Swing menus, it looks like a Swing (or probably 
>> Java2D, because of font metrics) problem, rather than AWT one.
>>
>> Thanks,
>>
>> Artem
>>
>> Marek Slama wrote:
>>> Hello,
>>>
>>> we encounter problem with too big spacing around text in Swing 
>>> components in openjdk. I attach
>>> 2 snapshots of MenuLookDemo on openjdk and Sun JDK 6u10 on Ubuntu 
>>> 8.10/Metal L&F. I was pointed
>>> to this maling list. Is it known problem? I do not know if it is 
>>> specific to Ubuntu only.
>>>
>>> java version "1.6.0_10"
>>> Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
>>> Java HotSpot(TM) Client VM (build 11.0-b15, mixed mode, sharing)
>>>
>>> java version "1.6.0_0"
>>> IcedTea6 1.3.1 (6b12-0ubuntu6) Runtime Environment (build 1.6.0_0-b12)
>>> OpenJDK Client VM (build 1.6.0_0-b12, mixed mode, sharing)
>>>
>>> Both use the same font:
>>> javax.swing.plaf.FontUIResource[family=Dialog,name=Dialog,style=bold,size=12] 
>>>
>>>
>>> Original issue report is https://bugs.launchpad.net/bugs/289784
>>>
>>> Thanks
>>>
>>> Marek
>



From fbrunnerlist at gmx.ch  Sun Nov  9 18:19:29 2008
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Sun, 9 Nov 2008 19:19:29 +0100
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <48EF6858.1090309@sun.com>
References: <200810090136.40637.fbrunnerlist@gmx.ch> <48EF6858.1090309@sun.com>
Message-ID: <200811091919.29426.fbrunnerlist@gmx.ch>

Hi Pavel,

any news about my patch?

Thanks.
-Florian

Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
> Hi Florian,
>
> Thanks for your patch. I'll review your patch in two-three weeks and
> mail you response.
>
> Thanks, Pavel.
>
> > Hi,
> >
> > here another patch to remove warnings in the gtk package.
> >
> > When compiling with
> > -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
> > -Xlint:-fallthrough -Xmaxwarns 2300
> > this patch reduces the number of reported warnings from 201 to 112.
> >
> > Again, I tried only to change things related to the warnings and not to
> > change any public or protected APIs in public or protected classes in
> > this patch.
> >
> > At many places I tried to add type parameters as meaningful as possible,
> > but with some cases I just used Object, if a more meaningful type
> > parameter was not so trivial. You might want to refactor this if needed.
> > (Though everything should work as it is.)
> >
> > -Florian




From Pavel.Porvatov at Sun.COM  Tue Nov 11 16:11:30 2008
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Tue, 11 Nov 2008 19:11:30 +0300
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <200811091919.29426.fbrunnerlist@gmx.ch>
References: <200810090136.40637.fbrunnerlist@gmx.ch> <48EF6858.1090309@sun.com>
	<200811091919.29426.fbrunnerlist@gmx.ch>
Message-ID: <4919AEB2.9070400@sun.com>

Hi Florian,

I'm checking your patch. Results will be in the nearest two days.

Regards, Pavel.

> Hi Pavel,
> 
> any news about my patch?
> 
> Thanks.
> -Florian
> 
> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>> Hi Florian,
>>
>> Thanks for your patch. I'll review your patch in two-three weeks and
>> mail you response.
>>
>> Thanks, Pavel.
>>
>>> Hi,
>>>
>>> here another patch to remove warnings in the gtk package.
>>>
>>> When compiling with
>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>> this patch reduces the number of reported warnings from 201 to 112.
>>>
>>> Again, I tried only to change things related to the warnings and not to
>>> change any public or protected APIs in public or protected classes in
>>> this patch.
>>>
>>> At many places I tried to add type parameters as meaningful as possible,
>>> but with some cases I just used Object, if a more meaningful type
>>> parameter was not so trivial. You might want to refactor this if needed.
>>> (Though everything should work as it is.)
>>>
>>> -Florian
> 
> 



From Pavel.Porvatov at Sun.COM  Wed Nov 12 13:40:19 2008
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Wed, 12 Nov 2008 16:40:19 +0300
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <200811091919.29426.fbrunnerlist@gmx.ch>
References: <200810090136.40637.fbrunnerlist@gmx.ch> <48EF6858.1090309@sun.com>
	<200811091919.29426.fbrunnerlist@gmx.ch>
Message-ID: <491ADCC3.9090001@sun.com>

Hi Florian,

Your fix looks very good. I have a couple comments:

1.
com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLocationToRGB 
- can you fix javadoc please (this is a private method). The last 
"param" tag should be replaced by "return" tag

2.
@@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile

      private class GTKDirectoryModel extends BasicDirectoryModel {
          FileSystemView fsv;
-        private Comparator fileComparator = new Comparator() {
-            public int compare(Object o, Object o1) {
-                return fsv.getSystemDisplayName((File) o).compareTo
-                      (fsv.getSystemDisplayName((File) o1));
+        private Comparator<File> fileComparator = new Comparator<File>() {
+            public int compare(File o, File o1) {
+                return fsv.getSystemDisplayName(o).compareTo
+                      (fsv.getSystemDisplayName(o1));
              }
          };

Can you make return statement in a single line please


Regards, Pavel.

> Hi Pavel,
> 
> any news about my patch?
> 
> Thanks.
> -Florian
> 
> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>> Hi Florian,
>>
>> Thanks for your patch. I'll review your patch in two-three weeks and
>> mail you response.
>>
>> Thanks, Pavel.
>>
>>> Hi,
>>>
>>> here another patch to remove warnings in the gtk package.
>>>
>>> When compiling with
>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>> this patch reduces the number of reported warnings from 201 to 112.
>>>
>>> Again, I tried only to change things related to the warnings and not to
>>> change any public or protected APIs in public or protected classes in
>>> this patch.
>>>
>>> At many places I tried to add type parameters as meaningful as possible,
>>> but with some cases I just used Object, if a more meaningful type
>>> parameter was not so trivial. You might want to refactor this if needed.
>>> (Though everything should work as it is.)
>>>
>>> -Florian
> 
> 



From fbrunnerlist at gmx.ch  Thu Nov 13 01:40:27 2008
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Thu, 13 Nov 2008 02:40:27 +0100
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <491ADCC3.9090001@sun.com>
References: <200810090136.40637.fbrunnerlist@gmx.ch>
	<200811091919.29426.fbrunnerlist@gmx.ch> <491ADCC3.9090001@sun.com>
Message-ID: <200811130240.27825.fbrunnerlist@gmx.ch>

Hi Pavel,

I fixed the 2 issues.

-Florian

Am Mittwoch, 12. November 2008 schrieb Pavel Porvatov:
> Hi Florian,
>
> Your fix looks very good. I have a couple comments:
>
> 1.
> com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLo
>cationToRGB - can you fix javadoc please (this is a private method). The
> last
> "param" tag should be replaced by "return" tag
>
> 2.
> @@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile
>
>       private class GTKDirectoryModel extends BasicDirectoryModel {
>           FileSystemView fsv;
> -        private Comparator fileComparator = new Comparator() {
> -            public int compare(Object o, Object o1) {
> -                return fsv.getSystemDisplayName((File) o).compareTo
> -                      (fsv.getSystemDisplayName((File) o1));
> +        private Comparator<File> fileComparator = new Comparator<File>() {
> +            public int compare(File o, File o1) {
> +                return fsv.getSystemDisplayName(o).compareTo
> +                      (fsv.getSystemDisplayName(o1));
>               }
>           };
>
> Can you make return statement in a single line please
>
>
> Regards, Pavel.
>
> > Hi Pavel,
> >
> > any news about my patch?
> >
> > Thanks.
> > -Florian
> >
> > Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
> >> Hi Florian,
> >>
> >> Thanks for your patch. I'll review your patch in two-three weeks and
> >> mail you response.
> >>
> >> Thanks, Pavel.
> >>
> >>> Hi,
> >>>
> >>> here another patch to remove warnings in the gtk package.
> >>>
> >>> When compiling with
> >>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
> >>> -Xlint:-fallthrough -Xmaxwarns 2300
> >>> this patch reduces the number of reported warnings from 201 to 112.
> >>>
> >>> Again, I tried only to change things related to the warnings and not to
> >>> change any public or protected APIs in public or protected classes in
> >>> this patch.
> >>>
> >>> At many places I tried to add type parameters as meaningful as
> >>> possible, but with some cases I just used Object, if a more meaningful
> >>> type parameter was not so trivial. You might want to refactor this if
> >>> needed. (Though everything should work as it is.)
> >>>
> >>> -Florian


-------------- next part --------------
A non-text attachment was scrubbed...
Name: swing-patch-20081113-warnings_gtk.patch
Type: text/x-diff
Size: 13081 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20081113/8fe50a54/swing-patch-20081113-warnings_gtk.patch>

From Pavel.Porvatov at Sun.COM  Thu Nov 13 11:55:47 2008
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Thu, 13 Nov 2008 14:55:47 +0300
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <200811130240.27825.fbrunnerlist@gmx.ch>
References: <200810090136.40637.fbrunnerlist@gmx.ch>
	<200811091919.29426.fbrunnerlist@gmx.ch> <491ADCC3.9090001@sun.com>
	<200811130240.27825.fbrunnerlist@gmx.ch>
Message-ID: <491C15C3.2050404@sun.com>

Hi Florian,

I approved your fix and now you can commit it. Don't forget write 
appropriate changeset comment (see 
http://openjdk.java.net/guide/producingChangeset.html#changesetComment).

I filed a bug for your change:
<bugid>: 6771030
<synopsis-of-symptom>: Code improvement and warnings removing from the 
com.sun.java.swing.plaf.gtk package

Let me know if you have any question.

Thanks, Pavel.

> Hi Pavel,
> 
> I fixed the 2 issues.
> 
> -Florian
> 
> Am Mittwoch, 12. November 2008 schrieb Pavel Porvatov:
>> Hi Florian,
>>
>> Your fix looks very good. I have a couple comments:
>>
>> 1.
>> com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLo
>> cationToRGB - can you fix javadoc please (this is a private method). The
>> last
>> "param" tag should be replaced by "return" tag
>>
>> 2.
>> @@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile
>>
>>       private class GTKDirectoryModel extends BasicDirectoryModel {
>>           FileSystemView fsv;
>> -        private Comparator fileComparator = new Comparator() {
>> -            public int compare(Object o, Object o1) {
>> -                return fsv.getSystemDisplayName((File) o).compareTo
>> -                      (fsv.getSystemDisplayName((File) o1));
>> +        private Comparator<File> fileComparator = new Comparator<File>() {
>> +            public int compare(File o, File o1) {
>> +                return fsv.getSystemDisplayName(o).compareTo
>> +                      (fsv.getSystemDisplayName(o1));
>>               }
>>           };
>>
>> Can you make return statement in a single line please
>>
>>
>> Regards, Pavel.
>>
>>> Hi Pavel,
>>>
>>> any news about my patch?
>>>
>>> Thanks.
>>> -Florian
>>>
>>> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>>>> Hi Florian,
>>>>
>>>> Thanks for your patch. I'll review your patch in two-three weeks and
>>>> mail you response.
>>>>
>>>> Thanks, Pavel.
>>>>
>>>>> Hi,
>>>>>
>>>>> here another patch to remove warnings in the gtk package.
>>>>>
>>>>> When compiling with
>>>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>>>> this patch reduces the number of reported warnings from 201 to 112.
>>>>>
>>>>> Again, I tried only to change things related to the warnings and not to
>>>>> change any public or protected APIs in public or protected classes in
>>>>> this patch.
>>>>>
>>>>> At many places I tried to add type parameters as meaningful as
>>>>> possible, but with some cases I just used Object, if a more meaningful
>>>>> type parameter was not so trivial. You might want to refactor this if
>>>>> needed. (Though everything should work as it is.)
>>>>>
>>>>> -Florian
> 
> 



From fbrunnerlist at gmx.ch  Thu Nov 13 15:12:03 2008
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Thu, 13 Nov 2008 16:12:03 +0100
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <491C15C3.2050404@sun.com>
References: <200810090136.40637.fbrunnerlist@gmx.ch>
	<200811091919.29426.fbrunnerlist@gmx.ch> <491ADCC3.9090001@sun.com>
	<200811130240.27825.fbrunnerlist@gmx.ch> <491C15C3.2050404@sun.com>
Message-ID: <491C43C3.3050907@gmx.ch>

Hi Pavel,

ok, thanks. But do I have the access rights to commit changes to 
http://hg.openjdk.java.net/jdk7/swing/jdk ? Is it open for everybody? 
How do you ensure, that only reviewed stuff gets into the jdk?

You said you filed a new bug for the change (6771030), but I cannot find 
it at
http://bugs.sun.com/bugdatabase/

Also note that all my patches so far were related to issue 6179357.

-Florian

Pavel Porvatov schrieb:
> Hi Florian,
>
> I approved your fix and now you can commit it. Don't forget write 
> appropriate changeset comment (see 
> http://openjdk.java.net/guide/producingChangeset.html#changesetComment).
>
> I filed a bug for your change:
> <bugid>: 6771030
> <synopsis-of-symptom>: Code improvement and warnings removing from the 
> com.sun.java.swing.plaf.gtk package
>
> Let me know if you have any question.
>
> Thanks, Pavel.
>
>> Hi Pavel,
>>
>> I fixed the 2 issues.
>>
>> -Florian
>>
>> Am Mittwoch, 12. November 2008 schrieb Pavel Porvatov:
>>> Hi Florian,
>>>
>>> Your fix looks very good. I have a couple comments:
>>>
>>> 1.
>>> com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLo 
>>>
>>> cationToRGB - can you fix javadoc please (this is a private method). 
>>> The
>>> last
>>> "param" tag should be replaced by "return" tag
>>>
>>> 2.
>>> @@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile
>>>
>>>       private class GTKDirectoryModel extends BasicDirectoryModel {
>>>           FileSystemView fsv;
>>> -        private Comparator fileComparator = new Comparator() {
>>> -            public int compare(Object o, Object o1) {
>>> -                return fsv.getSystemDisplayName((File) o).compareTo
>>> -                      (fsv.getSystemDisplayName((File) o1));
>>> +        private Comparator<File> fileComparator = new 
>>> Comparator<File>() {
>>> +            public int compare(File o, File o1) {
>>> +                return fsv.getSystemDisplayName(o).compareTo
>>> +                      (fsv.getSystemDisplayName(o1));
>>>               }
>>>           };
>>>
>>> Can you make return statement in a single line please
>>>
>>>
>>> Regards, Pavel.
>>>
>>>> Hi Pavel,
>>>>
>>>> any news about my patch?
>>>>
>>>> Thanks.
>>>> -Florian
>>>>
>>>> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>>>>> Hi Florian,
>>>>>
>>>>> Thanks for your patch. I'll review your patch in two-three weeks and
>>>>> mail you response.
>>>>>
>>>>> Thanks, Pavel.
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> here another patch to remove warnings in the gtk package.
>>>>>>
>>>>>> When compiling with
>>>>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>>>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>>>>> this patch reduces the number of reported warnings from 201 to 112.
>>>>>>
>>>>>> Again, I tried only to change things related to the warnings and 
>>>>>> not to
>>>>>> change any public or protected APIs in public or protected 
>>>>>> classes in
>>>>>> this patch.
>>>>>>
>>>>>> At many places I tried to add type parameters as meaningful as
>>>>>> possible, but with some cases I just used Object, if a more 
>>>>>> meaningful
>>>>>> type parameter was not so trivial. You might want to refactor 
>>>>>> this if
>>>>>> needed. (Though everything should work as it is.)
>>>>>>
>>>>>> -Florian
>>
>>
>



From Phil.Race at Sun.COM  Thu Nov 13 17:30:46 2008
From: Phil.Race at Sun.COM (Phil Race)
Date: Thu, 13 Nov 2008 09:30:46 -0800
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <491C43C3.3050907@gmx.ch>
References: <200810090136.40637.fbrunnerlist@gmx.ch>
	<200811091919.29426.fbrunnerlist@gmx.ch> <491ADCC3.9090001@sun.com>
	<200811130240.27825.fbrunnerlist@gmx.ch> <491C15C3.2050404@sun.com>
	<491C43C3.3050907@gmx.ch>
Message-ID: <491C6446.9010106@sun.com>

To the best of my knowledge, you won't be able to commit.
Pavel should act as sponsor and commit the patch on your behalf.

To be able commit to a repo on the OpenJDK site you need to have
an OpenJDK user id. To get that I think you need to be voted in as
a member of a project or group. Submitting patches is a step in
the process towards being considered for election as a member.

Mark: Is this right?

I've trawled around the openjdk site looking for a definite
statement on how this works, but can't locate one, but I
think there must be something on this.

Mark: Is there an FAQ on this?

-phil.

Florian Brunner wrote:
> Hi Pavel,
> 
> ok, thanks. But do I have the access rights to commit changes to 
> http://hg.openjdk.java.net/jdk7/swing/jdk ? Is it open for everybody? 
> How do you ensure, that only reviewed stuff gets into the jdk?
> 
> You said you filed a new bug for the change (6771030), but I cannot find 
> it at
> http://bugs.sun.com/bugdatabase/
> 
> Also note that all my patches so far were related to issue 6179357.
> 
> -Florian
> 
> Pavel Porvatov schrieb:
>> Hi Florian,
>>
>> I approved your fix and now you can commit it. Don't forget write 
>> appropriate changeset comment (see 
>> http://openjdk.java.net/guide/producingChangeset.html#changesetComment).
>>
>> I filed a bug for your change:
>> <bugid>: 6771030
>> <synopsis-of-symptom>: Code improvement and warnings removing from the 
>> com.sun.java.swing.plaf.gtk package
>>
>> Let me know if you have any question.
>>
>> Thanks, Pavel.
>>
>>> Hi Pavel,
>>>
>>> I fixed the 2 issues.
>>>
>>> -Florian
>>>
>>> Am Mittwoch, 12. November 2008 schrieb Pavel Porvatov:
>>>> Hi Florian,
>>>>
>>>> Your fix looks very good. I have a couple comments:
>>>>
>>>> 1.
>>>> com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLo 
>>>>
>>>> cationToRGB - can you fix javadoc please (this is a private method). 
>>>> The
>>>> last
>>>> "param" tag should be replaced by "return" tag
>>>>
>>>> 2.
>>>> @@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile
>>>>
>>>>       private class GTKDirectoryModel extends BasicDirectoryModel {
>>>>           FileSystemView fsv;
>>>> -        private Comparator fileComparator = new Comparator() {
>>>> -            public int compare(Object o, Object o1) {
>>>> -                return fsv.getSystemDisplayName((File) o).compareTo
>>>> -                      (fsv.getSystemDisplayName((File) o1));
>>>> +        private Comparator<File> fileComparator = new 
>>>> Comparator<File>() {
>>>> +            public int compare(File o, File o1) {
>>>> +                return fsv.getSystemDisplayName(o).compareTo
>>>> +                      (fsv.getSystemDisplayName(o1));
>>>>               }
>>>>           };
>>>>
>>>> Can you make return statement in a single line please
>>>>
>>>>
>>>> Regards, Pavel.
>>>>
>>>>> Hi Pavel,
>>>>>
>>>>> any news about my patch?
>>>>>
>>>>> Thanks.
>>>>> -Florian
>>>>>
>>>>> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>>>>>> Hi Florian,
>>>>>>
>>>>>> Thanks for your patch. I'll review your patch in two-three weeks and
>>>>>> mail you response.
>>>>>>
>>>>>> Thanks, Pavel.
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> here another patch to remove warnings in the gtk package.
>>>>>>>
>>>>>>> When compiling with
>>>>>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>>>>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>>>>>> this patch reduces the number of reported warnings from 201 to 112.
>>>>>>>
>>>>>>> Again, I tried only to change things related to the warnings and 
>>>>>>> not to
>>>>>>> change any public or protected APIs in public or protected 
>>>>>>> classes in
>>>>>>> this patch.
>>>>>>>
>>>>>>> At many places I tried to add type parameters as meaningful as
>>>>>>> possible, but with some cases I just used Object, if a more 
>>>>>>> meaningful
>>>>>>> type parameter was not so trivial. You might want to refactor 
>>>>>>> this if
>>>>>>> needed. (Though everything should work as it is.)
>>>>>>>
>>>>>>> -Florian
>>>
>>>
>>
> 


From fbrunnerlist at gmx.ch  Thu Nov 13 17:53:00 2008
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Thu, 13 Nov 2008 18:53:00 +0100
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <491C6446.9010106@sun.com>
References: <200810090136.40637.fbrunnerlist@gmx.ch>
	<200811091919.29426.fbrunnerlist@gmx.ch> <491ADCC3.9090001@sun.com>
	<200811130240.27825.fbrunnerlist@gmx.ch>
	<491C15C3.2050404@sun.com> <491C43C3.3050907@gmx.ch>
	<491C6446.9010106@sun.com>
Message-ID: <491C697C.7020506@gmx.ch>

Hi Phil,

that's what I thought, too (and how we worked in the past), but then 
Pavel asked me to commit it myself and I remembered that back in October 
Roman Kennke was able to commit something to 
http://hg.openjdk.java.net/jdk7/swing/jdk

On http://www.openjdk.org/guide/repositories.html I read now that there 
are /gate repositories with read/ write access. Does this mean I could 
commit to http://hg.openjdk.java.net/jdk7/swing-gate/jdk/ ?

Is it possible to work on a clone of  
/http://hg.openjdk.java.net/jdk7/swing/jdk and push the changes to 
/http://hg.openjdk.java.net/jdk7/swing-gate/jdk/ ?

But from 
http://openjdk.java.net/guide/producingChangeset.html#changesetComment 
it's not really clear if I have those rights.

-Florian

/Phil Race schrieb:
> To the best of my knowledge, you won't be able to commit.
> Pavel should act as sponsor and commit the patch on your behalf.
>
> To be able commit to a repo on the OpenJDK site you need to have
> an OpenJDK user id. To get that I think you need to be voted in as
> a member of a project or group. Submitting patches is a step in
> the process towards being considered for election as a member.
>
> Mark: Is this right?
>
> I've trawled around the openjdk site looking for a definite
> statement on how this works, but can't locate one, but I
> think there must be something on this.
>
> Mark: Is there an FAQ on this?
>
> -phil.
>
> Florian Brunner wrote:
>> Hi Pavel,
>>
>> ok, thanks. But do I have the access rights to commit changes to 
>> http://hg.openjdk.java.net/jdk7/swing/jdk ? Is it open for everybody? 
>> How do you ensure, that only reviewed stuff gets into the jdk?
>>
>> You said you filed a new bug for the change (6771030), but I cannot 
>> find it at
>> http://bugs.sun.com/bugdatabase/
>>
>> Also note that all my patches so far were related to issue 6179357.
>>
>> -Florian
>>
>> Pavel Porvatov schrieb:
>>> Hi Florian,
>>>
>>> I approved your fix and now you can commit it. Don't forget write 
>>> appropriate changeset comment (see 
>>> http://openjdk.java.net/guide/producingChangeset.html#changesetComment). 
>>>
>>>
>>> I filed a bug for your change:
>>> <bugid>: 6771030
>>> <synopsis-of-symptom>: Code improvement and warnings removing from 
>>> the com.sun.java.swing.plaf.gtk package
>>>
>>> Let me know if you have any question.
>>>
>>> Thanks, Pavel.
>>>
>>>> Hi Pavel,
>>>>
>>>> I fixed the 2 issues.
>>>>
>>>> -Florian
>>>>
>>>> Am Mittwoch, 12. November 2008 schrieb Pavel Porvatov:
>>>>> Hi Florian,
>>>>>
>>>>> Your fix looks very good. I have a couple comments:
>>>>>
>>>>> 1.
>>>>> com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLo 
>>>>>
>>>>> cationToRGB - can you fix javadoc please (this is a private 
>>>>> method). The
>>>>> last
>>>>> "param" tag should be replaced by "return" tag
>>>>>
>>>>> 2.
>>>>> @@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile
>>>>>
>>>>>       private class GTKDirectoryModel extends BasicDirectoryModel {
>>>>>           FileSystemView fsv;
>>>>> -        private Comparator fileComparator = new Comparator() {
>>>>> -            public int compare(Object o, Object o1) {
>>>>> -                return fsv.getSystemDisplayName((File) o).compareTo
>>>>> -                      (fsv.getSystemDisplayName((File) o1));
>>>>> +        private Comparator<File> fileComparator = new 
>>>>> Comparator<File>() {
>>>>> +            public int compare(File o, File o1) {
>>>>> +                return fsv.getSystemDisplayName(o).compareTo
>>>>> +                      (fsv.getSystemDisplayName(o1));
>>>>>               }
>>>>>           };
>>>>>
>>>>> Can you make return statement in a single line please
>>>>>
>>>>>
>>>>> Regards, Pavel.
>>>>>
>>>>>> Hi Pavel,
>>>>>>
>>>>>> any news about my patch?
>>>>>>
>>>>>> Thanks.
>>>>>> -Florian
>>>>>>
>>>>>> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>>>>>>> Hi Florian,
>>>>>>>
>>>>>>> Thanks for your patch. I'll review your patch in two-three weeks 
>>>>>>> and
>>>>>>> mail you response.
>>>>>>>
>>>>>>> Thanks, Pavel.
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> here another patch to remove warnings in the gtk package.
>>>>>>>>
>>>>>>>> When compiling with
>>>>>>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>>>>>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>>>>>>> this patch reduces the number of reported warnings from 201 to 
>>>>>>>> 112.
>>>>>>>>
>>>>>>>> Again, I tried only to change things related to the warnings 
>>>>>>>> and not to
>>>>>>>> change any public or protected APIs in public or protected 
>>>>>>>> classes in
>>>>>>>> this patch.
>>>>>>>>
>>>>>>>> At many places I tried to add type parameters as meaningful as
>>>>>>>> possible, but with some cases I just used Object, if a more 
>>>>>>>> meaningful
>>>>>>>> type parameter was not so trivial. You might want to refactor 
>>>>>>>> this if
>>>>>>>> needed. (Though everything should work as it is.)
>>>>>>>>
>>>>>>>> -Florian
>>>>
>>>>
>>>
>>
>



From mr at sun.com  Thu Nov 13 18:14:53 2008
From: mr at sun.com (Mark Reinhold)
Date: Thu, 13 Nov 2008 10:14:53 -0800
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: phil.race@sun.com; Thu, 13 Nov 2008 09:30:46 PST;
	<491C6446.9010106@sun.com> 
Message-ID: <20081113181453.578C828CFE2@eggemoggin.niobe.net>

> Date: Thu, 13 Nov 2008 09:30:46 -0800
> From: phil.race at sun.com

> To the best of my knowledge, you won't be able to commit.
> Pavel should act as sponsor and commit the patch on your behalf.

Right.

> To be able commit to a repo on the OpenJDK site you need to have
> an OpenJDK user id. To get that I think you need to be voted in as
> a member of a project or group. Submitting patches is a step in
> the process towards being considered for election as a member.
> 
> Mark: Is this right?

Yes, roughly speaking.

> I've trawled around the openjdk site looking for a definite
> statement on how this works, but can't locate one, but I
> think there must be something on this.
> 
> Mark: Is there an FAQ on this?

No, but the membership-voting process is described here:

    http://openjdk.java.net/groups/#Member

- Mark


From Pavel.Porvatov at Sun.COM  Fri Nov 14 15:52:44 2008
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Fri, 14 Nov 2008 18:52:44 +0300
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <20081113181453.578C828CFE2@eggemoggin.niobe.net>
References: <20081113181453.578C828CFE2@eggemoggin.niobe.net>
Message-ID: <491D9ECC.2000400@sun.com>

Hi Florian,

I thought you had user id. I'll commit your fix in near future.

Regards, Pavel.

>> Date: Thu, 13 Nov 2008 09:30:46 -0800
>> From: phil.race at sun.com
> 
>> To the best of my knowledge, you won't be able to commit.
>> Pavel should act as sponsor and commit the patch on your behalf.
> 
> Right.
> 
>> To be able commit to a repo on the OpenJDK site you need to have
>> an OpenJDK user id. To get that I think you need to be voted in as
>> a member of a project or group. Submitting patches is a step in
>> the process towards being considered for election as a member.
>>
>> Mark: Is this right?
> 
> Yes, roughly speaking.
> 
>> I've trawled around the openjdk site looking for a definite
>> statement on how this works, but can't locate one, but I
>> think there must be something on this.
>>
>> Mark: Is there an FAQ on this?
> 
> No, but the membership-voting process is described here:
> 
>     http://openjdk.java.net/groups/#Member
> 
> - Mark



From pavel.porvatov at sun.com  Mon Nov 17 14:47:46 2008
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Mon, 17 Nov 2008 14:47:46 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6771030: Code improvement and
	warnings removing	from the com.sun.java.swing.plaf.gtk package
Message-ID: <20081117144804.ACE11D569@hg.openjdk.java.net>

Changeset: f8461a705330
Author:    rupashka
Date:      2008-11-17 17:36 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f8461a705330

6771030: Code improvement and warnings removing from the com.sun.java.swing.plaf.gtk package
Summary: Removed unnecessary castings and other warnings
Reviewed-by: malenkov

! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java
! src/share/classes/com/sun/java/swing/plaf/gtk/GTKEngine.java
! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java
! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java
! src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java



From Pavel.Porvatov at Sun.COM  Mon Nov 17 14:51:33 2008
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Mon, 17 Nov 2008 17:51:33 +0300
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <491C43C3.3050907@gmx.ch>
References: <200810090136.40637.fbrunnerlist@gmx.ch>
	<200811091919.29426.fbrunnerlist@gmx.ch> <491ADCC3.9090001@sun.com>
	<200811130240.27825.fbrunnerlist@gmx.ch> <491C15C3.2050404@sun.com>
	<491C43C3.3050907@gmx.ch>
Message-ID: <492184F5.4010008@sun.com>

Hi Florian,

Your fix was committed.
See http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f8461a705330

Thanks, Pavel.

> Hi Pavel,
> 
> ok, thanks. But do I have the access rights to commit changes to 
> http://hg.openjdk.java.net/jdk7/swing/jdk ? Is it open for everybody? 
> How do you ensure, that only reviewed stuff gets into the jdk?
> 
> You said you filed a new bug for the change (6771030), but I cannot find 
> it at
> http://bugs.sun.com/bugdatabase/
> 
> Also note that all my patches so far were related to issue 6179357.
> 
> -Florian
> 
> Pavel Porvatov schrieb:
>> Hi Florian,
>>
>> I approved your fix and now you can commit it. Don't forget write 
>> appropriate changeset comment (see 
>> http://openjdk.java.net/guide/producingChangeset.html#changesetComment).
>>
>> I filed a bug for your change:
>> <bugid>: 6771030
>> <synopsis-of-symptom>: Code improvement and warnings removing from the 
>> com.sun.java.swing.plaf.gtk package
>>
>> Let me know if you have any question.
>>
>> Thanks, Pavel.
>>
>>> Hi Pavel,
>>>
>>> I fixed the 2 issues.
>>>
>>> -Florian
>>>
>>> Am Mittwoch, 12. November 2008 schrieb Pavel Porvatov:
>>>> Hi Florian,
>>>>
>>>> Your fix looks very good. I have a couple comments:
>>>>
>>>> 1.
>>>> com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLo 
>>>>
>>>> cationToRGB - can you fix javadoc please (this is a private method). 
>>>> The
>>>> last
>>>> "param" tag should be replaced by "return" tag
>>>>
>>>> 2.
>>>> @@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile
>>>>
>>>>       private class GTKDirectoryModel extends BasicDirectoryModel {
>>>>           FileSystemView fsv;
>>>> -        private Comparator fileComparator = new Comparator() {
>>>> -            public int compare(Object o, Object o1) {
>>>> -                return fsv.getSystemDisplayName((File) o).compareTo
>>>> -                      (fsv.getSystemDisplayName((File) o1));
>>>> +        private Comparator<File> fileComparator = new 
>>>> Comparator<File>() {
>>>> +            public int compare(File o, File o1) {
>>>> +                return fsv.getSystemDisplayName(o).compareTo
>>>> +                      (fsv.getSystemDisplayName(o1));
>>>>               }
>>>>           };
>>>>
>>>> Can you make return statement in a single line please
>>>>
>>>>
>>>> Regards, Pavel.
>>>>
>>>>> Hi Pavel,
>>>>>
>>>>> any news about my patch?
>>>>>
>>>>> Thanks.
>>>>> -Florian
>>>>>
>>>>> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>>>>>> Hi Florian,
>>>>>>
>>>>>> Thanks for your patch. I'll review your patch in two-three weeks and
>>>>>> mail you response.
>>>>>>
>>>>>> Thanks, Pavel.
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> here another patch to remove warnings in the gtk package.
>>>>>>>
>>>>>>> When compiling with
>>>>>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>>>>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>>>>>> this patch reduces the number of reported warnings from 201 to 112.
>>>>>>>
>>>>>>> Again, I tried only to change things related to the warnings and 
>>>>>>> not to
>>>>>>> change any public or protected APIs in public or protected 
>>>>>>> classes in
>>>>>>> this patch.
>>>>>>>
>>>>>>> At many places I tried to add type parameters as meaningful as
>>>>>>> possible, but with some cases I just used Object, if a more 
>>>>>>> meaningful
>>>>>>> type parameter was not so trivial. You might want to refactor 
>>>>>>> this if
>>>>>>> needed. (Though everything should work as it is.)
>>>>>>>
>>>>>>> -Florian
>>>
>>>
>>
> 



From fbrunnerlist at gmx.ch  Mon Nov 17 15:15:04 2008
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Mon, 17 Nov 2008 16:15:04 +0100
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal: gtk
In-Reply-To: <492184F5.4010008@sun.com>
References: <200810090136.40637.fbrunnerlist@gmx.ch>
	<200811091919.29426.fbrunnerlist@gmx.ch> <491ADCC3.9090001@sun.com>
	<200811130240.27825.fbrunnerlist@gmx.ch>
	<491C15C3.2050404@sun.com> <491C43C3.3050907@gmx.ch>
	<492184F5.4010008@sun.com>
Message-ID: <49218A78.4070400@gmx.ch>

Hi Pavel,

thanks, I will now start with the next warning removal patch. This will 
then probably be the last warning removal patch before I start with the 
actual task: enhance the Swing classes with generics.

-Florian

Pavel Porvatov schrieb:
> Hi Florian,
>
> Your fix was committed.
> See http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f8461a705330
>
> Thanks, Pavel.
>
>> Hi Pavel,
>>
>> ok, thanks. But do I have the access rights to commit changes to 
>> http://hg.openjdk.java.net/jdk7/swing/jdk ? Is it open for everybody? 
>> How do you ensure, that only reviewed stuff gets into the jdk?
>>
>> You said you filed a new bug for the change (6771030), but I cannot 
>> find it at
>> http://bugs.sun.com/bugdatabase/
>>
>> Also note that all my patches so far were related to issue 6179357.
>>
>> -Florian
>>
>> Pavel Porvatov schrieb:
>>> Hi Florian,
>>>
>>> I approved your fix and now you can commit it. Don't forget write 
>>> appropriate changeset comment (see 
>>> http://openjdk.java.net/guide/producingChangeset.html#changesetComment). 
>>>
>>>
>>> I filed a bug for your change:
>>> <bugid>: 6771030
>>> <synopsis-of-symptom>: Code improvement and warnings removing from 
>>> the com.sun.java.swing.plaf.gtk package
>>>
>>> Let me know if you have any question.
>>>
>>> Thanks, Pavel.
>>>
>>>> Hi Pavel,
>>>>
>>>> I fixed the 2 issues.
>>>>
>>>> -Florian
>>>>
>>>> Am Mittwoch, 12. November 2008 schrieb Pavel Porvatov:
>>>>> Hi Florian,
>>>>>
>>>>> Your fix looks very good. I have a couple comments:
>>>>>
>>>>> 1.
>>>>> com.sun.java.swing.plaf.gtk.GTKColorChooserPanel.ColorTriangle#colorWheelLo 
>>>>>
>>>>> cationToRGB - can you fix javadoc please (this is a private 
>>>>> method). The
>>>>> last
>>>>> "param" tag should be replaced by "return" tag
>>>>>
>>>>> 2.
>>>>> @@ -895,10 +895,10 @@ class GTKFileChooserUI extends SynthFile
>>>>>
>>>>>       private class GTKDirectoryModel extends BasicDirectoryModel {
>>>>>           FileSystemView fsv;
>>>>> -        private Comparator fileComparator = new Comparator() {
>>>>> -            public int compare(Object o, Object o1) {
>>>>> -                return fsv.getSystemDisplayName((File) o).compareTo
>>>>> -                      (fsv.getSystemDisplayName((File) o1));
>>>>> +        private Comparator<File> fileComparator = new 
>>>>> Comparator<File>() {
>>>>> +            public int compare(File o, File o1) {
>>>>> +                return fsv.getSystemDisplayName(o).compareTo
>>>>> +                      (fsv.getSystemDisplayName(o1));
>>>>>               }
>>>>>           };
>>>>>
>>>>> Can you make return statement in a single line please
>>>>>
>>>>>
>>>>> Regards, Pavel.
>>>>>
>>>>>> Hi Pavel,
>>>>>>
>>>>>> any news about my patch?
>>>>>>
>>>>>> Thanks.
>>>>>> -Florian
>>>>>>
>>>>>> Am Freitag, 10. Oktober 2008 schrieb Pavel Porvatov:
>>>>>>> Hi Florian,
>>>>>>>
>>>>>>> Thanks for your patch. I'll review your patch in two-three weeks 
>>>>>>> and
>>>>>>> mail you response.
>>>>>>>
>>>>>>> Thanks, Pavel.
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> here another patch to remove warnings in the gtk package.
>>>>>>>>
>>>>>>>> When compiling with
>>>>>>>> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation
>>>>>>>> -Xlint:-fallthrough -Xmaxwarns 2300
>>>>>>>> this patch reduces the number of reported warnings from 201 to 
>>>>>>>> 112.
>>>>>>>>
>>>>>>>> Again, I tried only to change things related to the warnings 
>>>>>>>> and not to
>>>>>>>> change any public or protected APIs in public or protected 
>>>>>>>> classes in
>>>>>>>> this patch.
>>>>>>>>
>>>>>>>> At many places I tried to add type parameters as meaningful as
>>>>>>>> possible, but with some cases I just used Object, if a more 
>>>>>>>> meaningful
>>>>>>>> type parameter was not so trivial. You might want to refactor 
>>>>>>>> this if
>>>>>>>> needed. (Though everything should work as it is.)
>>>>>>>>
>>>>>>>> -Florian
>>>>
>>>>
>>>
>>
>



From yuka.kamiya at sun.com  Tue Nov 18 05:26:32 2008
From: yuka.kamiya at sun.com (yuka.kamiya at sun.com)
Date: Tue, 18 Nov 2008 05:26:32 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6769873: Regression
	test	java/text/Date/DateFormat/Bug6683975.java started
	failing after	DST ended.
Message-ID: <20081118052654.1F4EED58C@hg.openjdk.java.net>

Changeset: 6c5781fc3818
Author:    peytoia
Date:      2008-11-18 13:58 +0900
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/6c5781fc3818

6769873: Regression test  java/text/Date/DateFormat/Bug6683975.java started failing after DST ended.
Reviewed-by: okutsu

! test/java/text/Format/DateFormat/Bug6683975.java



From yuka.kamiya at sun.com  Tue Nov 18 07:23:36 2008
From: yuka.kamiya at sun.com (yuka.kamiya at sun.com)
Date: Tue, 18 Nov 2008 07:23:36 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6772646: Regression
	test	java/text/Date/DateFormat/Bug4823811.java started
	failing after	DST ended.
Message-ID: <20081118072356.F00BAD5D7@hg.openjdk.java.net>

Changeset: bdfe33408ed8
Author:    peytoia
Date:      2008-11-18 15:59 +0900
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/bdfe33408ed8

6772646: Regression test  java/text/Date/DateFormat/Bug4823811.java started failing after DST ended.
Reviewed-by: okutsu

! test/java/text/Format/DateFormat/Bug4823811.java



From fbrunnerlist at gmx.ch  Thu Nov 20 00:34:42 2008
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Thu, 20 Nov 2008 01:34:42 +0100
Subject: <Swing Dev>  [PATCH] 6179357-related: warnings removal
Message-ID: <200811200134.42744.fbrunnerlist@gmx.ch>

Hi,

here another patch to remove warnings in the Swing classes.

When compiling with
-Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation -Xlint:-fallthrough -Xmaxwarns 
2300
this patch reduces the number of reported warnings from 112 to 95.

Again, I tried only to change things related to the warnings and not to change 
any public or protected APIs in public or protected classes in this patch.

At many places I tried to add type parameters as meaningful as possible, 
but with some cases I just used Object, if a more meaningful type 
parameter was not so trivial. You might want to refactor this if needed. 
(Though everything should work as it is.)

In this past year we could reduce the number of reported warnings from ca. 
1277 to 95 when compiling with
-Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation -Xlint:-fallthrough -Xmaxwarns 
2300

When this patch will be commited, I will finally start working on the actual 
task: adding generics to the Swing-framework. With 'only' 95 warnings left, 
it should be much easier now to see if I introduce new warnings while working 
on this task (especially unchecked and cast warnings). 

-Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: swing-patch-20081120-warnings.patch
Type: text/x-diff
Size: 10013 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20081120/de9c55f2/swing-patch-20081120-warnings.patch>

From pavel.porvatov at sun.com  Tue Nov 25 13:51:29 2008
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Tue, 25 Nov 2008 13:51:29 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6698013: JFileChooser can no longer
	navigate	non-local file systems.
Message-ID: <20081125135143.9183CDBF8@hg.openjdk.java.net>

Changeset: 63e684c4ed2f
Author:    rupashka
Date:      2008-11-25 16:42 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/63e684c4ed2f

6698013: JFileChooser can no longer navigate non-local file systems.
Summary: ShellFolder is used only if possible
Reviewed-by: peterz

! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
! src/share/classes/sun/swing/FilePane.java
+ test/javax/swing/JFileChooser/6698013/bug6698013.html
+ test/javax/swing/JFileChooser/6698013/bug6698013.java



From pavel.porvatov at sun.com  Wed Nov 26 16:16:53 2008
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Wed, 26 Nov 2008 16:16:53 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6560349: REGRESSION :folder having
	".lnk" in the	name can not be opened by 5.0 and later versions
Message-ID: <20081126161711.EDD32DC8D@hg.openjdk.java.net>

Changeset: be2b6b030a79
Author:    rupashka
Date:      2008-11-26 19:08 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/be2b6b030a79

6560349: REGRESSION :folder having ".lnk" in the name can not be opened by 5.0 and later versions
Reviewed-by: alexp

! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java



From pavel.porvatov at sun.com  Wed Nov 26 16:47:02 2008
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Wed, 26 Nov 2008 16:47:02 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6776856: Code with useShellFolder
	field shuold be	simplify
Message-ID: <20081126164714.25F96DC93@hg.openjdk.java.net>

Changeset: 8b842701af50
Author:    rupashka
Date:      2008-11-26 19:38 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/8b842701af50

6776856: Code with useShellFolder field shuold be simplify
Reviewed-by: peterz

! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java
! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java
! src/share/classes/sun/swing/FilePane.java
! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java



From pavel.porvatov at sun.com  Thu Nov 27 15:04:00 2008
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Thu, 27 Nov 2008 15:04:00 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6776095: Code improvement and
	warnings removing	from swing packages
Message-ID: <20081127150414.505CEDDA8@hg.openjdk.java.net>

Changeset: 5784f5dfe3ac
Author:    rupashka
Date:      2008-11-27 17:55 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5784f5dfe3ac

6776095: Code improvement and warnings removing from swing packages
Reviewed-by: malenkov
Contributed-by: Florian Brunner <fbrunnerlist at gmx.ch>

! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java
! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java
! src/share/classes/javax/swing/ImageIcon.java
! src/share/classes/javax/swing/ProgressMonitor.java
! src/share/classes/javax/swing/SwingWorker.java
! src/share/classes/javax/swing/colorchooser/DefaultColorSelectionModel.java
! src/share/classes/javax/swing/table/DefaultTableColumnModel.java
! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java
! src/share/classes/javax/swing/undo/CompoundEdit.java



From Pavel.Porvatov at Sun.COM  Thu Nov 27 15:06:41 2008
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Thu, 27 Nov 2008 18:06:41 +0300
Subject: <Swing Dev> [PATCH] 6179357-related: warnings removal
In-Reply-To: <200811200134.42744.fbrunnerlist@gmx.ch>
References: <200811200134.42744.fbrunnerlist@gmx.ch>
Message-ID: <492EB781.6090305@sun.com>

Hi Florian,

I've committed your fix in jdk7. It's available here:
http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5784f5dfe3ac

Thank you for your hard work!

Regards, Pavel.

> Hi,
> 
> here another patch to remove warnings in the Swing classes.
> 
> When compiling with
> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation -Xlint:-fallthrough -Xmaxwarns 
> 2300
> this patch reduces the number of reported warnings from 112 to 95.
> 
> Again, I tried only to change things related to the warnings and not to change 
> any public or protected APIs in public or protected classes in this patch.
> 
> At many places I tried to add type parameters as meaningful as possible, 
> but with some cases I just used Object, if a more meaningful type 
> parameter was not so trivial. You might want to refactor this if needed. 
> (Though everything should work as it is.)
> 
> In this past year we could reduce the number of reported warnings from ca. 
> 1277 to 95 when compiling with
> -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation -Xlint:-fallthrough -Xmaxwarns 
> 2300
> 
> When this patch will be commited, I will finally start working on the actual 
> task: adding generics to the Swing-framework. With 'only' 95 warnings left, 
> it should be much easier now to see if I introduce new warnings while working 
> on this task (especially unchecked and cast warnings). 
> 
> -Florian
>