<Swing Dev> [PATCH] Make RepaintManager more portable

Roman Kennke roman.kennke at aicas.com
Wed Oct 15 14:09:30 UTC 2008


Hi Alexander,

> >> The fix looks good,
> >> I see no reasons why not to push it to openJDK 6
> > 
> > Thanks. I suppose you mean JDK7?
> 
> I thought external contributors can only push fixes
> to openJDK 6, having it in JDK 7 is fine also

There's not even a public JDK6 repository. And it doesn't make a lot of
sense to let external contributors push into a stable branch, but not in
development branch ;-)

> >> I filed an RFE
> >> #6759311 RepaintManager casts Tookit to SunToolkit without instanceof check
> >>
> >> It usually requires a couple of days for CR to appear in the public database
> >>
> >> If you would like to push to the workspace yourself,
> >> you are welcome
> > 
> > I can do that, thanks :-) I propose the following Changeset comment:
> > 
> > 6759311: RepaintManager casts Tookit to SunToolkit without instanceof
> > check
> > Summary: Check type of Toolkit before casting.
> > Reviewed-by: alexp
> > 
> > If this is ok, then I'll push it to the gate ASAP.
> 
> It's ok
> I approve

Done. Thanks.

/Roman
-- 
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-48
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt




More information about the swing-dev mailing list