<Swing Dev> Review request #3: 6852592 (revalidate() must be smarter)

[Christopher Deckers]

Anthony,

I think I disagree with Applet returning true to isValidateRoot. If I
am not mistaken, I think I saw some people placing an applet in their
component hierarchy as if it was a normal component. Invalidation
should propagate so that outer components can revalidate and thus have
proper layout calculations. Thus I think the only AWT components that
should return true are the ones with an outer parent (window class
hierarchy).

For the window method, shouldn't it be marked as final?

And what about the AWT ScrollPane? Shouldn't it return true as well?

Hope this helps,
-Christopher


On Thu, Jul 23, 2009 at 1:57 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> Hello Swing and AWT teams,
>
> So here's the latest version of the fix:
>
> http://cr.openjdk.java.net/~anthony/7-23-invalidate-6852592.2/
>
> The specification has been modified, some stuff has been moved around.
> Currently the spec is being reviewed by the CCC at Sun, and therefore is
> kind of frozen. However, if anyone happen to find major problems with the
> javadoc, please feel free to speak up.
>
> Suggestions for the code changes are still very welcome. Thank you in
> advance!
>
> --
> best regards,
> Anthony
>