<Swing Dev> Request for review: Bug 100054: Make building the Nimbus look 'n' feel optional

[Andrew John Hughes]

2009/5/14 Phil Race <Phil.Race at sun.com>:
> There's public API associated with Nimbus in javax.swing.plaf.nimbus
> so I don't think many people will want to use that facility and it doesn't
> seem appropriate to have it in the jdk7 source train.
>
> -phil.
>
>
> Andrew John Hughes wrote:
>>
>> HI all,
>>
>> I have a simple patch that allows the building of the Nimbus L'n'F
>> (which has a dependency on a specific version of JIBX, 1.1.5) to be
>> turned off so the user can trade build simplicity for a lack of Nimbus
>> support and curved buttons in Swing.
>>
>> The bug report is here:
>> https://bugs.openjdk.java.net/show_bug.cgi?id=100054
>>
>> And the webrev is here: http://fuseyism.com/100054/webrev.00/ (still
>> having some issues getting access to cr.openjdk.java.net)
>>
>> Thanks,
>

In my experience, it's usually a bad idea to pre-judge what people want.

I created and posted this patch because a number of us working on
OpenJDK have already had issues trying to build with this enabled.
I'm not suggesting by any means that you'd want this enabled in a
production build.  But it helps reduce the build requirements of
completing an OpenJDK build and, to my mind, allowing more people to
build OpenJDK allows more people to make worthwhile contributions.

I've already added this to IcedTea for this reason and I don't see
what harm it does to have the option available upstream.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8