<Swing Dev> Request for review: Bug 100054: Make building the Nimbus look 'n' feel optional

[Andrew John Hughes]

2009/5/21 Mark Reinhold <mr at sun.com>:
>> Date: Mon, 18 May 2009 19:17:21 +0100
>> From: Andrew John Hughes <gnu_andrew at member.fsf.org>
>
>> Ok, new webrev created against jdk7/build:
>>
>> http://fuseyism.com/6841728/webrev.01/
>
> Looks good to me -- go ahead and push when ready.
>

Pushed: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c06d30bd8c69

>> I presume I need to wait a bit due to the current block on pushes though.
>
> No, the group integration areas are already open for M4.
>
>>>> Is the standard format for such messages documented somewhere?
>>>
>>> http://openjdk.java.net/guide/producingChangeset.html#changesetComment
>>
>> Thanks.  I'd forgotten about the developer guide.  It was been
>> discussed for a while, but then things seemed to go quiet.  Is it now
>> complete?
>
> No, unfortunately no one's had time to work on it, except for minor
> changes, since the first version.  What's there is still relatively
> accurate.
>

Looks like the Contributed-by info is wrong.  I tried adding the line
as in the example and jcheck choked:

remote: > Contributed-by: Andrew John Hughes <ahughes at redhat.com>
remote:
remote: Invalid contributor attribution
remote:
remote: abort: pretxnchangegroup.0.jcheck hook failed

The example is Contributed-by: Ben Bitdiddle <ben at bits.org>

> - Mark
>

Thanks,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8