<Swing Dev> [PATCH] 6179357: Generics: JList

[Florian Brunner]

Great news, thanks!

I'll write soon to plan the next steps.

-Florian

Am Montag, 23. November 2009 schrieb Alexander Potochkin:
> Wow!
> Congratulations Pavel & Florian!
>
> Thanks
> alexp
>
> > Hi Florian,
> >
> > I've got an approve for the fix and committed it:
> > http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7bcb1864f424
> >
> > Thanks for your work,
> > Pavel
> >
> >> Ok, thanks
> >>
> >> -Florian
> >>
> >> Alexander Potochkin schrieb:
> >>> Hello Florian
> >>>
> >>>> Hi Pavel,
> >>>>
> >>>> Hmm, do you know where the problem lies? I understand that changes
> >>>> to the public API need thorough reviews, but it's already months. It
> >>>> would be great if we could continue with the work.
> >>>
> >>> I'll try to speed up the process
> >>>
> >>> We'll let you know about the results soon
> >>>
> >>> Thanks
> >>> alexp
> >>>
> >>>> -Florian
> >>>>
> >>>> Pavel Porvatov schrieb:
> >>>>> Hi Florian,
> >>>>>
> >>>>>> Hi Pavel,
> >>>>>>
> >>>>>> just my monthly status request: any news?
> >>>>>
> >>>>> Unfortunately I don't have any news about the bug.
> >>>>>
> >>>>> Regards, Pavel
> >>>>>
> >>>>>> -Florian
> >>>>>>
> >>>>>> Am Montag, 28. September 2009 schrieb Pavel Porvatov:
> >>>>>>> Hi Florian,
> >>>>>>>
> >>>>>>>> Hi Pavel,
> >>>>>>>>
> >>>>>>>> did you have time to look at the patch already? What's the status?
> >>>>>>>
> >>>>>>> Yes, I combined your tests into one and it works. Unfortunately
> >>>>>>> the fix
> >>>>>>> will be delayed because internal approve of the fix is not
> >>>>>>> finished yet
> >>>>>>> (I was wrong when I wrote about approve completion, sorry)...
> >>>>>>> I'll let
> >>>>>>> you know when I commit your fix.
> >>>>>>>
> >>>>>>> Regards, Pavel
> >>>>>>>
> >>>>>>>> -Florian
> >>>>>>>>
> >>>>>>>> Am Montag, 14. September 2009 schrieb Pavel Porvatov:
> >>>>>>>>> Hi Florian,
> >>>>>>>>>
> >>>>>>>>> Thanks! I will continue work with your fix tomorrow.
> >>>>>>>>>
> >>>>>>>>>> Hi Pavel,
> >>>>>>>>>>
> >>>>>>>>>> here are some jtreg tests, which test the signatures of the
> >>>>>>>>>> changed API
> >>>>>>>>>> (raw & generic calls).
> >>>>>>>>>>
> >>>>>>>>>> Note that, of course, the generic tests won't even compile
> >>>>>>>>>> before the
> >>>>>>>>>> generic JList patch is applied. So, if you care, you could:
> >>>>>>>>>> - remove the generic tests (should be simple)
> >>>>>>>>>> - run the test with the unpatched version
> >>>>>>>>>> - check them in
> >>>>>>>>>> - upgrade the test along with the JList patch
> >>>>>>>>>> - run them again
> >>>>>>>>>> - check them both in
> >>>>>>>>>>
> >>>>>>>>>> Please also  check the license header and the test annotations.
> >>>>>>>>>
> >>>>>>>>> Ok, I'll do it.
> >>>>>>>>>
> >>>>>>>>> Regards, Pavel.
> >>>>>>>>>
> >>>>>>>>>> -Florian
> >>>>>>>>>>
> >>>>>>>>>> Am Donnerstag, 3. September 2009 schrieb Florian Brunner:
> >>>>>>>>>>> Hi Pavel,
> >>>>>>>>>>>
> >>>>>>>>>>> great news! :-)
> >>>>>>>>>>>
> >>>>>>>>>>> I will have a look at jtreg.
> >>>>>>>>>>>
> >>>>>>>>>>> -Florian
> >>>>>>>>>>>
> >>>>>>>>>>> Pavel Porvatov schrieb:
> >>>>>>>>>>>> Hi Florian,
> >>>>>>>>>>>>
> >>>>>>>>>>>>> any news about my patch? What is the status? I understand
> >>>>>>>>>>>>> that approving of the API is not a quick step, but then it's
> >>>>>>>>>>>>> already 2-3
> >>>>>>>>>>>>> months. And we need to do the same for all the other planed
> >>>>>>>>>>>>> API-
> >>>>>>>>>>>>> changes to "generify" Swing. It would be great if we could
> >>>>>>>>>>>>> speed
> >>>>>>>>>>>>> things up a bit again.
> >>>>>>>>>>>>
> >>>>>>>>>>>> The good news: the patch was approved on last Friday! So I
> >>>>>>>>>>>> can push
> >>>>>>>>>>>> it. But many people asked about regression tests. Could you
> >>>>>>>>>>>> please
> >>>>>>>>>>>> write such automatic tests for the fix. E.g.
> >>>>>>>>>>>>
> >>>>>>>>>>>> -----
> >>>>>>>>>>>>         String[] strings = new String[] {"A string"};
> >>>>>>>>>>>>
> >>>>>>>>>>>>         new JList(strings);
> >>>>>>>>>>>>
> >>>>>>>>>>>>         Vector v1 = new Vector();
> >>>>>>>>>>>>
> >>>>>>>>>>>>         new JList(v1);
> >>>>>>>>>>>>
> >>>>>>>>>>>>         Vector<String> v2 = new Vector<String>();
> >>>>>>>>>>>>
> >>>>>>>>>>>>         new JList(v2);
> >>>>>>>>>>>> -----
> >>>>>>>>>>>> etc.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Here you can find some info about test framework:
> >>>>>>>>>>>> http://openjdk.java.net/jtreg/
> >>>>>>>>>>>>
> >>>>>>>>>>>> Thanks, Pavel.
> >>>>>>>>>>>>
> >>>>>>>>>>>>> What do you estimate, how much more time this step takes?
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Thanks.
> >>>>>>>>>>>>> -Florian
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Am Mittwoch, 22. Juli 2009 schrieben Sie:
> >>>>>>>>>>>>>> Hi Florian,
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Hi Pavel,
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> I hope you had nice holidays.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Do you have any news about the patch?
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> I'm awaiting approve of API changes. It's not a very quick
> >>>>>>>>>>>>>> step
> >>>>>>>>>>>>>> because a lot of people should take a look at your changes
> >>>>>>>>>>>>>> and give
> >>>>>>>>>>>>>> approve for it...
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Regards, Pavel
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> -Florian
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Am Freitag, 19. Juni 2009 schrieb Florian Brunner:
> >>>>>>>>>>>>>>>> Hi Pavel,
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> enjoy your holidays! My holidays start from 27th June
> >>>>>>>>>>>>>>>> till 8th
> >>>>>>>>>>>>>>>> July, so
> >>>>>>>>>>>>>>>> we can continue the work on generics afterwards again.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> -Florian
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Am Donnerstag, 11. Juni 2009 schrieb Pavel Porvatov: