<Swing Dev> [PATCH] 6179357: Generics: JList

[Florian Brunner]

Hi Pavel,

here are some jtreg tests, which test the signatures of the changed API (raw & generic calls).

Note that, of course, the generic tests won't even compile before the generic JList patch is 
applied. So, if you care, you could: 
- remove the generic tests (should be simple)
- run the test with the unpatched version
- check them in
- upgrade the test along with the JList patch
- run them again
- check them both in

Please also  check the license header and the test annotations.

-Florian

Am Donnerstag, 3. September 2009 schrieb Florian Brunner:
> Hi Pavel,
>
> great news! :-)
>
> I will have a look at jtreg.
>
> -Florian
>
> Pavel Porvatov schrieb:
> > Hi Florian,
> >
> >> any news about my patch? What is the status? I understand that
> >> approving of the API is not a quick step, but then it's already 2-3
> >> months. And we need to do the same for all the other planed API-
> >> changes to "generify" Swing. It would be great if we could speed
> >> things up a bit again.
> >
> > The good news: the patch was approved on last Friday! So I can push
> > it. But many people asked about regression tests. Could you please
> > write such automatic tests for the fix. E.g.
> >
> > -----
> >         String[] strings = new String[] {"A string"};
> >
> >         new JList(strings);
> >
> >         Vector v1 = new Vector();
> >
> >         new JList(v1);
> >
> >         Vector<String> v2 = new Vector<String>();
> >
> >         new JList(v2);
> > -----
> > etc.
> >
> > Here you can find some info about test framework:
> > http://openjdk.java.net/jtreg/
> >
> > Thanks, Pavel.
> >
> >> What do you estimate, how much more time this step takes?
> >>
> >> Thanks.
> >> -Florian
> >>
> >> Am Mittwoch, 22. Juli 2009 schrieben Sie:
> >>> Hi Florian,
> >>>
> >>>> Hi Pavel,
> >>>>
> >>>> I hope you had nice holidays.
> >>>>
> >>>> Do you have any news about the patch?
> >>>
> >>> I'm awaiting approve of API changes. It's not a very quick step because
> >>> a lot of people should take a look at your changes and give approve for
> >>> it...
> >>>
> >>> Regards, Pavel
> >>>
> >>>> -Florian
> >>>>
> >>>> Am Freitag, 19. Juni 2009 schrieb Florian Brunner:
> >>>>> Hi Pavel,
> >>>>>
> >>>>> enjoy your holidays! My holidays start from 27th June till 8th
> >>>>> July, so
> >>>>> we can continue the work on generics afterwards again.
> >>>>>
> >>>>> -Florian
> >>>>>
> >>>>> Am Donnerstag, 11. Juni 2009 schrieb Pavel Porvatov:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: swing-patch-generics-jlist-jtreg-20090912.patch
Type: text/x-patch
Size: 20067 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20090912/039ce65c/swing-patch-generics-jlist-jtreg-20090912.patch>