<Swing Dev> [PATCH] 100153: Generics: JComboBox

Pavel Porvatov pavel.porvatov at oracle.com
Thu Nov 18 17:14:15 UTC 2010


Hi Florian,

I'm investigating your fix and I have found several questionable thing 
(will send them when the review of the patch will be done). The main 
disturbing thing is the way of generification of the 
get/setSelectedItem(Object) methods in the JComboBox class (see 
http://mail.openjdk.java.net/pipermail/swing-dev/2010-June/001100.html). 
So we will discuss that soon...

Regards, Pavel
> Hi Pavel,
>
> what is the status of my patch? Did you have time to take a look at it?
>
> Regards,
> Florian
>
> Am Montag 11 Oktober 2010 17:47:04 schrieb Pavel Porvatov:
>> Hi Florian,
>>
>> Nice to see you! I'll take a look at your patch in a week (or couple of
>> weeks).
>>
>> Thanks, Pavel
>>> Hi Pavel,
>>>
>>> here is a patch to "generify" JComboBox along with: ComboBoxEditor, ComboBoxModel,
>>> DefaultComboBoxModel and MutableComboBoxModel.
>>>
>>> I fixed the BasicComboBoxEditor as I proposed in my last post.
>>>
>>> MutableComboBoxModel.removeElement is not generified currently and thus still takes an Object as argument. This is consistent with the Collection Framework (eg. java.util.List.remove). Please tell me if you prefer this method to take a generic parameter as well.
>>>
>>>
>>> I also created a new issue in the OpenJDK Bugzilla system:
>>> https://bugs.openjdk.java.net/show_bug.cgi?id=100153
>>>
>>> Regards,
>>> Florian
>>>
>>




More information about the swing-dev mailing list