<Swing Dev> When running with the Nimbus look and feel, the JFileChooser does not display mnemonics for its controls.

[Charles Lee]

On 08/18/2011 12:29 AM, Pavel Porvatov wrote:
> Hi Charles,
>> On 08/11/2011 10:02 PM, Pavel Porvatov wrote:
>>> Hi Charles,
>>>> On 08/08/2011 10:17 PM, Pavel Porvatov wrote:
>>>> Here is another one :-) it uses VK_code hard coded as mental does.  
>>>> If it is ok, I will like to take CR7024118. Is reflection ok to 
>>>> you, Pavel?
>>>>
>>> Your current fix has a localization problem: it doesn't not work for 
>>> other languages (the same problem described in 
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024118). I see 
>>> the fix in the following way:
>>>
>>> 1. Change getting mnemonics in SynthFileChooserUIImpl like in 
>>> WindowsFileChooserUI:
>>> lookInLabelMnemonic = 
>>> UIManager.getInt("FileChooser.lookInLabelMnemonic");
>>>
>>> 2. Add in synth.properties, synth_de.properties and other synth 
>>> properties files:
>>> FileChooser.lookInLabelMnemonic=49
>>> FileChooser.folderNameLabelMnemonic=...
>>> FileChooser.filesOfTypeLabelMnemonic=...
>>> FileChooser.filesOfTypeMnemonic=...
>>>
>>> where "..." is an appropriate integer numbers. BTW: we are using 
>>> integer mnemonics in other properties files, e.g. in 
>>> src\share\classes\com\sun\swing\internal\plaf\basic\resources\basic.properties 
>>>
>>>
>>> I agree that mnemonics in integer numbers is not very readable, but 
>>> this way is most compatible and localizable way, I think.
>>>
>>> Regards, Pavel
>>>
>> Hello Pavel, What about this patch (attached)?
>>
> I've changed your last patch a little bit and pushed it:
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0e03455d868c
>
> BTW: I found out that there are no reasons to change the 
> SynthFileChooserUIImpl class because current implementation works fine.
>
> Regards, Pavel
Unfortunately you are right.
The patch looks good to me. Hoping it will go to openjdk8.
Thanks a lot, Pavel. I owe you one beer :-)

-- 
Yours Charles