From littlee at linux.vnet.ibm.com  Fri Dec  2 08:53:30 2011
From: littlee at linux.vnet.ibm.com (Charles Lee)
Date: Fri, 02 Dec 2011 16:53:30 +0800
Subject: <Swing Dev> Maybe some not useful code in sun.awt.im.InputContext
Message-ID: <4ED8920A.3050202@linux.vnet.ibm.com>

Hi guys,

I am doing some code reading through the input method framework. Once I 
meet sun.awt.im.InputContext, I find the code (line 228), it says:

// Ignore focus events that relate to the InputMethodWindow of this 
context.
// This is a workaround.  Should be removed after 4452384 is fixed.

Does 4452384 mean: 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4452384 ?

If it is, 4452384 has been fixed.

Should the code below be removed?

-- 
Yours Charles



From neil.richards at ngmr.net  Fri Dec  2 09:18:06 2011
From: neil.richards at ngmr.net (Neil Richards)
Date: Fri, 02 Dec 2011 09:18:06 +0000
Subject: <Swing Dev> Unable to view focus in Non-Editable Text Area
In-Reply-To: <BANLkTinSNTXaDjvFJc1FQavJw0t8=GpmxQ@mail.gmail.com>
References: <AANLkTi=OyzOzSGMAN2LTFXT3Dw3kS5_j4eS9mVu7Mi34@mail.gmail.com>
	<BANLkTinSNTXaDjvFJc1FQavJw0t8=GpmxQ@mail.gmail.com>
Message-ID: <1322817486.26804.4.camel@chalkhill>

On Wed, 2011-04-13 at 16:54 +0800, Sean Chou wrote:
> Hi all,
> 
> 
> I found a similar bug was reported for JTextArea.
>  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4512626
> 
> 
> That bug is about JTextArea, while this is about TextArea behavior
> difference.
> 
> 
> It seems showing a caret is a general way to address this kind of
> accessibility.
> So I made a simple patch.
> 
> 
> diff -r 554adcfb615e src/solaris/classes/sun/awt/X11/XTextAreaPeer.java
> --- a/src/solaris/classes/sun/awt/X11/XTextAreaPeer.java	Wed Mar 16 15:01:07 2011 -0700
> +++ b/src/solaris/classes/sun/awt/X11/XTextAreaPeer.java	Fri Mar 18 16:31:56 2011 +0800
> @@ -664,6 +664,8 @@
>      class XAWTCaret extends DefaultCaret {
>          public void focusGained(FocusEvent e) {
>              super.focusGained(e);
> +            // Make sure the cursor in visible in case of non-editable TextArea
> +            super.setVisible(true);
>              getComponent().repaint();
>          }
>  
> 
> 
> 
> 2011/4/1 Sean Chou <zhouyx at linux.vnet.ibm.com>
>         Hi,
>            I find that if a TextArea is set to un-editable on linux
>         system, the customer will be
>         unable to view the focus when the TextArea gets focused(eg.
>         clicked). On 
>         windows, the cursor is blinking when the un-editable TextArea
>         get the focus.
>         So linux users may get confused when trying to move the focus
>         to the TextArea
>         because no visible feedback is given.
>         
>         
>            I think it will be better if TextArea behaves the same as
>         it is on windows.
>         Here is a simple testcase:
>         
>         
>         import java.awt.TextArea;
>         import javax.swing.JButton;
>         import javax.swing.JFrame;
>         import javax.swing.JPanel;
>         import javax.swing.JTextArea;
>         
>         
>         public class NonEditable {
>         public static void main(String[] str) {
>         JFrame jf = new JFrame();
>         JButton jb = new JButton("click");
>         JPanel jp = new JPanel();
>         jf.setSize(200, 200);
>         JTextArea jt = new JTextArea(3, 3);
>         jf.getContentPane().add(jp);
>         jp.add(jb);
>         jp.add(jt);
>         jf.setVisible(true);
>         jt.setText("hello how r u");
>         jt.setEditable(false);
>         TextArea ta = new TextArea(6, 10);
>         ta.setText("Rajesh kumar");
>         ta.setEditable(false);
>         jp.add(ta); 
>         }
>         }
>         
>         
>         
>         -- 
>         Best Regards,
>         Sean Chou
>         
> 
> 
> 
> -- 
> Best Regards,
> Sean Chou
> 

Hi Sean,
As your observation is about an AWT object (rather than a Swing one), I
think it best to raise this on the 'awt-dev' list.

I've cc'd this list so the folk there can consider your suggestion.

Regards, Neil

-- 
Neil Richards <neil.richards at ngmr.net>
IBM



From neil.richards at ngmr.net  Fri Dec  2 17:45:54 2011
From: neil.richards at ngmr.net (Neil Richards)
Date: Fri, 02 Dec 2011 17:45:54 +0000
Subject: <Swing Dev> Maybe some not useful code in
	sun.awt.im.InputContext
In-Reply-To: <4ED8920A.3050202@linux.vnet.ibm.com>
References: <4ED8920A.3050202@linux.vnet.ibm.com>
Message-ID: <1322847954.26804.12.camel@chalkhill>

On Fri, 2011-12-02 at 16:53 +0800, Charles Lee wrote:
> Hi guys,
> 
> I am doing some code reading through the input method framework. Once I 
> meet sun.awt.im.InputContext, I find the code (line 228), it says:
> 
> // Ignore focus events that relate to the InputMethodWindow of this 
> context.
> // This is a workaround.  Should be removed after 4452384 is fixed.
> 
> Does 4452384 mean: 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4452384 ?
> 
> If it is, 4452384 has been fixed.
> 
> Should the code below be removed?
> 

Hi Charles,
Judging by the ownership list held by the '2d' group [1],
sun.awt.im.InputContext is owned by the 'i18n' group.

Based on this, I'm moving this conversation across to the 'i18n-dev'
mailing list, so the folk there can consider your observation.

Regards, Neil

[1] http://openjdk.java.net/groups/2d/2dawtfiles.html

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From zhouyx at linux.vnet.ibm.com  Tue Dec  6 03:14:03 2011
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Tue, 6 Dec 2011 11:14:03 +0800
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
Message-ID: <CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>

Hi,

   I'm not sure what to do for it next, shall I create a bug for it now ?
But I
don't think the bug system support AIX platform. I remembered it would
report something like "we are not supporting the platform".


On Tue, Nov 29, 2011 at 10:05 AM, neugens.limasoftware at gmail.com <
neugens.limasoftware at gmail.com> wrote:

> The change looks good to me as well.
>
> Cheers,
> Mario
>
> Inviato da HTC
>
>
> ----- Reply message -----
> Da: "Deven" <youdwei at linux.vnet.ibm.com>
> Data: mar, nov 29, 2011 02:55
> Oggetto: <Swing Dev> Add Look&Feel support for AIX platform
> A: "Neil Richards" <neil.richards at ngmr.net>
> Cc: "Java Core Libs" <core-libs-dev at openjdk.java.net>, <
> swing-dev at openjdk.java.net>, <zhouyx at linux.vnet.ibm.com>
>
>
> On 10/20/2011 11:10 PM, Neil Richards wrote:
> > On Tue, 2011-10-18 at 15:53 +0800, Sean Chou wrote:
> >> Hi all,
> >>
> >>
> >>      This is a simple patch to add LookAndFeel support for AIX platform
> >> to help bring
> >> up GUI application.
> >>
> >>
> >>      This is part of the series of AIX patches.
> >> --
> >> Best Regards,
> >> Sean Chou
> >>
> >>
> > For ease of review, I've uploaded this suggested fix as a webrev [1].
> >
> > The change looks good to me.
> >
> > Regards, Neil
> >
> > [1] http://cr.openjdk.java.net/~ngmr/ojdk-167/webrev.00/index.html
> Hello, any more comments on this topic?
>
>
>
>


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111206/c7020aae/attachment.html>

From littlee at linux.vnet.ibm.com  Tue Dec  6 08:37:35 2011
From: littlee at linux.vnet.ibm.com (Charles Lee)
Date: Tue, 06 Dec 2011 16:37:35 +0800
Subject: <Swing Dev> Fwd: Re: TextArea's/TextField's enableInputMethods is
 not working on linux
Message-ID: <4EDDD44F.9080702@linux.vnet.ibm.com>

Sorry, just reply all gets me no swing-dev :-)

Any swing-dev experts can help this?

-------- Original Message --------
Subject: 	Re: TextArea's/TextField's enableInputMethods is not working 
on linux
Date: 	Tue, 06 Dec 2011 15:02:05 +0800
From: 	Charles Lee <littlee at linux.vnet.ibm.com>
To: 	core-libs-dev at openjdk.java.net, Naoto Sato <naoto.sato at oracle.com>



On 05/27/2011 03:18 AM, Naoto Sato wrote:
>  It simply sounds like a bug to me. The behavior should not be different.
>
>  Naoto
>
>  (5/26/11 12:25 AM), Sean Chou wrote:
>>  Hi all,
>>
>>      I found TextArea's/TextField's enableInputMethods is not working on
>>  linux,
>>  even enableInputMethods(false) is invocated, the input method can
>>  still be
>>  enabled.  The testcase is as follows:
>>
>>  /*
>>    * ImfAWTTest.java
>>    */
>>  import java.awt.Component;
>>  import java.awt.Dimension;
>>  import java.awt.FlowLayout;
>>  import java.awt.Frame;
>>  import java.awt.TextArea;
>>  import java.awt.TextField;
>>  import java.awt.event.WindowAdapter;
>>  import java.awt.event.WindowEvent;
>>
>>  import javax.swing.JTextArea;
>>  import javax.swing.JTextField;
>>
>>
>>  public class ImfAWTTest extends Frame {
>>  Component c;
>>  public ImfAWTTest() {
>>  super("Single Frame --- AWT Frame");
>>  // set layout here.
>>  setLayout(new FlowLayout());
>>  // add components here.
>>  c = new TextArea("TextArea component(No IM)");
>>  c.enableInputMethods(false);
>>  c.setPreferredSize(new Dimension(400, 100));
>>  add(c);
>>
>>  c = new JTextArea("JTextArea component");
>>  c.enableInputMethods(true);
>>  c.setPreferredSize(new Dimension(400, 100));
>>  add(c);
>>
>>  c = new TextField("TextField component(No IM)",52);
>>  c.enableInputMethods(false);
>>  add(c);
>>
>>  c = new JTextField("JTextField component(No IM)");
>>  c.enableInputMethods(false);
>>  c.setPreferredSize(new Dimension(400, 20));
>>  add(c);
>>  addWindowListener(new WindowAdapter() {
>>  public void windowClosing(WindowEvent event) {
>>  System.exit(0);
>>  }
>>  });
>>  setSize(850, 360);
>>  setVisible(true);
>>  }
>>  public static void main(String[] args) {
>>  new ImfAWTTest();
>>  }
>>  }
>>
>>
>>  Reproduce steps are:
>>  1. On linux system, run the testcase with b143.
>>  2.  Click 'TextArea component(No IM)'.
>>  3. Switch Ime window, and type some characters into it
>>
>>  Expectation:
>>     IME cannot be enabled.
>>  Result:
>>     IME can be used to input.
>>
>>
>>  Investigation:
>>      This behavior was developed when Java was using Motif library,
>>  however Java7's
>>  TextArea/TexField does not use Motif any more, so enableInputMethods
>>  doesn't
>>  work.
>>
>>
>>      I suppose we need to update the specification about the behavior.
>>  Any comments?
>>
>>
>>  -- 
>>  Best Regards,
>>  Sean Chou
>>
>
Hi all,

Here is a little progress on this issue.

The reason that enableInputMethod(false) does not take any effect is
that in XTextFieldPeer/XTextAreaPeer init, they will do
target.enbleInputMethods(true), which is re-enable the input methods again.
Once I was thinking the fixes should be easy. Just do not set the
enbleInputMethods(true) should do the trick. But I was found that
X****Peer was also required to set the inputMethods. Unfortunately, we
can not get any info about input methods from the target. (Is there
any?) The "areInputMethodsEnabled" method is package private ....

Any expertise can help on this issue? Thanks in advance.

-- 
Yours Charles


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111206/c47f45ff/attachment.html>

From zhouyx at linux.vnet.ibm.com  Wed Dec  7 08:21:30 2011
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Wed, 7 Dec 2011 16:21:30 +0800
Subject: <Swing Dev> Question about bug 4512626
Message-ID: <CAOo=rxVwvXw4JnZUYH5AQ6e+QseBLG_uZf3iRQVVUzBXTsKE2g@mail.gmail.com>

Hi all,

    I'm just working on a similar bug like 4512626, so I wrote a simple
testcase for 4512626.
However, I think 4512626 is not in the state as described in its comment.
   The comment says:

"

    MS Windows indicates the focus of uneditable text component by
displaying a flashing caret. We could make the same thing with
JTextField, JPasswordField, JFormattedTextField and JTextArea.
For Windows LAF we could make this without API changes just by
overriding createCaret() in corresponding UI classes.

"

I tested these 4 components in windows LAF and found they are not
displaying the caret at all.

Is that because it was thought "won't fix" ?


The link is : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4512626

The testcase is :

import java.awt.EventQueue;

import javax.swing.BoxLayout;
import javax.swing.JFormattedTextField;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JPasswordField;
import javax.swing.JTextArea;
import javax.swing.JTextField;
import javax.swing.UIManager;
import javax.swing.UnsupportedLookAndFeelException;
import javax.swing.border.EmptyBorder;
import javax.swing.JButton;


public class NonEditableFocusTest extends JFrame {

    private JPanel contentPane;
    private JTextField txtJtextfield;
    private JPasswordField passwordField;
    private JButton btnWinLf;

    /**
     * Launch the application.
     */
    public static void main(String[] args) {
        EventQueue.invokeLater(new Runnable() {
            public void run() {
                try {
                    NonEditableFocusTest frame = new NonEditableFocusTest();
                    frame.setVisible(true);
                } catch (Exception e) {
                    e.printStackTrace();
                }
            }
        });
    }

    /**
     * Create the frame.
     */
    public NonEditableFocusTest() {

        String LAF = UIManager.getSystemLookAndFeelClassName();
        try {
            UIManager.setLookAndFeel(LAF);
        } catch (ClassNotFoundException | InstantiationException
                | IllegalAccessException | UnsupportedLookAndFeelException
e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }

        setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        setBounds(100, 100, 450, 300);
        contentPane = new JPanel();
        contentPane.setBorder(new EmptyBorder(5, 5, 5, 5));
        setContentPane(contentPane);
        contentPane.setLayout(new BoxLayout(contentPane, BoxLayout.Y_AXIS));

        passwordField = new JPasswordField();
        passwordField.setEditable(false);
        passwordField.setText("passwod");
        passwordField.setToolTipText("JPasswordField");
        contentPane.add(passwordField);

        JFormattedTextField frmtdtxtfldJformattedtextfield = new
JFormattedTextField();
        frmtdtxtfldJformattedtextfield.setText("JFormattedTextField");
        frmtdtxtfldJformattedtextfield.setEditable(false);

frmtdtxtfldJformattedtextfield.setToolTipText("JFormattedTextField");
        contentPane.add(frmtdtxtfldJformattedtextfield);

        JTextArea txtrJtextarea = new JTextArea();
        txtrJtextarea.setText("JTextArea");
        txtrJtextarea.setEditable(false);
        txtrJtextarea.setToolTipText("JTextArea");
        contentPane.add(txtrJtextarea);

        txtJtextfield = new JTextField();
        txtJtextfield.setText("JTextField");
        txtJtextfield.setEditable(false);
        txtJtextfield.setToolTipText("JTextField");
        contentPane.add(txtJtextfield);
        txtJtextfield.setColumns(10);

        btnWinLf = new JButton(LAF);
        contentPane.add(btnWinLf);

    }
}




-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111207/6f43ffee/attachment.html>

From littlee at linux.vnet.ibm.com  Thu Dec  8 04:37:11 2011
From: littlee at linux.vnet.ibm.com (Charles Lee)
Date: Thu, 08 Dec 2011 12:37:11 +0800
Subject: <Swing Dev> Fwd: Re: TextArea's/TextField's enableInputMethods
 is not working on linux
In-Reply-To: <4EDDD44F.9080702@linux.vnet.ibm.com>
References: <4EDDD44F.9080702@linux.vnet.ibm.com>
Message-ID: <4EE03EF7.1070005@linux.vnet.ibm.com>

On 12/06/2011 04:37 PM, Charles Lee wrote:
> Sorry, just reply all gets me no swing-dev :-)
>
> Any swing-dev experts can help this?
>
> -------- Original Message --------
> Subject: 	Re: TextArea's/TextField's enableInputMethods is not working 
> on linux
> Date: 	Tue, 06 Dec 2011 15:02:05 +0800
> From: 	Charles Lee <littlee at linux.vnet.ibm.com>
> To: 	core-libs-dev at openjdk.java.net, Naoto Sato <naoto.sato at oracle.com>
>
>
>
> On 05/27/2011 03:18 AM, Naoto Sato wrote:
> >  It simply sounds like a bug to me. The behavior should not be different.
> >
> >  Naoto
> >
> >  (5/26/11 12:25 AM), Sean Chou wrote:
> >>  Hi all,
> >>
> >>      I found TextArea's/TextField's enableInputMethods is not working on
> >>  linux,
> >>  even enableInputMethods(false) is invocated, the input method can
> >>  still be
> >>  enabled.  The testcase is as follows:
> >>
> >>  /*
> >>    * ImfAWTTest.java
> >>    */
> >>  import java.awt.Component;
> >>  import java.awt.Dimension;
> >>  import java.awt.FlowLayout;
> >>  import java.awt.Frame;
> >>  import java.awt.TextArea;
> >>  import java.awt.TextField;
> >>  import java.awt.event.WindowAdapter;
> >>  import java.awt.event.WindowEvent;
> >>
> >>  import javax.swing.JTextArea;
> >>  import javax.swing.JTextField;
> >>
> >>
> >>  public class ImfAWTTest extends Frame {
> >>  Component c;
> >>  public ImfAWTTest() {
> >>  super("Single Frame --- AWT Frame");
> >>  // set layout here.
> >>  setLayout(new FlowLayout());
> >>  // add components here.
> >>  c = new TextArea("TextArea component(No IM)");
> >>  c.enableInputMethods(false);
> >>  c.setPreferredSize(new Dimension(400, 100));
> >>  add(c);
> >>
> >>  c = new JTextArea("JTextArea component");
> >>  c.enableInputMethods(true);
> >>  c.setPreferredSize(new Dimension(400, 100));
> >>  add(c);
> >>
> >>  c = new TextField("TextField component(No IM)",52);
> >>  c.enableInputMethods(false);
> >>  add(c);
> >>
> >>  c = new JTextField("JTextField component(No IM)");
> >>  c.enableInputMethods(false);
> >>  c.setPreferredSize(new Dimension(400, 20));
> >>  add(c);
> >>  addWindowListener(new WindowAdapter() {
> >>  public void windowClosing(WindowEvent event) {
> >>  System.exit(0);
> >>  }
> >>  });
> >>  setSize(850, 360);
> >>  setVisible(true);
> >>  }
> >>  public static void main(String[] args) {
> >>  new ImfAWTTest();
> >>  }
> >>  }
> >>
> >>
> >>  Reproduce steps are:
> >>  1. On linux system, run the testcase with b143.
> >>  2.  Click 'TextArea component(No IM)'.
> >>  3. Switch Ime window, and type some characters into it
> >>
> >>  Expectation:
> >>     IME cannot be enabled.
> >>  Result:
> >>     IME can be used to input.
> >>
> >>
> >>  Investigation:
> >>      This behavior was developed when Java was using Motif library,
> >>  however Java7's
> >>  TextArea/TexField does not use Motif any more, so enableInputMethods
> >>  doesn't
> >>  work.
> >>
> >>
> >>      I suppose we need to update the specification about the behavior.
> >>  Any comments?
> >>
> >>
> >>  -- 
> >>  Best Regards,
> >>  Sean Chou
> >>
> >
> Hi all,
>
> Here is a little progress on this issue.
>
> The reason that enableInputMethod(false) does not take any effect is
> that in XTextFieldPeer/XTextAreaPeer init, they will do
> target.enbleInputMethods(true), which is re-enable the input methods again.
> Once I was thinking the fixes should be easy. Just do not set the
> enbleInputMethods(true) should do the trick. But I was found that
> X****Peer was also required to set the inputMethods. Unfortunately, we
> can not get any info about input methods from the target. (Is there
> any?) The "areInputMethodsEnabled" method is package private ....
>
> Any expertise can help on this issue? Thanks in advance.
>
> -- 
> Yours Charles
>
Hello,

Maybe I need to post this to the awt-dev mailing list?

-- 
Yours Charles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111208/d2a76db2/attachment.html>

From lvjing at linux.vnet.ibm.com  Thu Dec  8 08:54:11 2011
From: lvjing at linux.vnet.ibm.com (Jing Lv)
Date: Thu, 08 Dec 2011 16:54:11 +0800
Subject: <Swing Dev> [Accessibility]Focus unable to traverse in the
	menubar
In-Reply-To: <4EBA633A.9000101@oracle.com>
References: <4E730733.6020402@linux.vnet.ibm.com> <4E7710C7.5030506@oracle.com>
	<1316522669.4683.10.camel@chalkhill>
	<4E8C7A0B.7060006@oracle.com> <4E92EB65.6080605@oracle.com>
	<1318258874.7676.33.camel@chalkhill> <4E958E1D.7030205@oracle.com>
	<4EB0E593.8050909@linux.vnet.ibm.com> <4EB1307D.8040301@oracle.com>
	<4EBA3F1D.8070201@linux.vnet.ibm.com> <4EBA633A.9000101@oracle.com>
Message-ID: <4EE07B33.5020407@linux.vnet.ibm.com>

Hello,

     Thanks Pavel. Some update from the developers. One question remains 
that given menus or menubars are supposed to be added to the main 
container rather than mixing them with the other components in the UI,  
why the JMenuBars are made focus enabled by default when their focus 
traversal keys are disabled. If someone moves the focus to the JMenuBar, 
how would they move the focus away from the JMenuBar if the focus 
traversal keys are disabled (So does JMenuBar really needed to be focus 
enabled by default)? Shall we also modify the spec/implementation to 
make it clear to the customers?
     Thanks.

On 2011/11/9 19:25, Pavel Porvatov wrote:
> Hi Jing,
>> Thanks Pavel,
>>
>>      It seems fine to me, if no other suggestions/opinions, I guess 
>> we can move on with this?
> Yes, we can. Could you please file a bug for the problem as well?
>
> Thanks, Pavel
>>
>> On 2011/11/2 19:58, Pavel Porvatov wrote:
>>> Hi Jing,
>>>>
>>>> Hello Anton,
>>>>
>>>>     Thanks for the review. I am still trying to figure out some 
>>>> real case and provide more detail the customer may fail.
>>>>     Anyway, I agree we'd better update the java spec to make it 
>>>> clear for the customers. I'd like to know if anyone can help with 
>>>> that?
>>> I'm not sure that javadoc changing is a good decision in this case. 
>>> ContainerOrderFocusTraversalPolicy is designed for AWT, but I don't 
>>> know why that policy cannot be used for Swing components as well. I 
>>> see several problems:
>>> 1. We cannot change javadoc of ContainerOrderFocusTraversalPolicy 
>>> because of backward compatibility
>>> 2. We cannot remove setFocusTraversalKeysEnabled(false) from the 
>>> JMenuBar#JMenuBar() constructor because of backward compatibility
>>>
>>> May be the best decision is to specify, that JMenuBar creates menu 
>>> with the focusTraversalKeysEnabled = false
>>>
>>> Regards, Pavel
>>>>
>>>> On 2011/10/12 20:54, Anton Tarasov wrote:
>>>>> Hi Neil,
>>>>>
>>>>> On 10/10/2011 7:01 PM, Neil Richards wrote:
>>>>>> On Mon, 2011-10-10 at 16:56 +0400, Anton Tarasov wrote:
>>>>>>> Hi Neil and Jing,
>>>>>>> I'm afraid that it's wrong to use 
>>>>>>> ContainerOrderFocusTraversalPolicy
>>>>>>> for swing components. This policy is designed for AWT.
>>>>>>> JMenuBar calls setFocusTraversalKeysEnabled(false) in its ctor 
>>>>>>> which
>>>>>>> means that it "swallows" focus traversal keys (like TAB/SHIFT-TAB
>>>>>>> etc.)
>>>>>>> and so it can't be a member of a focus traversal chain. Swing's
>>>>>>> default traversal policy (LayoutFocusTraversalPolicy) excludes
>>>>>>> JMenuBar
>>>>>>> from a focus traversal cycle. ContainerOrderFocusTraversalPolicy is
>>>>>>> not "aware" about JMenuBar and so it allows it.
>>>>>>>
>>>>>>> So, either a default Swing policy should be used, or a custom 
>>>>>>> policy.
>>>>>>> At worst, ContainerOrderFocusTraversalPolicy should be overriden
>>>>>>> to exclude JMenuBar from a cycle (override its accept(Component)
>>>>>>> method).
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Anton.
>>>>>> Hi Anton,
>>>>>> Thanks for reviewing the suggestion, and for your insights into this
>>>>>> scenario.
>>>>>>
>>>>>> > From the Javadoc, it seems that setFocusTraversalKeysEnabled() 
>>>>>> is mainly
>>>>>> concerned with choosing whether focus traversal key presses 
>>>>>> (normally
>>>>>> TAB and SHIFT-TAB) are processed "automatically" (when 'true') or 
>>>>>> are
>>>>>> delivered to the Component as key events (for the component's 
>>>>>> code to
>>>>>> process "manually").
>>>>>>
>>>>>> (In the case of JMenuBar, it makes them come through as key 
>>>>>> events, but
>>>>>> doesn't do anything special to process these events, which is why 
>>>>>> they
>>>>>> get discarded.)
>>>>>
>>>>> That is right, though it doesn't directly relate to the issue 
>>>>> we're talking about =)
>>>>>
>>>>>> Your description above, though, seems to suggest that it is 
>>>>>> generally
>>>>>> undesirable for the JMenuBar to be given the focus, as all the
>>>>>> Swing-aware focus traversal policies make a point of not giving 
>>>>>> focus to
>>>>>> JMenuBar items.
>>>>>>
>>>>>> If this is so, then wouldn't it make sense to call 
>>>>>> setFocusable(false)
>>>>>> from its constructor (too), to ensure it doesn't get focus ?
>>>>>>
>>>>>> Or, to put it another way, could you explain a little of the 
>>>>>> reasoning
>>>>>> or scenario behind why it is desirable for JMenuBar items to be
>>>>>> generally focusable, even though they aren't focus-traversable ?
>>>>>>
>>>>>> I think such an explanation would be really helpful in clearing 
>>>>>> up my
>>>>>> confusion on this point.
>>>>>>
>>>>>> Thanks, Neil
>>>>>>
>>>>>
>>>>> Well, I suspect that the core of the problem is that adding 
>>>>> JMenuBar as JComponent to a swing
>>>>> container doesn't make much sense. Though it is not directly 
>>>>> prohibited, doing so may cause
>>>>> side effects like the one you've discovered. When JMenuBar is set 
>>>>> properly onto a JFrame its focus
>>>>> is managed by JRootPane and its focusability just isn't taken into 
>>>>> account. That's may be the reason
>>>>> it's not declared unfocusable. Honestly, I can't tell you exactly.
>>>>>
>>>>> If you do it, you probably won't make any harm, but I personally 
>>>>> don't think this is a vital fix
>>>>> (unless you have a good use case of the scenario you've provided). 
>>>>> Anyway, this is a swing question
>>>>> (I'm, as an AWT dev member, leaving the decision to swing guys).
>>>>>
>>>>> Thanks,
>>>>> Anton.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>



From zhouyx at linux.vnet.ibm.com  Fri Dec  9 07:46:58 2011
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Fri, 9 Dec 2011 15:46:58 +0800
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
Message-ID: <CAOo=rxW_VQv1k3H9gTh2jy1qH3ve1CWzoe6m4Lys_Xn2CmBFQQ@mail.gmail.com>

I split the patch as it would be better to divide the platform recognizing
in OSInfo class
and the system laf returned by UIManager. I sent the OSInfo part into
core-libs-dev
list. Here is the link:

http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-December/008638.html


On Tue, Dec 6, 2011 at 11:14 AM, Sean Chou <zhouyx at linux.vnet.ibm.com>wrote:

> Hi,
>
>    I'm not sure what to do for it next, shall I create a bug for it now ?
> But I
> don't think the bug system support AIX platform. I remembered it would
> report something like "we are not supporting the platform".
>
>
> On Tue, Nov 29, 2011 at 10:05 AM, neugens.limasoftware at gmail.com <
> neugens.limasoftware at gmail.com> wrote:
>
>> The change looks good to me as well.
>>
>> Cheers,
>> Mario
>>
>> Inviato da HTC
>>
>>
>> ----- Reply message -----
>> Da: "Deven" <youdwei at linux.vnet.ibm.com>
>> Data: mar, nov 29, 2011 02:55
>> Oggetto: <Swing Dev> Add Look&Feel support for AIX platform
>> A: "Neil Richards" <neil.richards at ngmr.net>
>> Cc: "Java Core Libs" <core-libs-dev at openjdk.java.net>, <
>> swing-dev at openjdk.java.net>, <zhouyx at linux.vnet.ibm.com>
>>
>>
>> On 10/20/2011 11:10 PM, Neil Richards wrote:
>> > On Tue, 2011-10-18 at 15:53 +0800, Sean Chou wrote:
>> >> Hi all,
>> >>
>> >>
>> >>      This is a simple patch to add LookAndFeel support for AIX platform
>> >> to help bring
>> >> up GUI application.
>> >>
>> >>
>> >>      This is part of the series of AIX patches.
>> >> --
>> >> Best Regards,
>> >> Sean Chou
>> >>
>> >>
>> > For ease of review, I've uploaded this suggested fix as a webrev [1].
>> >
>> > The change looks good to me.
>> >
>> > Regards, Neil
>> >
>> > [1] http://cr.openjdk.java.net/~ngmr/ojdk-167/webrev.00/index.html
>> Hello, any more comments on this topic?
>>
>>
>>
>>
>
>
> --
> Best Regards,
> Sean Chou
>
>


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111209/ca1cbaa8/attachment.html>

From neil.richards at ngmr.net  Mon Dec 12 11:33:39 2011
From: neil.richards at ngmr.net (Neil Richards)
Date: Mon, 12 Dec 2011 11:33:39 +0000
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
Message-ID: <1323689619.20905.3.camel@chalkhill>

On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
> Hi,
> 
> 
>    I'm not sure what to do for it next, shall I create a bug for it
> now ? But I
> don't think the bug system support AIX platform. I remembered it
> would 
> report something like "we are not supporting the platform".
> 

Hi Sean,
Looking at the options available on the Java bug submission site [1], it
looks like:
        Release:           OpenJDK
        Operating System:  Generic / Other

would be the most appropriate choices to make.

Regards,
Neil

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From zhouyx at linux.vnet.ibm.com  Tue Dec 13 02:36:13 2011
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Tue, 13 Dec 2011 10:36:13 +0800
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <1323689619.20905.3.camel@chalkhill>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
	<1323689619.20905.3.camel@chalkhill>
Message-ID: <CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>

I tried once, and it was dropped because "the platform is not supported."

On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards <neil.richards at ngmr.net>wrote:

> On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
> > Hi,
> >
> >
> >    I'm not sure what to do for it next, shall I create a bug for it
> > now ? But I
> > don't think the bug system support AIX platform. I remembered it
> > would
> > report something like "we are not supporting the platform".
> >
>
> Hi Sean,
> Looking at the options available on the Java bug submission site [1], it
> looks like:
>        Release:           OpenJDK
>        Operating System:  Generic / Other
>
> would be the most appropriate choices to make.
>
> Regards,
> Neil
>
> --
> Unless stated above:
> IBM email: neil_richards at uk.ibm.com
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111213/5e6d9010/attachment.html>

From lvjing at linux.vnet.ibm.com  Tue Dec 13 08:46:59 2011
From: lvjing at linux.vnet.ibm.com (Jing Lv)
Date: Tue, 13 Dec 2011 16:46:59 +0800
Subject: <Swing Dev> [Accessibility]Focus unable to traverse in the
	menubar
In-Reply-To: <4EE07B33.5020407@linux.vnet.ibm.com>
References: <4E730733.6020402@linux.vnet.ibm.com>
	<4E7710C7.5030506@oracle.com>	<1316522669.4683.10.camel@chalkhill>
	<4E8C7A0B.7060006@oracle.com> <4E92EB65.6080605@oracle.com>
	<1318258874.7676.33.camel@chalkhill> <4E958E1D.7030205@oracle.com>
	<4EB0E593.8050909@linux.vnet.ibm.com> <4EB1307D.8040301@oracle.com>
	<4EBA3F1D.8070201@linux.vnet.ibm.com> <4EBA633A.9000101@oracle.com>
	<4EE07B33.5020407@linux.vnet.ibm.com>
Message-ID: <4EE71103.4000503@linux.vnet.ibm.com>

Hello,

     Ping, may someone give some answer? Thanks.

On 2011/12/8 16:54, Jing Lv wrote:
> Hello,
>
>     Thanks Pavel. Some update from the developers. One question 
> remains that given menus or menubars are supposed to be added to the 
> main container rather than mixing them with the other components in 
> the UI,  why the JMenuBars are made focus enabled by default when 
> their focus traversal keys are disabled. If someone moves the focus to 
> the JMenuBar, how would they move the focus away from the JMenuBar if 
> the focus traversal keys are disabled (So does JMenuBar really needed 
> to be focus enabled by default)? Shall we also modify the 
> spec/implementation to make it clear to the customers?
>     Thanks.
>
> On 2011/11/9 19:25, Pavel Porvatov wrote:
>> Hi Jing,
>>> Thanks Pavel,
>>>
>>>      It seems fine to me, if no other suggestions/opinions, I guess 
>>> we can move on with this?
>> Yes, we can. Could you please file a bug for the problem as well?
>>
>> Thanks, Pavel
>>>
>>> On 2011/11/2 19:58, Pavel Porvatov wrote:
>>>> Hi Jing,
>>>>>
>>>>> Hello Anton,
>>>>>
>>>>>     Thanks for the review. I am still trying to figure out some 
>>>>> real case and provide more detail the customer may fail.
>>>>>     Anyway, I agree we'd better update the java spec to make it 
>>>>> clear for the customers. I'd like to know if anyone can help with 
>>>>> that?
>>>> I'm not sure that javadoc changing is a good decision in this case. 
>>>> ContainerOrderFocusTraversalPolicy is designed for AWT, but I don't 
>>>> know why that policy cannot be used for Swing components as well. I 
>>>> see several problems:
>>>> 1. We cannot change javadoc of ContainerOrderFocusTraversalPolicy 
>>>> because of backward compatibility
>>>> 2. We cannot remove setFocusTraversalKeysEnabled(false) from the 
>>>> JMenuBar#JMenuBar() constructor because of backward compatibility
>>>>
>>>> May be the best decision is to specify, that JMenuBar creates menu 
>>>> with the focusTraversalKeysEnabled = false
>>>>
>>>> Regards, Pavel
>>>>>
>>>>> On 2011/10/12 20:54, Anton Tarasov wrote:
>>>>>> Hi Neil,
>>>>>>
>>>>>> On 10/10/2011 7:01 PM, Neil Richards wrote:
>>>>>>> On Mon, 2011-10-10 at 16:56 +0400, Anton Tarasov wrote:
>>>>>>>> Hi Neil and Jing,
>>>>>>>> I'm afraid that it's wrong to use 
>>>>>>>> ContainerOrderFocusTraversalPolicy
>>>>>>>> for swing components. This policy is designed for AWT.
>>>>>>>> JMenuBar calls setFocusTraversalKeysEnabled(false) in its ctor 
>>>>>>>> which
>>>>>>>> means that it "swallows" focus traversal keys (like TAB/SHIFT-TAB
>>>>>>>> etc.)
>>>>>>>> and so it can't be a member of a focus traversal chain. Swing's
>>>>>>>> default traversal policy (LayoutFocusTraversalPolicy) excludes
>>>>>>>> JMenuBar
>>>>>>>> from a focus traversal cycle. 
>>>>>>>> ContainerOrderFocusTraversalPolicy is
>>>>>>>> not "aware" about JMenuBar and so it allows it.
>>>>>>>>
>>>>>>>> So, either a default Swing policy should be used, or a custom 
>>>>>>>> policy.
>>>>>>>> At worst, ContainerOrderFocusTraversalPolicy should be overriden
>>>>>>>> to exclude JMenuBar from a cycle (override its accept(Component)
>>>>>>>> method).
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Anton.
>>>>>>> Hi Anton,
>>>>>>> Thanks for reviewing the suggestion, and for your insights into 
>>>>>>> this
>>>>>>> scenario.
>>>>>>>
>>>>>>> > From the Javadoc, it seems that setFocusTraversalKeysEnabled() 
>>>>>>> is mainly
>>>>>>> concerned with choosing whether focus traversal key presses 
>>>>>>> (normally
>>>>>>> TAB and SHIFT-TAB) are processed "automatically" (when 'true') 
>>>>>>> or are
>>>>>>> delivered to the Component as key events (for the component's 
>>>>>>> code to
>>>>>>> process "manually").
>>>>>>>
>>>>>>> (In the case of JMenuBar, it makes them come through as key 
>>>>>>> events, but
>>>>>>> doesn't do anything special to process these events, which is 
>>>>>>> why they
>>>>>>> get discarded.)
>>>>>>
>>>>>> That is right, though it doesn't directly relate to the issue 
>>>>>> we're talking about =)
>>>>>>
>>>>>>> Your description above, though, seems to suggest that it is 
>>>>>>> generally
>>>>>>> undesirable for the JMenuBar to be given the focus, as all the
>>>>>>> Swing-aware focus traversal policies make a point of not giving 
>>>>>>> focus to
>>>>>>> JMenuBar items.
>>>>>>>
>>>>>>> If this is so, then wouldn't it make sense to call 
>>>>>>> setFocusable(false)
>>>>>>> from its constructor (too), to ensure it doesn't get focus ?
>>>>>>>
>>>>>>> Or, to put it another way, could you explain a little of the 
>>>>>>> reasoning
>>>>>>> or scenario behind why it is desirable for JMenuBar items to be
>>>>>>> generally focusable, even though they aren't focus-traversable ?
>>>>>>>
>>>>>>> I think such an explanation would be really helpful in clearing 
>>>>>>> up my
>>>>>>> confusion on this point.
>>>>>>>
>>>>>>> Thanks, Neil
>>>>>>>
>>>>>>
>>>>>> Well, I suspect that the core of the problem is that adding 
>>>>>> JMenuBar as JComponent to a swing
>>>>>> container doesn't make much sense. Though it is not directly 
>>>>>> prohibited, doing so may cause
>>>>>> side effects like the one you've discovered. When JMenuBar is set 
>>>>>> properly onto a JFrame its focus
>>>>>> is managed by JRootPane and its focusability just isn't taken 
>>>>>> into account. That's may be the reason
>>>>>> it's not declared unfocusable. Honestly, I can't tell you exactly.
>>>>>>
>>>>>> If you do it, you probably won't make any harm, but I personally 
>>>>>> don't think this is a vital fix
>>>>>> (unless you have a good use case of the scenario you've 
>>>>>> provided). Anyway, this is a swing question
>>>>>> (I'm, as an AWT dev member, leaving the decision to swing guys).
>>>>>>
>>>>>> Thanks,
>>>>>> Anton.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>



From neil.richards at ngmr.net  Tue Dec 13 14:42:29 2011
From: neil.richards at ngmr.net (Neil Richards)
Date: Tue, 13 Dec 2011 14:42:29 +0000
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
	<1323689619.20905.3.camel@chalkhill>
	<CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>
Message-ID: <1323787349.20905.15.camel@chalkhill>

On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote:
> On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards
> <neil.richards at ngmr.net> wrote:
>         On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
>         > Hi,
>         >
>         >
>         >    I'm not sure what to do for it next, shall I create a bug
>         for it
>         > now ? But I
>         > don't think the bug system support AIX platform. I
>         remembered it
>         > would
>         > report something like "we are not supporting the platform".
>         >
>         
>         
>         Hi Sean,
>         Looking at the options available on the Java bug submission
>         site [1], it
>         looks like:
>                Release:           OpenJDK
>                Operating System:  Generic / Other
>         
>         would be the most appropriate choices to make.
>         
>         Regards,
>         Neil
>         
>         
>         --
>         Unless stated above:
>         IBM email: neil_richards at uk.ibm.com
>         IBM United Kingdom Limited - Registered in England and Wales
>         with number 741598.
>         Registered office: PO Box 41, North Harbour, Portsmouth,
>         Hampshire PO6 3AU

> I tried once, and it was dropped because "the platform is not
> supported."
> 
> -- 
> Best Regards,
> Sean Chou
> 

Hmm, in that case, perhaps someone from Oracle can help in creating a
suitable Java bug id under which this change can be made?

>From the OpenJDK census [1], I see that both Mario and I are currently
"committers" in the jdk8 project.

As jdk8 is under review control, I believe you'll need some affirmation
from someone who is a "reviewer".

Such a person is currently likely to be from Oracle, and so may be able
to help in creating the associated bug id.

Hope this helps.

Regards,
Neil

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From neil.richards at ngmr.net  Tue Dec 13 14:45:15 2011
From: neil.richards at ngmr.net (Neil Richards)
Date: Tue, 13 Dec 2011 14:45:15 +0000
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <1323787349.20905.15.camel@chalkhill>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
	<1323689619.20905.3.camel@chalkhill>
	<CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>
	<1323787349.20905.15.camel@chalkhill>
Message-ID: <1323787515.20905.17.camel@chalkhill>

On Tue, 2011-12-13 at 14:42 +0000, Neil Richards wrote:
> On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote:
> > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards
> > <neil.richards at ngmr.net> wrote:
> >         On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
> >         > Hi,
> >         >
> >         >
> >         >    I'm not sure what to do for it next, shall I create a bug
> >         for it
> >         > now ? But I
> >         > don't think the bug system support AIX platform. I
> >         remembered it
> >         > would
> >         > report something like "we are not supporting the platform".
> >         >
> >         
> >         
> >         Hi Sean,
> >         Looking at the options available on the Java bug submission
> >         site [1], it
> >         looks like:
> >                Release:           OpenJDK
> >                Operating System:  Generic / Other
> >         
> >         would be the most appropriate choices to make.
> >         
> >         Regards,
> >         Neil
> >         
> >         
> >         --
> >         Unless stated above:
> >         IBM email: neil_richards at uk.ibm.com
> >         IBM United Kingdom Limited - Registered in England and Wales
> >         with number 741598.
> >         Registered office: PO Box 41, North Harbour, Portsmouth,
> >         Hampshire PO6 3AU
> 
> > I tried once, and it was dropped because "the platform is not
> > supported."
> > 
> > -- 
> > Best Regards,
> > Sean Chou
> > 
> 
> Hmm, in that case, perhaps someone from Oracle can help in creating a
> suitable Java bug id under which this change can be made?
> 
> >From the OpenJDK census [1], I see that both Mario and I are currently
> "committers" in the jdk8 project.
> 
> As jdk8 is under review control, I believe you'll need some affirmation
> from someone who is a "reviewer".
> 
> Such a person is currently likely to be from Oracle, and so may be able
> to help in creating the associated bug id.
> 
> Hope this helps.
> 
> Regards,
> Neil
> 

Oops, forgot to give the trailed link to the OpenJDK census.

Regards, Neil

[1] http://openjdk.java.net/census

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From ahughes at redhat.com  Wed Dec 14 00:44:29 2011
From: ahughes at redhat.com (Dr Andrew John Hughes)
Date: Wed, 14 Dec 2011 00:44:29 +0000
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <1323787515.20905.17.camel@chalkhill>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
	<1323689619.20905.3.camel@chalkhill>
	<CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>
	<1323787349.20905.15.camel@chalkhill>
	<1323787515.20905.17.camel@chalkhill>
Message-ID: <20111214004429.GE25730@rivendell.middle-earth.co.uk>

On 14:45 Tue 13 Dec     , Neil Richards wrote:
> On Tue, 2011-12-13 at 14:42 +0000, Neil Richards wrote:
> > On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote:
> > > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards
> > > <neil.richards at ngmr.net> wrote:
> > >         On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
> > >         > Hi,
> > >         >
> > >         >
> > >         >    I'm not sure what to do for it next, shall I create a bug
> > >         for it
> > >         > now ? But I
> > >         > don't think the bug system support AIX platform. I
> > >         remembered it
> > >         > would
> > >         > report something like "we are not supporting the platform".
> > >         >
> > >         
> > >         
> > >         Hi Sean,
> > >         Looking at the options available on the Java bug submission
> > >         site [1], it
> > >         looks like:
> > >                Release:           OpenJDK
> > >                Operating System:  Generic / Other
> > >         
> > >         would be the most appropriate choices to make.
> > >         
> > >         Regards,
> > >         Neil
> > >         
> > >         
> > >         --
> > >         Unless stated above:
> > >         IBM email: neil_richards at uk.ibm.com
> > >         IBM United Kingdom Limited - Registered in England and Wales
> > >         with number 741598.
> > >         Registered office: PO Box 41, North Harbour, Portsmouth,
> > >         Hampshire PO6 3AU
> > 
> > > I tried once, and it was dropped because "the platform is not
> > > supported."
> > > 
> > > -- 
> > > Best Regards,
> > > Sean Chou
> > > 
> > 
> > Hmm, in that case, perhaps someone from Oracle can help in creating a
> > suitable Java bug id under which this change can be made?
> > 
> > >From the OpenJDK census [1], I see that both Mario and I are currently
> > "committers" in the jdk8 project.
> > 
> > As jdk8 is under review control, I believe you'll need some affirmation
> > from someone who is a "reviewer".
> > 
> > Such a person is currently likely to be from Oracle, and so may be able
> > to help in creating the associated bug id.
> > 
> > Hope this helps.
> > 
> > Regards,
> > Neil
> > 
> 
> Oops, forgot to give the trailed link to the OpenJDK census.
> 
> Regards, Neil
> 
> [1] http://openjdk.java.net/census
> 
> -- 
> Unless stated above:
> IBM email: neil_richards at uk.ibm.com
> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> 

This seems to have dragged on an unduly long time for such a simple patch.

The patch looks good to me.  The only minor point I'd make is that the
comment '// determine another OS here' should probably be under where the
AIX if block is added, not above it.

According to the census, I have jdk8 reviewer status so this should count
as a review.  However, as we're still stuck with the antiquated bug system
at present, we still need someone at Oracle to give it a bug ID.

So if an Oracle employee would be so kind as to do so, this can
finally be pushed.  It's only about two months old...
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07


From zhouyx at linux.vnet.ibm.com  Wed Dec 14 08:00:18 2011
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Wed, 14 Dec 2011 16:00:18 +0800
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <20111214004429.GE25730@rivendell.middle-earth.co.uk>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
	<1323689619.20905.3.camel@chalkhill>
	<CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>
	<1323787349.20905.15.camel@chalkhill>
	<1323787515.20905.17.camel@chalkhill>
	<20111214004429.GE25730@rivendell.middle-earth.co.uk>
Message-ID: <CAOo=rxUrTwQFQ5LUKOMoQEDq2Fub7N0qNSmqTwaLnyua2Oa9xQ@mail.gmail.com>

Thanks for the comment! I modified it according to your suggestion. The new
version is here: http://cr.openjdk.java.net/~zhouyx/OJDK-167/webrev.00/

So will any oracle guy help create a bug and push it or give some additional
comments so I can enhance the patch ?


On Wed, Dec 14, 2011 at 8:44 AM, Dr Andrew John Hughes
<ahughes at redhat.com>wrote:

> On 14:45 Tue 13 Dec     , Neil Richards wrote:
> > On Tue, 2011-12-13 at 14:42 +0000, Neil Richards wrote:
> > > On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote:
> > > > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards
> > > > <neil.richards at ngmr.net> wrote:
> > > >         On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
> > > >         > Hi,
> > > >         >
> > > >         >
> > > >         >    I'm not sure what to do for it next, shall I create a
> bug
> > > >         for it
> > > >         > now ? But I
> > > >         > don't think the bug system support AIX platform. I
> > > >         remembered it
> > > >         > would
> > > >         > report something like "we are not supporting the platform".
> > > >         >
> > > >
> > > >
> > > >         Hi Sean,
> > > >         Looking at the options available on the Java bug submission
> > > >         site [1], it
> > > >         looks like:
> > > >                Release:           OpenJDK
> > > >                Operating System:  Generic / Other
> > > >
> > > >         would be the most appropriate choices to make.
> > > >
> > > >         Regards,
> > > >         Neil
> > > >
> > > >
> > > >         --
> > > >         Unless stated above:
> > > >         IBM email: neil_richards at uk.ibm.com
> > > >         IBM United Kingdom Limited - Registered in England and Wales
> > > >         with number 741598.
> > > >         Registered office: PO Box 41, North Harbour, Portsmouth,
> > > >         Hampshire PO6 3AU
> > >
> > > > I tried once, and it was dropped because "the platform is not
> > > > supported."
> > > >
> > > > --
> > > > Best Regards,
> > > > Sean Chou
> > > >
> > >
> > > Hmm, in that case, perhaps someone from Oracle can help in creating a
> > > suitable Java bug id under which this change can be made?
> > >
> > > >From the OpenJDK census [1], I see that both Mario and I are currently
> > > "committers" in the jdk8 project.
> > >
> > > As jdk8 is under review control, I believe you'll need some affirmation
> > > from someone who is a "reviewer".
> > >
> > > Such a person is currently likely to be from Oracle, and so may be able
> > > to help in creating the associated bug id.
> > >
> > > Hope this helps.
> > >
> > > Regards,
> > > Neil
> > >
> >
> > Oops, forgot to give the trailed link to the OpenJDK census.
> >
> > Regards, Neil
> >
> > [1] http://openjdk.java.net/census
> >
> > --
> > Unless stated above:
> > IBM email: neil_richards at uk.ibm.com
> > IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
> >
>
> This seems to have dragged on an unduly long time for such a simple patch.
>
> The patch looks good to me.  The only minor point I'd make is that the
> comment '// determine another OS here' should probably be under where the
> AIX if block is added, not above it.
>
> According to the census, I have jdk8 reviewer status so this should count
> as a review.  However, as we're still stuck with the antiquated bug system
> at present, we still need someone at Oracle to give it a bug ID.
>
> So if an Oracle employee would be so kind as to do so, this can
> finally be pushed.  It's only about two months old...
> --
> Andrew :)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: 248BDC07 (https://keys.indymedia.org/)
> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
>



-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111214/1310cd40/attachment.html>

From alexandr.scherbatiy at oracle.com  Wed Dec 14 08:16:21 2011
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 14 Dec 2011 12:16:21 +0400
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <CAOo=rxUrTwQFQ5LUKOMoQEDq2Fub7N0qNSmqTwaLnyua2Oa9xQ@mail.gmail.com>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>	<1323689619.20905.3.camel@chalkhill>	<CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>	<1323787349.20905.15.camel@chalkhill>	<1323787515.20905.17.camel@chalkhill>	<20111214004429.GE25730@rivendell.middle-earth.co.uk>
	<CAOo=rxUrTwQFQ5LUKOMoQEDq2Fub7N0qNSmqTwaLnyua2Oa9xQ@mail.gmail.com>
Message-ID: <4EE85B55.9000305@oracle.com>

On 12/14/2011 12:00 PM, Sean Chou wrote:
>
> Thanks for the comment! I modified it according to your suggestion. 
> The new
> version is here: 
> http://cr.openjdk.java.net/~zhouyx/OJDK-167/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ezhouyx/OJDK-167/webrev.00/>
>
> So will any oracle guy help create a bug and push it or give some 
> additional
> comments so I can enhance the patch ?

  I looked at the issue 7119285  Make OSInfo recognize AIX platform
  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7119285

   It was reported 6 days ago and it seems it needs some time that the 
issue has been propagated to the open bug system and becomes visible 
after it was submitted:
    "Some bugs don't show up in the database for some time because of 
delays in processing."


  Thanks,
  Alexandr.

>
>
> On Wed, Dec 14, 2011 at 8:44 AM, Dr Andrew John Hughes 
> <ahughes at redhat.com <mailto:ahughes at redhat.com>> wrote:
>
>     On 14:45 Tue 13 Dec     , Neil Richards wrote:
>     > On Tue, 2011-12-13 at 14:42 +0000, Neil Richards wrote:
>     > > On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote:
>     > > > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards
>     > > > <neil.richards at ngmr.net <mailto:neil.richards at ngmr.net>> wrote:
>     > > >         On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
>     > > > > Hi,
>     > > > >
>     > > > >
>     > > > >    I'm not sure what to do for it next, shall I create a bug
>     > > >         for it
>     > > > > now ? But I
>     > > > > don't think the bug system support AIX platform. I
>     > > >         remembered it
>     > > > > would
>     > > > > report something like "we are not supporting the platform".
>     > > > >
>     > > >
>     > > >
>     > > >         Hi Sean,
>     > > >         Looking at the options available on the Java bug
>     submission
>     > > >         site [1], it
>     > > >         looks like:
>     > > >                Release:           OpenJDK
>     > > >                Operating System:  Generic / Other
>     > > >
>     > > >         would be the most appropriate choices to make.
>     > > >
>     > > >         Regards,
>     > > >         Neil
>     > > >
>     > > >
>     > > >         --
>     > > >         Unless stated above:
>     > > >         IBM email: neil_richards at uk.ibm.com
>     <http://uk.ibm.com>
>     > > >         IBM United Kingdom Limited - Registered in England
>     and Wales
>     > > >         with number 741598.
>     > > >         Registered office: PO Box 41, North Harbour, Portsmouth,
>     > > >         Hampshire PO6 3AU
>     > >
>     > > > I tried once, and it was dropped because "the platform is not
>     > > > supported."
>     > > >
>     > > > --
>     > > > Best Regards,
>     > > > Sean Chou
>     > > >
>     > >
>     > > Hmm, in that case, perhaps someone from Oracle can help in
>     creating a
>     > > suitable Java bug id under which this change can be made?
>     > >
>     > > >From the OpenJDK census [1], I see that both Mario and I are
>     currently
>     > > "committers" in the jdk8 project.
>     > >
>     > > As jdk8 is under review control, I believe you'll need some
>     affirmation
>     > > from someone who is a "reviewer".
>     > >
>     > > Such a person is currently likely to be from Oracle, and so
>     may be able
>     > > to help in creating the associated bug id.
>     > >
>     > > Hope this helps.
>     > >
>     > > Regards,
>     > > Neil
>     > >
>     >
>     > Oops, forgot to give the trailed link to the OpenJDK census.
>     >
>     > Regards, Neil
>     >
>     > [1] http://openjdk.java.net/census
>     >
>     > --
>     > Unless stated above:
>     > IBM email: neil_richards at uk.ibm.com <http://uk.ibm.com>
>     > IBM United Kingdom Limited - Registered in England and Wales
>     with number 741598.
>     > Registered office: PO Box 41, North Harbour, Portsmouth,
>     Hampshire PO6 3AU
>     >
>
>     This seems to have dragged on an unduly long time for such a
>     simple patch.
>
>     The patch looks good to me.  The only minor point I'd make is that the
>     comment '// determine another OS here' should probably be under
>     where the
>     AIX if block is added, not above it.
>
>     According to the census, I have jdk8 reviewer status so this
>     should count
>     as a review.  However, as we're still stuck with the antiquated
>     bug system
>     at present, we still need someone at Oracle to give it a bug ID.
>
>     So if an Oracle employee would be so kind as to do so, this can
>     finally be pushed.  It's only about two months old...
>     --
>     Andrew :)
>
>     Free Java Software Engineer
>     Red Hat, Inc. (http://www.redhat.com)
>
>     PGP Key: 248BDC07 (https://keys.indymedia.org/)
>     Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
>
>
>
>
> -- 
> Best Regards,
> Sean Chou
>



From zhouyx at linux.vnet.ibm.com  Wed Dec 14 08:24:57 2011
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Wed, 14 Dec 2011 16:24:57 +0800
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <4EE85B55.9000305@oracle.com>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
	<1323689619.20905.3.camel@chalkhill>
	<CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>
	<1323787349.20905.15.camel@chalkhill>
	<1323787515.20905.17.camel@chalkhill>
	<20111214004429.GE25730@rivendell.middle-earth.co.uk>
	<CAOo=rxUrTwQFQ5LUKOMoQEDq2Fub7N0qNSmqTwaLnyua2Oa9xQ@mail.gmail.com>
	<4EE85B55.9000305@oracle.com>
Message-ID: <CAOo=rxVDFVrFhG6ymNjvJ91pM_QY9_0Ltnkq9E_+PMFnmaLgYw@mail.gmail.com>

Yeah, I reported it. I thought it was dropped for "unsupported platform"
because it didn't appear
for several days. And I still can see it now...

So, can the patch contributed with that bug number?


On Wed, Dec 14, 2011 at 4:16 PM, Alexander Scherbatiy <
alexandr.scherbatiy at oracle.com> wrote:

> On 12/14/2011 12:00 PM, Sean Chou wrote:
>
>>
>> Thanks for the comment! I modified it according to your suggestion. The
>> new
>> version is here: http://cr.openjdk.java.net/~**zhouyx/OJDK-167/webrev.00/<http://cr.openjdk.java.net/~zhouyx/OJDK-167/webrev.00/><
>> http://cr.openjdk.java.net/%**7Ezhouyx/OJDK-167/webrev.00/<http://cr.openjdk.java.net/%7Ezhouyx/OJDK-167/webrev.00/>
>> >
>>
>>
>> So will any oracle guy help create a bug and push it or give some
>> additional
>> comments so I can enhance the patch ?
>>
>
>  I looked at the issue 7119285  Make OSInfo recognize AIX platform
>  http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7119285<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7119285>
>
>  It was reported 6 days ago and it seems it needs some time that the issue
> has been propagated to the open bug system and becomes visible after it was
> submitted:
>   "Some bugs don't show up in the database for some time because of delays
> in processing."
>
>
>  Thanks,
>  Alexandr.
>
>
>>
>> On Wed, Dec 14, 2011 at 8:44 AM, Dr Andrew John Hughes <
>> ahughes at redhat.com <mailto:ahughes at redhat.com>> wrote:
>>
>>    On 14:45 Tue 13 Dec     , Neil Richards wrote:
>>    > On Tue, 2011-12-13 at 14:42 +0000, Neil Richards wrote:
>>    > > On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote:
>>    > > > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards
>>    > > > <neil.richards at ngmr.net <mailto:neil.richards at ngmr.net**>>
>> wrote:
>>    > > >         On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
>>    > > > > Hi,
>>    > > > >
>>    > > > >
>>    > > > >    I'm not sure what to do for it next, shall I create a bug
>>    > > >         for it
>>    > > > > now ? But I
>>    > > > > don't think the bug system support AIX platform. I
>>    > > >         remembered it
>>    > > > > would
>>    > > > > report something like "we are not supporting the platform".
>>    > > > >
>>    > > >
>>    > > >
>>    > > >         Hi Sean,
>>    > > >         Looking at the options available on the Java bug
>>    submission
>>    > > >         site [1], it
>>    > > >         looks like:
>>    > > >                Release:           OpenJDK
>>    > > >                Operating System:  Generic / Other
>>    > > >
>>    > > >         would be the most appropriate choices to make.
>>    > > >
>>    > > >         Regards,
>>    > > >         Neil
>>    > > >
>>    > > >
>>    > > >         --
>>    > > >         Unless stated above:
>>    > > >         IBM email: neil_richards at uk.ibm.com
>>    <http://uk.ibm.com>
>>
>>    > > >         IBM United Kingdom Limited - Registered in England
>>    and Wales
>>    > > >         with number 741598.
>>    > > >         Registered office: PO Box 41, North Harbour, Portsmouth,
>>    > > >         Hampshire PO6 3AU
>>    > >
>>    > > > I tried once, and it was dropped because "the platform is not
>>    > > > supported."
>>    > > >
>>    > > > --
>>    > > > Best Regards,
>>    > > > Sean Chou
>>    > > >
>>    > >
>>    > > Hmm, in that case, perhaps someone from Oracle can help in
>>    creating a
>>    > > suitable Java bug id under which this change can be made?
>>    > >
>>    > > >From the OpenJDK census [1], I see that both Mario and I are
>>    currently
>>    > > "committers" in the jdk8 project.
>>    > >
>>    > > As jdk8 is under review control, I believe you'll need some
>>    affirmation
>>    > > from someone who is a "reviewer".
>>    > >
>>    > > Such a person is currently likely to be from Oracle, and so
>>    may be able
>>    > > to help in creating the associated bug id.
>>    > >
>>    > > Hope this helps.
>>    > >
>>    > > Regards,
>>    > > Neil
>>    > >
>>    >
>>    > Oops, forgot to give the trailed link to the OpenJDK census.
>>    >
>>    > Regards, Neil
>>    >
>>    > [1] http://openjdk.java.net/census
>>    >
>>    > --
>>    > Unless stated above:
>>    > IBM email: neil_richards at uk.ibm.com <http://uk.ibm.com>
>>
>>    > IBM United Kingdom Limited - Registered in England and Wales
>>    with number 741598.
>>    > Registered office: PO Box 41, North Harbour, Portsmouth,
>>    Hampshire PO6 3AU
>>    >
>>
>>    This seems to have dragged on an unduly long time for such a
>>    simple patch.
>>
>>    The patch looks good to me.  The only minor point I'd make is that the
>>    comment '// determine another OS here' should probably be under
>>    where the
>>    AIX if block is added, not above it.
>>
>>    According to the census, I have jdk8 reviewer status so this
>>    should count
>>    as a review.  However, as we're still stuck with the antiquated
>>    bug system
>>    at present, we still need someone at Oracle to give it a bug ID.
>>
>>    So if an Oracle employee would be so kind as to do so, this can
>>    finally be pushed.  It's only about two months old...
>>    --
>>    Andrew :)
>>
>>    Free Java Software Engineer
>>    Red Hat, Inc. (http://www.redhat.com)
>>
>>    PGP Key: 248BDC07 (https://keys.indymedia.org/)
>>    Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
>>
>>
>>
>>
>> --
>> Best Regards,
>> Sean Chou
>>
>>
>


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111214/528126d8/attachment.html>

From ahughes at redhat.com  Wed Dec 14 14:15:24 2011
From: ahughes at redhat.com (Dr Andrew John Hughes)
Date: Wed, 14 Dec 2011 14:15:24 +0000
Subject: <Swing Dev> Add Look&Feel support for AIX platform
In-Reply-To: <4EE85B55.9000305@oracle.com>
References: <4ed43de2.4713cc0a.2daf.1d8d@mx.google.com>
	<CAOo=rxUtkEjtkcQFBTx2kVj3aiz8x49D+EwLCYREGFV4NzEuvA@mail.gmail.com>
	<1323689619.20905.3.camel@chalkhill>
	<CAOo=rxXNagfO5dMk2TU_eODmYBstyYq8gHtF44dhwVg4a3-WPQ@mail.gmail.com>
	<1323787349.20905.15.camel@chalkhill>
	<1323787515.20905.17.camel@chalkhill>
	<20111214004429.GE25730@rivendell.middle-earth.co.uk>
	<CAOo=rxUrTwQFQ5LUKOMoQEDq2Fub7N0qNSmqTwaLnyua2Oa9xQ@mail.gmail.com>
	<4EE85B55.9000305@oracle.com>
Message-ID: <20111214141524.GB10815@rivendell.middle-earth.co.uk>

On 12:16 Wed 14 Dec     , Alexander Scherbatiy wrote:
> On 12/14/2011 12:00 PM, Sean Chou wrote:
> >
> > Thanks for the comment! I modified it according to your suggestion. 
> > The new
> > version is here: 
> > http://cr.openjdk.java.net/~zhouyx/OJDK-167/webrev.00/ 
> > <http://cr.openjdk.java.net/%7Ezhouyx/OJDK-167/webrev.00/>
> >
> > So will any oracle guy help create a bug and push it or give some 
> > additional
> > comments so I can enhance the patch ?
> 
>   I looked at the issue 7119285  Make OSInfo recognize AIX platform
>   http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7119285
> 
>    It was reported 6 days ago and it seems it needs some time that the 
> issue has been propagated to the open bug system and becomes visible 
> after it was submitted:
>     "Some bugs don't show up in the database for some time because of 
> delays in processing."
> 

This is why I usually let someone at Oracle do it.  They seem to be able
to add them in a few minutes.  That's really the only acceptable solution
until we get a bug system that treats everyone equally.

> 
>   Thanks,
>   Alexandr.
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111214/0f6857d0/signature.asc>

From mgradhikaa at yahoo.com  Wed Dec 14 10:25:38 2011
From: mgradhikaa at yahoo.com (Radhika M.G)
Date: Wed, 14 Dec 2011 15:55:38 +0530 (IST)
Subject: <Swing Dev> Translating JFileChooser as per the logged in language
Message-ID: <1323858338.39527.YahooMailNeo@web94713.mail.in2.yahoo.com>

Hello All,
?
We are developing an application in which the user can login in different languages. 
We are using JFileChooser in the application. I find that the JFileChooser is displayed in the language of the locale than the logged in language. 
Is there a way to change the UI properties of JFileChooser as per the logged in language even though the locale is same? 
Please let me know. 
?
Thanks in advance. 
?
Regards,
Radhika
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111214/9968d988/attachment.html>

From alexandr.scherbatiy at oracle.com  Thu Dec 15 12:17:48 2011
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 15 Dec 2011 16:17:48 +0400
Subject: <Swing Dev> [8] Review request for 6505523: NullPointerException in
 BasicTreeUI when a node is removed by expansion listener
Message-ID: <4EE9E56C.8010406@oracle.com>

Hello,

Could you review the fix for the issue:
6505523 NullPointerException in BasicTreeUI when a node is removed by 
expansion listener
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6505523

The webrev is http://cr.openjdk.java.net/~alexsch/6505523/webrev.00

The fix checks that the path bounds do not become null for the 
isActualPath() method between actions: mouse pressed, tree node deleted, 
mouse released.

The bounds are also checked in the ensureRowsAreVisible() method in the 
same way as it fixed for the issue
4909150 WindowsTreeUI can cause NullPointerException occasionally
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4909150

Thanks,
Alexandr.




From zhouyx at linux.vnet.ibm.com  Thu Dec 22 07:04:13 2011
From: zhouyx at linux.vnet.ibm.com (Sean Chou)
Date: Thu, 22 Dec 2011 15:04:13 +0800
Subject: <Swing Dev> Focus on image icons are not visible in javaws
 cache with high contrast mode
In-Reply-To: <4ECD3A38.9040406@oracle.com>
References: <4e647dc3.82cde30a.3537.5eed@mx.google.com>
	<CAOo=rxWpsDbsS3GVaH8shVfu3NKr1gu2VRSOgmOgutQffWnxTQ@mail.gmail.com>
	<4E6A13ED.200@oracle.com>
	<CAOo=rxXAttuk+_dV9U39cjXtAt9XkGo3Pec9pJv2BE0NcCL=jQ@mail.gmail.com>
	<1316086740.27737.52.camel@chalkhill> <4E71F7D4.6000704@oracle.com>
	<1316098057.27737.111.camel@chalkhill>
	<4E732DB1.6070804@oracle.com>
	<CAOo=rxV3iW-2CM=NfOE9R+6fQm4P5jvCiJv77Ve_52aTRPDucQ@mail.gmail.com>
	<4EA8237B.4020407@oracle.com>
	<CAOo=rxUw_JTkttdKUfUMcZsKhU_4JOJH5X96tm55tEySiJFi4A@mail.gmail.com>
	<4EABFC41.7040504@oracle.com>
	<CAOo=rxUAckkHQCEFK8y5foZ6hgzgw5c7+S-kj066n2DuE9FjSg@mail.gmail.com>
	<4ECD3A38.9040406@oracle.com>
Message-ID: <CAOo=rxVirN=zSaRdt+ccn10K46o9TZU5PjF=wH==s0NV=H9Bhw@mail.gmail.com>

Hi Pavel,

    I made another patch, and it is uploaded to
http://cr.openjdk.java.net/~zhouyx/7089914/webrev.01/  .

    The button.focus is now similar to a windows property, it will
be loaded when other windows properties are loaded; and it
stays in the same priority as other windows properties so user
defined value won't be overwritten.

   And I also found a bug in WindowsRadioButtonUI which
blocks radiobutton and checkbox from reloading their styles,
its fix(override the uninstallDefaults ) is included in the webrev
as well.

A simple testcase which includes checkbox and radiobutton
is here:

/////////////////////////////

import java.awt.BorderLayout;
import java.awt.EventQueue;

import javax.swing.ImageIcon;
import javax.swing.JButton;
import javax.swing.JCheckBox;
import javax.swing.JFrame;
import javax.swing.JRadioButton;
import javax.swing.JToolBar;
import javax.swing.UIManager;
import javax.swing.UnsupportedLookAndFeelException;


public class TestButton {

    private JFrame frame;

    /**
     * Launch the application.
     */
    public static void main(String[] args) {

        try {

UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
        } catch (ClassNotFoundException | InstantiationException
                | IllegalAccessException | UnsupportedLookAndFeelException
e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }

        EventQueue.invokeLater(new Runnable() {
            public void run() {
                try {
                    TestButton window = new TestButton();
                    window.frame.setVisible(true);
                } catch (Exception e) {
                    e.printStackTrace();
                }
            }
        });
    }

    /**
     * Create the application.
     */
    public TestButton() {
        initialize();
    }

    /**
     * Initialize the contents of the frame.
     */
    private void initialize() {
        frame = new JFrame();
        frame.setBounds(100, 100, 450, 300);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

        JToolBar toolBar = new JToolBar();
        frame.getContentPane().add(toolBar, BorderLayout.NORTH);

        JButton btnNewButton = new JButton(new ImageIcon("testicon.png"));
        toolBar.add(btnNewButton);

        JButton btnNewButton_1 = new JButton("New button");
        frame.getContentPane().add(btnNewButton_1, BorderLayout.CENTER);

        JCheckBox chckbxNewCheckBox = new JCheckBox("New check box");
        frame.getContentPane().add(chckbxNewCheckBox, BorderLayout.WEST);

        JRadioButton rdbtnNewRadioButton = new JRadioButton("New radio
button");
        frame.getContentPane().add(rdbtnNewRadioButton, BorderLayout.EAST);
    }
}

////////////////////////////////



On Thu, Nov 24, 2011 at 2:23 AM, Pavel Porvatov
<pavel.porvatov at oracle.com>wrote:

>  Hi Sean,
>
> Hi Pavel,
>
>     I rewrite a testcase, which is attached as TestButton.java . It has a
> toolbar and two buttons,
> one in toolbar and the other in contentpane. The one in toolbar use an
> image which is
> attached as testicon.png .  I don't know how to write an automatic
> testcase for this one
>  because it changes windows settings.
>
> Sometimes it's really hard to write automatic test. In your case SwingSet2
> demo and an appropriate instruction for testers is enough...
>
>
>    Just run TestButton and change windows to high contrast mode and you
> can find the focus
> is not painted.
>
>    I attached the patch in webrev.zip.  It just checks if button
> background is black when
> windows properties changed. Please have a look.
>
> It seems your fix adds the following regression:
> somebody can install own "Button.focus" value, but your code puts own
> value over the users one
>
> Regards, Pavel
>
>
>
>  On Sat, Oct 29, 2011 at 9:14 PM, Pavel Porvatov <
> pavel.porvatov at oracle.com> wrote:
>
>>  Hi Sean,
>>
>>
>>
>>     It seems the black color for focus is set intentionally. If we set it
>> to "ControlTextColor ",
>> the focus color may become red in above testcase, that's not what we want.
>>     And I changed the color for all items listed with "3D object", the
>> focus remains black;
>> maybe windows just uses "black" for focus color in normal mode, and
>> another color for
>> high contrast mode.
>>
>>     However, the original patch posted is not right in this scenario.
>> I'll modify it. How about
>> just uses white for high contrast mode ? As it simply uses black for
>> normal mode.
>>
>>  I'm not sure you can determine if high contrast mode is set... Every
>> heuristic function for selection color can fail in some situation.
>>
>> If somebody can take a look at source of
>> ControlPaint::DrawFocusRectangle(Graphics, Rectangle) method (see
>> http://msdn.microsoft.com/en-us/library/k2czzc46.aspx) and find out
>> which colors uses .NET....
>>
>> Regards, Pavel
>>
>>
>> On Wed, Oct 26, 2011 at 11:12 PM, Pavel Porvatov <
>> pavel.porvatov at oracle.com> wrote:
>>
>>>   Hi Sean,
>>>
>>> Hi Pavel,
>>>
>>>      From your image, I agree the focus color is not always the same
>>> with ControlTextColor,
>>> but I cannot recreate it. When I changed  color of "3D objects" to red,
>>> I got another image.
>>> Please have a look.
>>>
>>>  It seems you changed Color1, but not Color (which a little bit lower
>>> then Color1)....
>>>
>>>     I think your suggestion is reasonable, we'd better use the focus
>>> color from windows, but
>>> it maybe a problem to keep 100% the same, I still not found if there is
>>> a document for the
>>> focus color.
>>>
>>>  Yes, the MS documentation about focus color is the best way to fix the
>>> bug. Can anybody point to such document?
>>>
>>> Regards, Pavel
>>>
>>>
>>> On Fri, Sep 16, 2011 at 7:06 PM, Pavel Porvatov <
>>> pavel.porvatov at oracle.com> wrote:
>>>
>>>> Hi Neil,
>>>>
>>>>  On Thu, 2011-09-15 at 17:04 +0400, Pavel Porvatov wrote:
>>>>>
>>>>>> Hi Neil,
>>>>>>
>>>>>>> On Wed, 2011-09-14 at 14:14 +0800, Sean Chou wrote:
>>>>>>>
>>>>>>>> Hi Pavel,
>>>>>>>>
>>>>>>>>
>>>>>>>>     I reported a bug there yesterday,
>>>>>>>>     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7089914
>>>>>>>>     So far, I'm not sure if Windows use ControlTextColor, I'll check
>>>>>>>> it.
>>>>>>>>
>>>>>>>>  For ease of review, I've uploaded Sean's change as a webrev [1].
>>>>>>>
>>>>>>> With the change, I see the following focus-related color settings in
>>>>>>> the
>>>>>>> WindowsLookAndFeel:
>>>>>>>
>>>>>>> Button.focus:           ControlTextColor
>>>>>>> Checkbox.focus:         ControlTextColor
>>>>>>> RadioButton.focus:      ControlTextColor
>>>>>>> Slider.focus:           ControlDarkShadowColor
>>>>>>> TabbedPane.focus:       ControlTextColor
>>>>>>> ToggleButton.focus:     ControlTextColor
>>>>>>>
>>>>>>> So the change of setting for Button, Checkbox and RadioButton
>>>>>>> conforms
>>>>>>> to what is already used for TabbedPane and ToggleButton.
>>>>>>>
>>>>>> But doesn't conform to Slider.focus...
>>>>>>
>>>>> Are you recommending that Slider.focus should be changed to
>>>>> ControlTextColor too ?
>>>>>
>>>>  No, I meant that we cannot fix some bugs by copy-paste method.
>>>>
>>>>>    From it's name, it's not entirely obvious to me that
>>>>>>>> 'ControlTextColor'
>>>>>>>>
>>>>>>> is really the ideal setting to use here, but it's also clear that
>>>>>>> it's a
>>>>>>> far better setting to use than the current hard-coded 'black'.
>>>>>>>
>>>>>> Yes, of course. The last question is which color is correct. We can't
>>>>>> change one incorrect color to another incorrect color...
>>>>>>
>>>>> I guess I hope that some knowledgeable person might be able to suggest
>>>>> /
>>>>> corroborate / refute the choice of setting here.
>>>>>
>>>>> It seems worse to consider sticking with a hard-coded, un-configurable
>>>>> value that has been demonstrated to cause problems, than to use a
>>>>> setting whose value can at least be configured, in practice fixes the
>>>>> problem's symptoms, and is already used in most other similar contexts
>>>>>  within the same look&  feel.
>>>>>
>>>>>
>>>>> Suggestions for how to improve things further are always welcome.
>>>>>
>>>> Your points sounds good. But as I said: we can't change one incorrect
>>>> color to another incorrect color (doesn't matter configurable it or not). I
>>>> attached  the screenshot that shows that ControlTextColor is not always
>>>> equal to color of selection frame (to reproduce this image press the
>>>> Advanced button and change color of "3D objects" to red).
>>>>
>>>> Regards, Pavel
>>>>
>>>
>>>
>>>
>>>  --
>>> Best Regards,
>>> Sean Chou
>>>
>>>
>>>
>>
>>
>>  --
>> Best Regards,
>> Sean Chou
>>
>>
>>
>
>
>  --
> Best Regards,
> Sean Chou
>
>
>


-- 
Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111222/8d137503/attachment.html>

From sanjayacl at gmail.com  Thu Dec 29 19:25:45 2011
From: sanjayacl at gmail.com (Sanjaya Liyanage)
Date: Fri, 30 Dec 2011 00:55:45 +0530
Subject: <Swing Dev> How to add start and end time values
Message-ID: <CAK94idv-Nm4QbEE1_ePRAU09j=-WA2Qmr4V_cdUwcRLXCNqGqQ@mail.gmail.com>

Hi all,
   I want to keep two spinners in my UI which displays only the
time.(example 13:30) not the time with date.I also want to make the
1st spinner available for selecting any time value between 00:00 to
23:59.But I want to restrict the spinner 2 in such a way that only
time values after the selected value of first time spinner will be
allowed to select.
As example if I select 14:00 in spinner1 then I want to select the
time of spinner2 which is after 14:00 before 23:59.How can I restrict
spinner2.What kind of spinner should I use?
Any help please
Thank you
Sanjaya


From i30817 at gmail.com  Fri Dec 30 08:12:23 2011
From: i30817 at gmail.com (Paulo Levi)
Date: Fri, 30 Dec 2011 08:12:23 +0000
Subject: <Swing Dev> Interesting GNOME 3 bug
Message-ID: <CAO02FZJkb1kvpwpU43rvfRFr1LaeqabOEr7W=h+ZEPtt5YK01Q@mail.gmail.com>

GNOME 3 activities tab is always accessible by hovering the upper left
corner. If you go into full screen mode with a java app such as netbeans
(firefox works too - i believe since it is a "foreign" toolkit) you'll find
that the window is still "rounded" even if you have no decorations anymore,
which is quite nice because you can access the activities tab with the
mouse and not have to go out of fullscreen or alt+tab to another app.

This doesn't happen with native applications put into fullscreen (such as
gnome terminal). Those are always square in fullscreen.

Unfortunatly it doesn't appear to work if you never were decorated (my app,
when deserializing).

Nevertheless, this is the first time i encounter a UI bug that actually
enhances usability.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111230/522c0bb7/attachment.html>

From i30817 at gmail.com  Fri Dec 30 08:16:51 2011
From: i30817 at gmail.com (Paulo Levi)
Date: Fri, 30 Dec 2011 08:16:51 +0000
Subject: <Swing Dev> Interesting GNOME 3 bug
In-Reply-To: <CAO02FZJkb1kvpwpU43rvfRFr1LaeqabOEr7W=h+ZEPtt5YK01Q@mail.gmail.com>
References: <CAO02FZJkb1kvpwpU43rvfRFr1LaeqabOEr7W=h+ZEPtt5YK01Q@mail.gmail.com>
Message-ID: <CAO02FZ+AnJFxmhjpeyX9=X8hhY_WbHypy9QXxC+suF6fXBs8vg@mail.gmail.com>

Correction: firefox doesn't have the "bug" either.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111230/e1c7c3d9/attachment.html>

From i30817 at gmail.com  Fri Dec 30 09:59:09 2011
From: i30817 at gmail.com (Paulo Levi)
Date: Fri, 30 Dec 2011 09:59:09 +0000
Subject: <Swing Dev> Interesting GNOME 3 bug
In-Reply-To: <CAO02FZ+AnJFxmhjpeyX9=X8hhY_WbHypy9QXxC+suF6fXBs8vg@mail.gmail.com>
References: <CAO02FZJkb1kvpwpU43rvfRFr1LaeqabOEr7W=h+ZEPtt5YK01Q@mail.gmail.com>
	<CAO02FZ+AnJFxmhjpeyX9=X8hhY_WbHypy9QXxC+suF6fXBs8vg@mail.gmail.com>
Message-ID: <CAO02FZLixtNegDtF-AHoY_ZVqAZi_V7Z_PhjXTXwtWccvu0oyw@mail.gmail.com>

Also, just noticed, fullscreen mode is broken on gnome:

Open netbeans. Try to open a modal dialog.
Observe the z-failure.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20111230/b07aa6f7/attachment.html>