<Swing Dev> When running with the Nimbus look and feel, the JFileChooser does not display mnemonics for its controls.

[Pavel Porvatov]

Hi Charles,
> On 07/29/2011 04:34 PM, Pavel Porvatov wrote:
>> Hi Charles,
>>> On 07/27/2011 06:44 PM, Pavel Porvatov wrote:
>>>> Hi Charles,
>>>>
>>>> I attached your patch to the CR. Not sure I'll have time to test 
>>>> and commit the fix.
>>>>
>>>> Regards, Pavel
>>>>
>>>>> On 03/30/2011 07:43 PM, Pavel Porvatov wrote:
>>>>>> Hi Charles,
>>>>>>> Hi guys,
>>>>>>>
>>>>>>> When running with Nimbus LaF, JFileChooser does not display 
>>>>>>> mnemonics for its controls, see FileNameAndTypeNomnemonics.png 
>>>>>>> (attached)
>>>>>>> After patch (attached)
>>>>>>> You will find FileNameAndTypeWithMnemonics.png (attached)
>>>>>>>
>>>>>> I filed CR 7032436 (When running with the Nimbus look and feel, 
>>>>>> the JFileChooser does not display mnemonics) for the described 
>>>>>> problem
>>>>>>
>>>>>> Thanks, Pavel
>>>>> Hi guys,
>>>>>
>>>>> I have tested this issue on the openjdk 8 and it still there. 
>>>>> Attached is a patch which rebased on the openjdk8.
>>>>>
>>>>> Would anyone like to put this patch into the openjdk8 and fix this 
>>>>> issue?
>>>>>
>>>>
>>> Thanks Pavel.
>>>
>>> Does anyone else have time to take a look at this issue? I will 
>>> treat him one beer :-)
>>>
>> Oops, then I'll take participation in this =)
>>
>> Seriously, there are several comments to your fix:
>>
>> 1. You changed windows.properties and metal.properties, but you 
>> shouldn't do this (e.g. because of CR description "When running with 
>> the Nimbus look and feel, the JFileChooser does not display 
>> mnemonics"). If you take a look at current JFileChooser you will see 
>> that mnemonics are exist... That's because of CR 7024118 (possible 
>> hardcoded mnemonic for JFileChooser metal and motif l&f) and it will 
>> be great if you fix this also after CR 7032436. Your current 
>> implementation for Win/Metal LAFs is uncompleted actually...
>>
>> 2. You should COPY new mnemonics into all synth properties like 
>> synth_de.properties etc... Our i18n team will update them later.
>>
>> 3. To be consistent with other LAFs could you use something like 
>> "lookInLabelMnemonic = 
>> UIManager.getInt("FileChooser.lookInLabelMnemonic");" (like in 
>> Metal/Windows)? That means also that you should use VK_XXX codes 
>> instead of chars in properties files
>>
>> 4. Could you please use something like "hg diff -g" for patch 
>> creating (see http://openjdk.org/contribute/ for details). I have 
>> some problems with your patch format.
>>
>> Thanks, Pavel
> Hi Pavel,
>
> Would you please tell me which repository you see the mnemonics are 
> exist? openjdk7, openjdk8? openjdk8_tl? openjdk8_2d? openjdk8_*?
All described above. Mnemonics are hardcoded, see 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024118 for details. 
Just run JFileChooserDemo or SwingSet2 demo and you will see that 
mnemonics are exist.
> The patch issue maybe related to the different repo you and me are 
> using. I am using git to clone the openjdk8 repo and patch apply well 
> with patch command.
Ok, I found the command that works with your patch format...
>
> I will try to refine the patch according to your comments.
>
> Thanks for quick response :-)
>
You are welcome

Regards, Pavel