<Swing Dev> Request for review: 5088532 : JFileChooser: Focus missing in NewFolder after CreateNewFolder button is clicked

Pavel Porvatov pavel.porvatov at oracle.com
Thu Mar 3 16:42:00 UTC 2011


Hi Lakshmi,
>
> Hi,
>
> I've contributed the below change to fix this long standing issue with 
> JFileChooser not able to focus on the right component under certain 
> conditions. Please review
>
Thanks for the fix. It looks good but I have a couple comments about it:
1. I'd rather use the requestFocusInWindow method instead of the 
requestFocus method (see javadoc for details)
2. I'm not sure we need such detailed comment for an obvious new block 
of code

Would you like I commit the fix with small changes and do other staff 
according to our bug-fixing procedure (with the specifying you as a 
contributor of the fix of course)?

Regards, Pavel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20110303/269d6e5d/attachment.html>


More information about the swing-dev mailing list