<Swing Dev> Fix the hard coded mnemonic keys for JFileChooser in metal and motif LaF

Charles Lee littlee at linux.vnet.ibm.com
Mon Sep 12 06:27:34 UTC 2011


On 09/09/2011 09:55 PM, Pavel Porvatov wrote:
> Hi Charles,
>> On 09/08/2011 04:46 AM, Pavel Porvatov wrote:
>>> Hi Charles,
>>>> Hi Pavel,
>>>>
>>>> This is patch for sunbug 7024118. Would you please review it :-)
>>>>
>>>>
>>> Your fix looks really good! I have a couple comments:
>>>
>>> 1. You are still using TAB characters. Stop it, please...
>>> 2. Would you like to fix WindowsLookAndFeel as well?
>>>
>>> Regards, Pavel
>>>
>> 1. I have reconfigure my emacs. Does it look better ?
>> 2. Here you go (attached)
>>
>>
> The fix look great!. I've committed the fix:
>
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fbc8d86c477
>
> Thanks, Pavel
wow. Thanks Pavel.

-- 
Yours Charles




More information about the swing-dev mailing list