<Swing Dev> Review request for 7146146: Deadlock between subclass of AbstractDocument and UndoManager

[Artem Ananiev]

Hi, Pavel,

the fix looks fine, except code formatting: some of the added/changed 
lines are too long, which makes the code less readable.

Thanks,

Artem

On 4/5/2012 7:59 PM, Pavel Porvatov wrote:
> Hi,
>
> This is a review request for CR 7146146
>
> Bug description: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146146
> Webrev: http://cr.openjdk.java.net/~rupashka/7146146/webrev.0/
>
> Evaluation of the problem:
> We should do any notifications outside of internal locks. The solution
> is to correct AbstractDocument#insertString method and move
> fireInsertUpdate and fireUndoableEditUpdate invocations from
> writeLock/writeUnlock block
>
> Regards, Pavel