<Swing Dev> Reviewer needed: fix for TitledBorder class

Pavel Tisnovsky ptisnovs at redhat.com
Fri Apr 27 14:44:49 UTC 2012


Alexander Scherbatiy wrote:
> 
>   Hi  Pavel,
> 
>   Thank you for the bug investigation.

Hi Alexander,

thank you for your answer!

> 
>   Could you create an issue on it?

well I'm not sure what exactly you mean.
To file a new bug or something like this?
(I did not do it yet - somebody else ever created a bug #id for me ;-)

>   Could you also check that the issue 4129681 is not reproduced with
> your fix? At least try to run the
> test/javax/swing/border/Test4129681.java test.

this test and other swing tests don't seem to be affected by the fix.

> 
>   Thanks,
>   Alexandr.
> 
> 
> 
> On 4/27/2012 1:14 PM, Pavel Tisnovsky wrote:
>> Hi,
>>
>> I think there's a bug in a TitledBorder class. According to JavaDoc
>> the methods getTitleColor() and getTitleFont() should use look&feel
>> settings when nothing is explicitly changed by constructor/setters:
>>
>> <javadoc>
>> If the border, font, or color property values are not specified in the
>> constuctor or by invoking the appropriate set
>> methods, the property values will be defined by the current look and
>> feel, using the following property names in the
>> Defaults Table:
>> "TitledBorder.border"
>> "TitledBorder.font"
>> "TitledBorder.titleColor"
>> </javadoc>
>>
>> This behaviour were removed by following changeset:
>> changeset:   2529:d062afbe2107
>> user:        malenkov
>> date:        Thu Jul 01 18:09:45 2010 +0400
>> summary:     4129681: Cannot get a title border to display its label
>> as disabled
>>
>>
>> Here is a webrew which contains fix for this issue:
>> http://cr.openjdk.java.net/~ptisnovs/TitledBorder/
>>
>> Can anybody please review this fix?
>> (I'd like to push the same change to OpenJDK7 too it it will be
>> reviewed&  accepted)
>>
>> Thank you in advance,
>> Pavel Tisnovsky
> 




More information about the swing-dev mailing list