<Swing Dev> [8] Review request for 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file

Pavel Porvatov pavel.porvatov at oracle.com
Fri Apr 27 15:12:56 UTC 2012


Hi Alexander,

That's a bad practice to use "catch (Throwable e)" and we should avoid 
that. There are a lot reasons, here is one of them:
http://www.javatuning.com/why-catch-throwable-is-evil-real-life-story/

Why can't we inline all nonlocalizable strings? After that the 
"tokenize" method can be removed, I believe...

Regards, Pavel
> Hello,
>
> This is a request to review the fix for the issue:
> 7024963 Notepad demo: remove non-translatable resources from 
> Notepad.properties file
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024963
>
> The webrev is http://cr.openjdk.java.net/~alexsch/7024963/webrev.00
>
> The non-translatable properties are moved to the file system.properties.
> The getProperty() method is used now instead of the 
> getResourceString() where non-translatable resources are used.
>
>
> Thanks,
> Alexandr.
>




More information about the swing-dev mailing list