<Swing Dev> [8] Review request for 8003978 closed/javax/swing/JRootPane/bug4670486.java fails since jdk7u12b01 on macosx

[Alexander Scherbatiy]

On 12/6/2012 7:15 PM, Sergey Bylokhov wrote:
> Hi, Alexander.
> Does motif l&f work on macosx with META_MASK - MotifLookAndFeel.java:?
      Yes, it does.

    Thanks,
    Alexandr.

>
> 633             "Menu.shortcutKeys", new int[]{
>  634                 SwingUtilities2.getSystemMnemonicKeyMask(),
>  635                 KeyEvent.META_MASK
>  636             },
>
>
> 06.12.2012 19:01, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003978
>> webrev: http://cr.openjdk.java.net/~alexsch/8003978/webrev.00
>>
>>   The test fails because now Alt+U key combination returns right dead 
>> key code instead of the key code for the 'U' key.
>>   The solution is to use Ctrl+Alt key combination for menu mnemonics 
>> like it is done for button mnemonics.
>>
>>   The fix uses SunToolkit getFocusAcceleratorKeyMask() method to get 
>> the system depended mnemonic key mask and puts it to the 
>> Menu.shortcutKeys property in the BasicLookAndFeel.
>>
>> Thanks,
>> Alexandr.
>>
>
>