<Swing Dev> [8] Review request for 7104594 [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default
Konstantin Shefov
konstantin.shefov at oracle.com
Tue Dec 18 07:20:29 UTC 2012
REMINDER
On 28-Nov-12 20:39, Konstantin Shefov wrote:
> Could you please look at this test fix?
> Webrev: http://cr.openjdk.java.net/~kshefov/7104594/webrev.01/
> (already approved by Alexander Scherbatiy)
>
> On 22-Nov-12 18:04, Anthony Petrov wrote:
>> I see. I suggest to request reviews from Swing engineers for Swing
>> tests in this case. E.g. Alexander Scherbatiy could review it better
>> than I.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 11/22/12 17:51, Konstantin Shefov wrote:
>>> It is not the same test indeed.
>>> I forced Look and Feel to be Metal even on MacOS and made Swing methods
>>> run on Event Dispatching Thread.
>>>
>>> On 22-Nov-12 17:48, Anthony Petrov wrote:
>>>> Looks good given it's the same test from closed repos.
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 11/22/12 15:32, Konstantin Shefov wrote:
>>>>> Could you please look at this test fix?
>>>>> Webrev: http://cr.openjdk.java.net/~kshefov/7104594/webrev.01/
>>>>>
>>>>> On 16-Nov-12 17:27, Alexander Scherbatiy wrote:
>>>>>>
>>>>>> The fix looks good for me.
>>>>>>
>>>>>> Thanks,
>>>>>> Alexandr.
>>>>>>
>>>>>> On 11/14/2012 7:39 PM, Konstantin Shefov wrote:
>>>>>>> Could you please look at this test fix?
>>>>>>>
>>>>>>> Webrev: http://cr.openjdk.java.net/~kshefov/7104594/webrev.01/
>>>>>>>
>>>>>>> It was test for Metal LaF, so I forced LaF to be Metal even on
>>>>>>> MacOS.
>>>>>>> Now the test passes on MacOSX.
>>>>>>> I also made Swing methods run on EDT.
>>>>>>> Test can be moved to OpenJDK as it is already in OpenJDK 6.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Konstantin
>>>>>>
More information about the swing-dev
mailing list