<Swing Dev> Fwd: <AWT Dev> Request review for 7129742 : Unable to view focus in Non-Editable TextArea

[Sergey Bylokhov]

Hi Sean,
In the XAWTCaret.super.focusGained(e) we check isEnabled() state of the 
component.
Probably we should do it in the fix too, just to be closer to the old 
version?
The problem applicable for textarea only? What about textfield?

15.02.2012 12:54, Sean Chou wrote:
> Hi all,
>
>    This is a patch for bug 7129742, 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129742 .
>
> Forwarded from awt-dev to swing-dev as it uses swing peer .
> The original discussion is 
> http://mail.openjdk.java.net/pipermail/awt-dev/2012-January/002167.html .
> The patch is at http://cr.openjdk.java.net/~zhouyx/7129742/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ezhouyx/7129742/webrev.01/>  .
>
>    Would any one have a look ? Thanks.
>
>
> ---------- Forwarded message ----------
> From: *Sean Chou* <zhouyx at linux.vnet.ibm.com 
> <mailto:zhouyx at linux.vnet.ibm.com>>
> Date: Mon, Feb 6, 2012 at 5:31 PM
> Subject: Re: <AWT Dev> Request review for 7129742 : Unable to view 
> focus in Non-Editable TextArea
> To: Artem Ananiev <artem.ananiev at oracle.com 
> <mailto:artem.ananiev at oracle.com>>
> Cc: OpenJDK awt-dev <awt-dev at openjdk.java.net 
> <mailto:awt-dev at openjdk.java.net>>, Alexander Potochkin 
> <Alexander.Potochkin at oracle.com 
> <mailto:Alexander.Potochkin at oracle.com>>, Pavel Porvatov 
> <Pavel.Porvatov at oracle.com <mailto:Pavel.Porvatov at oracle.com>>
>
>
> Hi all,
>
>     The testcase is added, the new link is 
> http://cr.openjdk.java.net/~zhouyx/7129742/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ezhouyx/7129742/webrev.01/>  .
> Please review and give your comments.
>
>     When writing the testcase, I found the application would not exit 
> if the caret is set visible. It is
> caused by the timer thread controlling the blinking of the caret. So I 
> set the caret invisible when
> disposing the TextArea.
>
>     More info: The patch is for bug 7129742,
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129742 .
>
>     Thanks.
>
> On Mon, Jan 16, 2012 at 11:56 PM, Artem Ananiev 
> <artem.ananiev at oracle.com <mailto:artem.ananiev at oracle.com>> wrote:
>
>     Hi, Sean,
>
>     text components in XToolkit use Swing peers, so this change should
>     better be reviewed on the swing-dev alias. To save everybody's
>     time, I've asked Alex and Pavel from the Swing team (in CC) to
>     take a look and they confirm the fix looks fine.
>
>     Did you consider creating a new regression test for this fix? I'm
>     not sure it's easy to detect if caret is visible in the text
>     component or not, though.
>
>     Thanks,
>
>     Artem
>
>
>     On 1/16/2012 7:08 AM, Sean Chou wrote:
>
>         Hi all,
>
>            I made a patch for bug 7129742,
>         http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129742 .
>         The webrev link is :
>         http://cr.openjdk.java.net/~zhouyx/7129742/webrev.00/
>         <http://cr.openjdk.java.net/%7Ezhouyx/7129742/webrev.00/>
>
>            The solution is very simple, just set the cursor visible.
>
>            Please have a look and give some comments. Thanks.
>
>         --
>         Best Regards,
>         Sean Chou
>
>
>
>
> -- 
> Best Regards,
> Sean Chou
>
>
>
>
> -- 
> Best Regards,
> Sean Chou
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20120215/c4497288/attachment.html>