<Swing Dev> Request review for 7089914: Focus on image icons are not visible in javaws cache with high contrast mode

[Pavel Porvatov]

Hi Sean,

There are several comments for your patch:

1. I found one bug. In Win 7 there are several differnet High Contrast 
themes. Under one of them ("High Contrast White") focus is not visible...

2. I also don't like synthetic property. Any desktop property has 
listener (see com.sun.java.swing.plaf.windows.DesktopProperty#pcl) and 
updated when correspondent value is changed. But your 
win.button.focusColor property is updated only while full property 
reloading.

3. Please don't add references to bugs in the code. Everybody can trace 
history of the code by VCS.

4. The changes in the class WindowsRadioButtonUI looks good. Is it 
possible to make your TestButton test an automatic one and add it to the 
fix?

Regards, Pavel

> Hi all,
>
>    This is for bug 7089914, 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7089914 .
> OpenJDK uses black as focus color in windows LAF. However, in high 
> contrast mode, windows
> uses white as focus color.
>    In additional, the patch also modified WindowsRadioButtonUI.java so 
> it will reload its style
> when system setting is changed.
>
>    The webrev link is : 
> http://cr.openjdk.java.net/~zhouyx/7089914/webrev.02/ 
> <http://cr.openjdk.java.net/%7Ezhouyx/7089914/webrev.02/>
>
> The previous discussions are:
> http://mail.openjdk.java.net/pipermail/swing-dev/2011-September/001703.html
> http://mail.openjdk.java.net/pipermail/swing-dev/2011-October/001794.html
> http://mail.openjdk.java.net/pipermail/swing-dev/2011-December/001871.html
>
> Any comments on the this version? thanks.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20120116/49c70338/attachment.html>