<Swing Dev> [8] Review request for 7156657 Version 7 doesn't support translucent popup menus against a translucent window

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Thu Jun 7 14:45:10 UTC 2012


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/6/2012 3:08 PM, Pavel Porvatov wrote:
> Hello,
>
> Please review a fix for the following issue:
>   7156657 Version 7 doesn't support translucent popup menus against a 
> translucent window
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156657
>
> The webrev is here: http://cr.openjdk.java.net/~rupashka/7156657/ 
> <http://cr.openjdk.java.net/%7Erupashka/7156657/>
>
> The fix of CR 7027486 (JPopupMenu doesn't take window shape into 
> account, http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9024198193ce) 
> doesn't take into account that some users use translucent windows with 
> translucent menus. After discussions the following decision was made:
> 1. When JPopupMenu#setLightWeightPopupEnabled is set to false 
> HEAVY_WEIGHT popups is used (instead of MEDIUM_WEIGHT). This fix was 
> done in CR 6800513 (GTK-LaF renders menus incompletely, 
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cd00d68e06ac and 
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8800a98316b2) and that 
> allows to use non-translucent and non-clipped popups for translucent 
> or shaped windows
> 2. Fix of CR 7027486 should be reverted
> 3. The TransparentRuler should be corrected according new fix
>
> Regards,
> Pavel.
>




More information about the swing-dev mailing list