<Swing Dev> [8] Review request for 7174970 NLS: [ccjk] Extra mnemonic keys at standard filechooserdialog (open and save) in metal L&F

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Sat Jun 9 10:29:17 UTC 2012


Hello,

This is a request to review the fix for the issue:

bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7174970
webrev: http://cr.openjdk.java.net/~alexsch/7174970/webrev.00/

According to the issue 5081721 the Open, Save and Cancel buttons should 
not have mnemonics for the FileChooser.

However they existed in the *.properties files:
------------------------------------------
FileChooser.cancelButtonText=\u53D6\u6D88
FileChooser.cancelButtonMnemonic=67
FileChooser.saveButtonText=\u4FDD\u5B58
FileChooser.saveButtonMnemonic=83
FileChooser.openButtonText=\u6253\u5F00
FileChooser.openButtonMnemonic=79
------------------------------------------

Because of this the converting tool adds the mnemonics to the end of the 
new unified text and mnemonic properties:
------------------------------------------
FileChooser.cancelButton.textAndMnemonic=\u53D6\u6D88(&C)
FileChooser.saveButton.textAndMnemonic=\u4FDD\u5B58(&S)
FileChooser.openButton.textAndMnemonic=\u6253\u5F00(&O)
------------------------------------------

The fix removes the unnecessary mnemonics for the FileChooser Open, Save 
and Cancel buttons.

Thanks,
Alexandr.




More information about the swing-dev mailing list