<Swing Dev> Fixes for sunbug 7026933 and 4310381

Pavel Porvatov pavel.porvatov at oracle.com
Wed Mar 21 13:15:23 UTC 2012


Hi Charles,
> Hi guys,
>
> I am trying to fix 7026933 and 4310381.
>
> Patch @ http://cr.openjdk.java.net/~littlee/7026933/webrev.00/ 
> <http://cr.openjdk.java.net/%7Elittlee/7026933/webrev.00/>
>
> The test case is @ 4310381 and 7026933.
>
> My patch fix the padding problem on all the tabs except the top tab. 
> The reason about this is Metal look and feel does not want to pad the 
> last one. Please check the code in MetalTabbedPaneUI:
>
> // Don't pad last run
> protected boolean shouldPadTabRun( int tabPlacement, int run ) {
>     return runCount > 1 && run < runCount - 1;
> }
>
> Does anyone has some knowledge about this? If metal does not want pad 
> that tab, my patch should be consider fixing the problem :-)
>
That strange line was introduced with fix of CR 4253906 (since 1999). 
Looks strange indeed...

The fix looks good for me. What about a test? I'm not sure automatic 
test is possible here, so you can write manual test...

Regards, Pavel



More information about the swing-dev mailing list