<Swing Dev> [7] Review request for 7093156: NLS: Please change the mnemonic assignment system to avoid translation issue (Swing files)

[Pavel Porvatov]

Hi Alexander,


> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7093156
> webrev: http://cr.openjdk.java.net/~alexsch/7093156/webrev7.00/
>
>  This is a request from the NLS team to backport the issue 7093156 to 
> JDK 7.
>  The original JDK 8 patch is rejected when it is applied to JDK 8 
> because the property files are slightly different between JDK 7 and 
> JDK 8.
>
>  So the UIDefaults class is just copied to the JDK 7 and property 
> files are regenerated.
It seems there are mistakes in the backport. For example take a look at 
basic.properties files...

BTW: why some diffs looks differently? E.g. in jdk8 gtk.properties 
contains empty lines between FileChooser properties, but jdk7 doesn't....

Regards, Pavel
>
>  The properties from the following folders are updated:
>    src/share/classes/com/sun/java/swing/plaf/gtk
>    src/share/classes/com/sun/swing/internal/plaf
>
>  According to the request from the NLS team the properties, mnemonics 
> and mnemonic indexes are unified from the
>    xxxText, xxxMnemonic and xxxMnemonicIndex to xxx.titleAndMnemonic 
> (different patterns with the different suffixes are checked).
>
>  The TextAndMnemonicHashMap class is added to the UIDefaults class 
> that now parse requested keys and returns values from the unified 
> properties.
>
> Thanks,
> Alexandr.
>
>
>