<Swing Dev> [8] Review request for 7124209 [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH]

[Anthony Petrov]

I'm not a Swing expert, but since the test is simply moved from closed 
repos, I guess it looks fine.

--
best regards,
Anthony

On 11/22/12 15:31, Konstantin Shefov wrote:
> Please review a fix for this issue:
> http://cr.openjdk.java.net/~kshefov/7124209/webrev.02
>
> On 09-Nov-12 12:47, Alexander Scherbatiy wrote:
>> On 11/8/2012 4:25 PM, Konstantin Shefov wrote:
>>> http://cr.openjdk.java.net/~kshefov/7124209/webrev.02/
>>> <http://cr.openjdk.java.net/%7Ekshefov/7124209/webrev.02/>
>>
>> The fix looks good for me.
>>
>> Thanks,
>> Alexandr.
>>
>>>
>>> On 08-Nov-12 16:02, Alexander Scherbatiy wrote:
>>>> On 11/7/2012 7:00 PM, Konstantin Shefov wrote:
>>>>> Please, look at modified fix:
>>>>> http://cr.openjdk.java.net/~kshefov/7124209/webrev.01/
>>>>> <http://cr.openjdk.java.net/%7Ekshefov/7124209/webrev.01/>
>>>>
>>>> Try/catch block in the main method catches RuntimeException as well.
>>>> So the jtreg passes the test even it really fails.
>>>> It is also a good idea to fail the test if the
>>>> SwingUtilities.invokeAndWait() throws an exception because it is
>>>> also a wrong situation.
>>>>
>>>> Thanks,
>>>> Alexandr.
>>>>
>>>>>
>>>>> On 01-Nov-12 17:45, Alexander Scherbatiy wrote:
>>>>>>
>>>>>> - Please, remove comments and unnecessary System.out from the fix
>>>>>> - Create and check swing components on EDT. Avoiding this rule can
>>>>>> leads to unpredictable test failures.
>>>>>> - Swing tests usually have bugBugID.java or some meaningful name.
>>>>>> - It is better to use the swing-dev at openjdk.java.net alias to
>>>>>> review the swing tests.
>>>>>>
>>>>>> Thanks,
>>>>>> Alexandr.
>>>>>>
>>>>>> On 10/31/2012 7:06 PM, Konstantin Shefov wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Please review a fix for the issue:
>>>>>>>
>>>>>>> 7124209 [macosx] SpringLayout issue. BASELINE is not in the
>>>>>>> range: [NORTH, SOUTH]
>>>>>>>
>>>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7124209/webrev/
>>>>>>>
>>>>>>> It is suggested to move the test to open jdk.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Konstantin
>>>>>>>
>>>>>>
>>>>
>>