<Swing Dev> [8] Review request for 8022398: javax/swing/JFileChooser/8013442/Test8013442.java fails

[Sergey Malenkov]

Hi Alexandr,

What do you think about the following changes?
http://cr.openjdk.java.net/~malenkov/8022398.8.1/

Thanks,
SAM

----- Original Message -----
From: alexandr.scherbatiy at oracle.com
To: sergey.malenkov at oracle.com
Cc: swing-dev at openjdk.java.net
Sent: Friday, August 23, 2013 5:39:25 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: [8] Review request for 8022398: javax/swing/JFileChooser/8013442/Test8013442.java fails


   The fix looks good for me.

   Is it possible to unify all FilterComboBoxModels in one place rather 
to duplicate the code in all L&Fs?

   Thanks,
   Alexandr.

On 8/15/2013 7:34 PM, sergey malenkov wrote:
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8022398.8.0/ 
> <http://cr.openjdk.java.net/%7Emalenkov/8022398.8.0/>
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022398
>
> The FilterComboBoxModel class is the inner class of every 
> *FileChooserUI class, but the implementation from the Aqua L&F differs 
> from other implementations.  It should be aligned with other 
> implementations.
>
> The following test can be used to ensure that the problem is fixed:
> javax/swing/JFileChooser/8013442/Test8013442.java
>
> Thanks,
> SAM