<Swing Dev> [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

[Vladislav Karnaukhov]

Hello Alexander, all,

please find new version here: 
http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.06/

I also would like to mention that the customer tested FVB in their live 
environment and hadn't found any issues.

On 2/4/2013 12:16 PM, Alexandr Scherbatiy wrote:
>
> Could you also check that the "ComboBox.noActionOnKeyNavigation"
> property works as expected on Mac OS X.
I've checked it, yes, and confirm that this feature works on Mac OS X. 
Regression test also works there.

>
> Thanks,
> Alexandr.
>
> 01.02.2013 17:32, Alexander Scherbatiy пишет:
>>
>> - key == PAGE_UP / (key == PAGE_DOWN)
>> Are ui.listBox.getSelectedIndex() and comboBox.getSelectedIndex() the
>> same when the "ComboBox.noActionOnKeyNavigation"
>> property is unset? If so, only the ui.listBox.getSelectedIndex() can
>> be used for both cases.
Agreed. Please see a new webrev.

>>
>> - key == HIDE
>> I would suggest to set the ui.listBox.selected index back to the
>> comboBox.selected index to prevent some issues where these two indices
>> are expected to be the same.
When popup window is shown, BasicComboPopup.show() method always sets 
list selection equal to combo box selection. To my understanding, we 
don't need to perform this operation explicitly in HIDE handler.

>>
>> Thanks,
>> Alexandr.
>>