<Swing Dev> [8] Review request for JDK-7132383: [macosx] bug6596966.java should be adapted for Mac

[Alexander Scherbatiy]

Just one typo:

  241         if ((modifiers&  InputEvent.META_MASK) != 0) {
  242             result.add(KeyEvent.META_MASK);
  243         }

    It seems that the  KeyEvent.VK_META should be added to the result.

   Thanks,
   Alexandr.

On 2/7/2013 6:32 PM, vera akulova wrote:
> Hi Alexander,
>
> thanks for your reply,
> please review the new version of fix: 
> http://cr.openjdk.java.net/~kshefov/7132383/webrev.02/
>
> Vera
>
> On 07.02.2013 17:18, Alexander Scherbatiy wrote:
>> On 2/6/2013 3:15 PM, vera akulova wrote:
>>> Hello,
>>>
>>> as we discussed offline it is better to use 
>>> SwingUtilities2.getSystemMnemonicKeyMask(), I suggest the following 
>>> fix:
>>>
>>> http://cr.openjdk.java.net/~kshefov/7132383/webrev.01/
>>>
>>> Could you please review?
>>
>>    The fix looks good for me.
>>
>>    I would suggest to rename the getKeyCodesByKeyMask method to 
>> getKeyCodesFromKeyMask and
>>    add getSystemMnemonicKeyCodes() method to Util class because this 
>> is often used in the tests.
>>
>>    Thanks,
>>    Alexandr.
>>
>>>
>>> Thanks,
>>> Vera
>>>
>>> On 11.12.2012 18:44, vera akulova wrote:
>>>> Hello,
>>>>
>>>> Please review a fix for the issue:
>>>>    JDK-7132383: [macosx] bug6596966.java should be adapted for Mac
>>>>
>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7132383/webrev.00/
>>>>
>>>> Ctrl-Alt-Mnemonic is used now for Mac instead of Alt-Mnemonic.
>>>> Fixed test works fine on windows, linux, solaris and macos.
>>>>
>>>> Thanks,
>>>> Vera.
>>