<Swing Dev> [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Feb 8 13:23:45 UTC 2013


   The fix looks good for me.

   Thanks,
   Alexandr.

On 2/8/2013 4:20 PM, Vladislav Karnaukhov wrote:
> I agree. By reverting changes in BasicComboBoxUI.getNextIndex, we can 
> be sure that the fix won't affect default behavior when the property 
> is OFF.
>
> Please see a new webrev here: 
> http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.07/
>
> Regards,
> - Vlad
>
> On 2/8/2013 03:11 PM, Alexander Scherbatiy wrote:
>>
>>    I am able to reproduce the behaviour from the ComboTest:
>>     cb.getSelectedIndex() = 0
>>     getComboPopup(cb).getList().getSelectedIndex() = 4
>>
>>   Because our initial guess was that these indices are always equal I
>> suggest to revert this fix to avoid any possible unpredictable 
>> regressions.
>>
>>   Thanks,
>>   Alexandr.




More information about the swing-dev mailing list