<Swing Dev> [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u
Konstantin Shefov
konstantin.shefov at oracle.com
Wed Feb 27 13:45:58 UTC 2013
I replaced Thread.sleep() with toolkit.realSync() and made swing mwthod
to run on EDT.
New webrev: http://cr.openjdk.java.net/~kshefov/7145406/webrev.01
Konstantin
On 25-Feb-13 19:10, Alexander Scherbatiy wrote:
> On 2/25/2013 1:51 PM, Konstantin Shefov wrote:
>> Hello,
>>
>> Please review a fix for the issue:
>>
>> 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u
>>
>> https://jbs.oracle.com/bugs/browse/JDK-7145406
>>
>> The webrev is http://cr.openjdk.java.net/~kshefov/7145406/webrev/
>
> test/javax/swing/JComponent/DoublePaint/TestDoublePaint.java
> - Is it possible to run the test with jtreg or JUnit is necessary
> for the test invocation?
> - line: 68 Thread.sleep(2000); // 2 seconds should be plenty
> enough to catch 2 repaints
> Is it possible to use the toolkit.realSync() method here?
> - Swing classes should be created and used on the EDT.
>
> Thanks,
> Alexandr.
>
>>
>> Thanks,
>> Konstantin
>
More information about the swing-dev
mailing list