<Swing Dev> [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

[Sergey Bylokhov]

Hi, Konstantin.
I think yes. Please try to run these tests on windows as well. At least 
they should be compiled.

28.02.2013 17:55, Konstantin Shefov wrote:
> I used JTREG 4.1 fcs b03, not b05. Indeed, if one uses b05, one gets 
> compilation errors. So should I replace @run main to @run juint in all 
> 150 tests?
>
> On 28-Feb-13 17:46, Konstantin Shefov wrote:
>> Strange, but I used JTReg 4.1 b05 also and I had no compilation 
>> errors. JUnit is automatically added in the latest JTREG 4.1.
>>
>> On 28-Feb-13 17:02, Alexander Scherbatiy wrote:
>>> On 2/27/2013 5:45 PM, Konstantin Shefov wrote:
>>>> I replaced Thread.sleep() with toolkit.realSync() and made swing 
>>>> mwthod to run on EDT.
>>>>
>>>> New webrev: http://cr.openjdk.java.net/~kshefov/7145406/webrev.01
>>>>> test/javax/swing/JComponent/DoublePaint/TestDoublePaint.java
>>>>>     - Is it possible to run the test with jtreg or JUnit is 
>>>>> necessary for the test invocation?
>>>
>>>     I run the test and got the compilation error: 
>>> TestDoublePaint.java:34: error: package junit.framework does not exist.
>>>     It seems it is because the '@run main TestDoublePaint' jtreg 
>>> task does not put the junit jar to the test jdk class path.
>>>     The '@run junit TestDoublePaint' task passes the test. (I use 
>>> the JTReg 4.1 b05 from http://download.java.net/openjdk/jtreg/)
>>>     It is also interesting is it necessary to have the main method 
>>> for the junit task?
>>>
>>>    Thanks,
>>>    Alexandr.
>>>
>>>>>     -  line: 68 Thread.sleep(2000); // 2 seconds should be plenty 
>>>>> enough to catch 2 repaints
>>>>>       Is it possible to use the toolkit.realSync() method here?
>>>>>    - Swing classes should be created and used on the EDT.
>>>>>
>>>>>   Thanks,
>>>>>   Alexandr.
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Konstantin
>>>>>
>>>>
>>>
>>
>


-- 
Best regards, Sergey.