<Swing Dev> [8] Review request for 8003978 closed/javax/swing/JRootPane/bug4670486.java fails since jdk7u12b01 on macosx

[Alexander Scherbatiy]

On 10/23/2012 12:04 PM, Leonid Romanov wrote:
> Hi,
> Are you sure that is is a right fix? I'm asking because Apple JDK 6 
> works fine with Alt+U as a menu accelerator.
      I have done it in the same way as it fixed for the button mnemonics.
      Apple JDK 6 uses Alt+Key for the button mnemonics. It is changed 
to Ctrl+Alt+Key in the JDK 7.

      Thanks,
      Alexandr.

>
> On Dec 6, 2012, at 7:01 PM, Alexander Scherbatiy 
> <alexandr.scherbatiy at oracle.com> wrote:
>
>>
>> Hello,
>>
>> Could you review the fix:
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003978
>> webrev: http://cr.openjdk.java.net/~alexsch/8003978/webrev.00
>>
>>  The test fails because now Alt+U key combination returns right dead 
>> key code instead of the key code for the 'U' key.
>>  The solution is to use Ctrl+Alt key combination for menu mnemonics 
>> like it is done for button mnemonics.
>>
>>  The fix uses SunToolkit getFocusAcceleratorKeyMask() method to get 
>> the system depended mnemonic key mask and puts it to the 
>> Menu.shortcutKeys property in the BasicLookAndFeel.
>>
>> Thanks,
>> Alexandr.
>>
>
>