<Swing Dev> [8] Review request for 8004298 NPE in WindowsTreeUI.ensureRowsAreVisible

[Sergey Bylokhov]

Hi, Alexander.
Fix looks good.

16.01.2013 17:28, Alexander Scherbatiy wrote:
>
>  Could you review the updated fix:
>    http://cr.openjdk.java.net/~alexsch/8004298/webrev.02/
>
>   - The test case is added.
>     There are no exact steps to reproduce the issue so I just use the 
> idea to override the getPathBounds() method
>        from the fix 
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bd175c70684c
>
>   Thanks,
>   Alexandr.
>
>
> On 1/10/2013 4:05 PM, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> Fix looks good. Probably it is possible to create a test for it?
>>
>> 10.01.2013 15:41, Alexander Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004298
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8004298/webrev.00
>>>
>>>   The getPathBounds() method can return null under certain 
>>> circumstances.
>>>   The fix checks this before using the testRect variable.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>>
>


-- 
Best regards, Sergey.