<Swing Dev> [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

[Alexander Scherbatiy]

    Some small comments:
     - Keys Up and Down do not work with WindowsLookAndFeel and enabled 
ComboBox.noActionOnKeyNavigation property. Is it expected behavior?
     - Method getNextIndex from the BasicComboBoxUI class is private, so 
it is possible to pass the ui variable as an argument rather to obtain 
it one more time
     - Cancel action does not set the ui.listBox selected index to the 
initial state. However,  it seems that it works correct when the popup 
is opened next time.

   Thanks,
   Alexandr.

On 1/17/2013 5:33 PM, Vladislav Karnaukhov wrote:
> Hello,
>
> please review a new version of the fix: 
> http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.02/
>
> Support for VK_PAGE_DOWN/VK_PAGE_UP and VK_HOME/VK_END keys was added; 
> test routine was altered accordingly.
>
> Regards,
> - Vlad