<Swing Dev> [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Thu Jan 24 13:57:28 UTC 2013


- MetalLookAndFeel and ComboBox.noActionOnKeyNavigation property is set
     Press down, select an item, press enter. The drop down list is not 
closed
- WindowsLookAndFeel and ComboBox.noActionOnKeyNavigation property is set
    Home/End and PgUp/PgDn keys do not work

On 1/24/2013 12:32 PM, Vladislav Karnaukhov wrote:
> Hello Alexander, all,
>
> please find the new version here: 
> http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.03/
>
> Please see comments inline.
>
> Regards,
> - Vlad
>
> On 1/21/2013 05:14 PM, Alexander Scherbatiy wrote:
>>      - Cancel action does not set the ui.listBox selected index to the
>> initial state. However,  it seems that it works correct when the popup
>> is opened next time.
> Could you please elaborate more on this? I'm afraid I didn't quite 
> understand the issue here...

       Use case: Press down on a JComboBox, select an item which is 
deffirent from the initial item, press escape. The combobox selected 
item has the initial value but the ui.listBox has another.
       It could leads to some sort of synchronization issues.

     Thanks,
     Alexandr.

>
>>
>>    Thanks,
>>    Alexandr.
>>
>> On 1/17/2013 5:33 PM, Vladislav Karnaukhov wrote:
>>> Hello,
>>>
>>> please review a new version of the fix:
>>> http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.02/
>>>
>>> Support for VK_PAGE_DOWN/VK_PAGE_UP and VK_HOME/VK_END keys was added;
>>> test routine was altered accordingly.
>>>
>>> Regards,
>>> - Vlad
>>
>
>




More information about the swing-dev mailing list