<Swing Dev> [8] Review request for CR 7077259 [TEST_BUG] [macosx] Test work correctly only when default L&F is Metal.

Konstantin Shefov konstantin.shefov at oracle.com
Tue Jan 29 13:36:29 UTC 2013


Thanks, it works.

Here is new webrev: http://cr.openjdk.java.net/~kshefov/7077259/webrev.01

On 28-Jan-13 22:39, Sergey Bylokhov wrote:
> Hi, Konstantin.
> Could you add additional options to the test via @run tag. For 
> example, how to run test 2 times with different lafs:
> /*
>  * @test
>  * @bug bug6438430
>  * @summary ....
>  * @run main/othervm 
> -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel bug6438430
>  * @run main/othervm 
> -Dswing.defaultlaf=com.sun.java.swing.plaf.motif.MotifLookAndFeel 
> bug6438430
>  */
>
> Also
>
> * Copyright (c) 2007, 2008, 2013, Oracle and/or its affiliates. All 
> rights reserved.
> should be changed to
> * Copyright (c) 2007, 2013, Oracle and/or its affiliates. All rights 
> reserved.
>
>
> 28.01.2013 17:06, Konstantin Shefov wrote:
>> Hello,
>>
>> Please review a fix for the issue:
>>
>> 7077259 [TEST_BUG] [macosx] Test work correctly only when default L&F 
>> is Metal.
>>
>> Since all three tests:
>>    javax/swing/plaf/metal/MetalSliderUI/Test6657026.java
>>    javax/swing/JSpinner/6532833/bug6532833.java
>>    javax/swing/JSlider/4252173/bug4252173.java
>> are specific only for Metal LaF, than using of Metal LaF should be 
>> forced: UIManager.setLookAndFeel(new MetalLookAndFeel());
>>
>> The webrev is: http://cr.openjdk.java.net/~kshefov/7077259/webrev.00
>>
>> Thanks,
>> Konstantin
>
>



More information about the swing-dev mailing list