From alexandr.scherbatiy at oracle.com Mon Jul 1 11:08:07 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 01 Jul 2013 15:08:07 +0400 Subject: CFV: New Swing Group Member: Artem Ananiev In-Reply-To: <51C9E0A2.5060209@oracle.com> References: <51C9E0A2.5060209@oracle.com> Message-ID: <51D16317.7070207@oracle.com> Vote: yes Thanks, Alexandr. On 6/25/2013 10:25 PM, Alexander Potochkin wrote: > I hereby nominate Artem Ananiev to the Membership in the Swing Group. > > Artem is greatly experienced in every brick of the JDK client library > and has effectively been a member of the Swing group for a long time. > > http://openjdk.java.net/census#art > > I attached some of his contributions to the Swing/AWT area for JDK7 > and JDK8. > > Votes are due by Jul 9, 2013. > > Only current Members of the Swing Group [1] are eligible > to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks > Alexander Potochkin > > [1] http://openjdk.java.net/census#swing > [2] http://openjdk.java.net/groups/#member-vote| From artem.ananiev at oracle.com Tue Jul 2 09:42:17 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 02 Jul 2013 13:42:17 +0400 Subject: AppContext issue in Apple Java 6 -- same issue in Oracle Java 7? In-Reply-To: References: <48FF7D86-1A7C-4C99-BA97-B765CB02AE0C@gmail.com> <51CDC8A2.2060708@oracle.com> Message-ID: <51D2A079.3050909@oracle.com> Cross-posting to swing-dev and awt-dev. On 7/2/2013 6:10 AM, Leonid Romanov wrote: > > On Jun 28, 2013, at 9:32 PM, Artem Ananiev wrote: >> >> This is a bug in eAWT, which uses SwingUtilities.invokeLater(), but should use SunToolkit.postEvent(AppContext, AWTEvent) or similar. > > What do you think about introducing a new API, like SwingUtilities.invokeLater(Runnable runnable, Component target) which would invoke the runnable using the target's AppContext? It might be useful both for AWT/Swing engineers and apps writers. I don't think SwingUtilities/EventQueue is the right place for such API. It's useless for app developers, as application code should always be in the right AppContext, i.e. invokeLater(Runnable) should always post the runnable to the right place. Such API is useful, when your code is on a thread like the toolkit thread (AppKit thread on OS X). So a better place would be SunToolkit or SwingUtilities2, but SunToolkit already has a method named executeOnEventHandlerThread(). Thanks, Artem > Leonid. From dpardhu123 at yahoo.in Fri Jul 5 04:34:59 2013 From: dpardhu123 at yahoo.in (PARDHU D) Date: Fri, 5 Jul 2013 12:34:59 +0800 (SGT) Subject: Need help in JAVA Message-ID: <1372998899.19990.YahooMailNeo@web190504.mail.sg3.yahoo.com> Hi to all, I am using Windows XP os with Eclipse IDE. I write one java program which can able to call Unicode (Telugu) from out side of the program i.e its read from .txt file. While running this program in IDE I can able to see Unicode. But when I exported it as into Jar file, instead of Unicode I get square boxes. Can any one please tell me how can I get Unicode in Jar file. Thanks in Advance. Regards, D Pardhu. -------------- next part -------------- An HTML attachment was scrubbed... URL: From dpardhu123 at yahoo.in Fri Jul 5 04:36:43 2013 From: dpardhu123 at yahoo.in (PARDHU D) Date: Fri, 5 Jul 2013 12:36:43 +0800 (SGT) Subject: Need help in JAVA Message-ID: <1372999003.77025.YahooMailNeo@web190506.mail.sg3.yahoo.com> Hi to all, I am using Windows XP os with Eclipse IDE. I write one java program which can able to call Unicode (Telugu) from out side of the program i.e its read from .txt file. While running this program in IDE I can able to see Unicode. But when I exported it as into Jar file, instead of Unicode I get square boxes. Can any one please tell me how can I get Unicode in Jar file. Thanks in Advance. Regards, D Pardhu. -------------- next part -------------- An HTML attachment was scrubbed... URL: From alexandr.scherbatiy at oracle.com Fri Jul 5 12:07:36 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Fri, 05 Jul 2013 16:07:36 +0400 Subject: Need help in JAVA In-Reply-To: <1372998899.19990.YahooMailNeo@web190504.mail.sg3.yahoo.com> References: <1372998899.19990.YahooMailNeo@web190504.mail.sg3.yahoo.com> Message-ID: <51D6B708.6080008@oracle.com> On 7/5/2013 8:34 AM, PARDHU D wrote: > Hi to all, > > I am using Windows XP os with Eclipse IDE. I write one java program > which can able to call Unicode (Telugu) from out side of the program > i.e its read from .txt file. While running this program in IDE I can > able to see Unicode. But when I exported it as into Jar file, instead > of Unicode I get square boxes. Can any one please tell me how can I > get Unicode in Jar file. Try to ask the question on the Java Swing forum first: https://forums.oracle.com/forums/forum.jspa?forumID=950 Do not forget to include the code snipped that reproduce the problem. Thanks, Alexandr. > > Thanks in Advance. > > Regards, > D Pardhu. > From sergey.malenkov at oracle.com Mon Jul 8 10:09:57 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Mon, 08 Jul 2013 14:09:57 +0400 Subject: CFV: New Swing Group Member: Artem Ananiev In-Reply-To: <51C9E0A2.5060209@oracle.com> References: <51C9E0A2.5060209@oracle.com> Message-ID: <51DA8FF5.8030905@oracle.com> Vote: Yes On 25.06.2013 22:25, Alexander Potochkin wrote: > I hereby nominate Artem Ananiev to the Membership in the Swing Group. > > Artem is greatly experienced in every brick of the JDK client library > and has effectively been a member of the Swing group for a long time. > > http://openjdk.java.net/census#art > > I attached some of his contributions to the Swing/AWT area for JDK7 > and JDK8. > > Votes are due by Jul 9, 2013. > > Only current Members of the Swing Group [1] are eligible > to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks > Alexander Potochkin > > [1] http://openjdk.java.net/census#swing > [2] http://openjdk.java.net/groups/#member-vote| From dpardhu123 at yahoo.in Thu Jul 11 10:19:37 2013 From: dpardhu123 at yahoo.in (PARDHU D) Date: Thu, 11 Jul 2013 18:19:37 +0800 (SGT) Subject: Need help in Java for Unicode Message-ID: <1373537977.6684.YahooMailNeo@web190502.mail.sg3.yahoo.com> Hi to all, I am using Windows XP os with Eclipse IDE. I write one java program which can able to call Unicode (Telugu) from out side of the program i.e its read from .txt file(.txt file saved under UTF-8 mode). While running this program in IDE I can able to see Unicode. But when I exported it as into Jar file, instead of Unicode I get square boxes. Can any one please tell me how can I get Unicode in Jar file. Thanks in Advance. Regards, D Pardhu -------------- next part -------------- An HTML attachment was scrubbed... URL: From JanecekPetr at seznam.cz Fri Jul 12 12:18:03 2013 From: JanecekPetr at seznam.cz (=?UTF-8?B?UGV0ciBKYW5lxI1law==?=) Date: Fri, 12 Jul 2013 14:18:03 +0200 (Central Europe Standard Time) Subject: Contributing guidance, code conventions Message-ID: <20130712121801.5BD7368DF@mail.openjdk.java.net> An HTML attachment was scrubbed... URL: From anthony.petrov at oracle.com Fri Jul 12 12:56:12 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 12 Jul 2013 16:56:12 +0400 Subject: Contributing guidance, code conventions In-Reply-To: <20130712121801.5BD7368DF@mail.openjdk.java.net> References: <20130712121801.5BD7368DF@mail.openjdk.java.net> Message-ID: <51DFFCEC.40102@oracle.com> Hi Petr, Thank you for your interest in contributing patches to OpenJDK. I suggest you to start with reading http://openjdk.java.net/contribute/ The code conventions that you're referring to are all still valid. And answers to your formatting questions are mostly affirmative. I don't know of any IDE templates to help you format your code automatically, but the most important thing to pay attention to is TABs vs. spaces: OpenJDK repos don't allow for TABs (this is enforced by a commit hook), so you have to use 4 spaces for indenting lines. Regarding fixing warnings that your IDE highlights: this is a good thing to do. However, this needs to be done as a separate patch. In other words, when fixing a specific issue, it is always a good idea to avoid massive reformatting of sources or otherwise fixing things unrelated to the main problem. You can always submit new bugs at http://bugs.sun.com/ -- best regards, Anthony On 07/12/2013 04:18 PM, Petr Jane?ek wrote: > Hello, > > I am Petr Janecek, a fresh member of this list who wants to contribute > by generifying the JSpinner class on behalf of > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6303622 (Use generic > in Swing components like JComboBox). Besides the related bug reports, I > could not find any discussion on this topic. Is there anything I should > know (like "Don't do it, others have tried and failed." or "Don't do it, > it's already being worked on.") before I start? > > On a related note, I opened up the current JSpinner code and lots of > warnings came on to me from my IDE. Are there any code conventions I > should adhere to? I found these: > http://www.oracle.com/technetwork/java/codeconvtoc-136057.html which are > 14 (!!) years old and are missing quite a few things: > - should we use generics with Comparable every time? > - should we use @Override every time we can? > - is the 80 characters per line limit still strictly enforced? > - is there a common formatter for any IDE out there? > > These are the hottest problems I think should be fixed. Is it advisable > to change these along the lines with current Java conventions (add > @Override, generics to Comparables, join some broken lines that would > take up 85 characters etc.)? If yes, should I do it in my main patch > (that would add generics to JSpinner), or as a separate patch (or > possibly even a separate issue)? > > Thank you, > Petr Janecek From alexander.potochkin at oracle.com Fri Jul 12 19:06:26 2013 From: alexander.potochkin at oracle.com (Alexander Potochkin) Date: Fri, 12 Jul 2013 23:06:26 +0400 Subject: Result: New Swing Group Member: Artem Ananiev Message-ID: <51E053B2.6050902@oracle.com> Voting for Artem Ananiev to the Swing group membership[1] is now closed. Yes: 2 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. alexp [1] http://mail.openjdk.java.net/pipermail/swing-dev/2013-June/002800.html From sergey.malenkov at oracle.com Wed Jul 17 14:19:42 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Wed, 17 Jul 2013 18:19:42 +0400 Subject: [8] Review request for 8010782 : clean up source files containing carriage return characters Message-ID: <51E6A7FE.7050607@oracle.com> Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010782 I removed all ^M at the end of lines. Thanks, SAM From alexandr.scherbatiy at oracle.com Thu Jul 18 10:39:01 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 18 Jul 2013 14:39:01 +0400 Subject: [8] Review request for 8010782 : clean up source files containing carriage return characters In-Reply-To: <51E6A7FE.7050607@oracle.com> References: <51E6A7FE.7050607@oracle.com> Message-ID: <51E7C5C5.2020601@oracle.com> The fix looks good for me. Thanks, Alexandr. On 7/17/2013 6:19 PM, sergey malenkov wrote: > Hello, > > Could you please review the following fix: > fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/ > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010782 > > I removed all ^M at the end of lines. > > Thanks, > SAM From artem.ananiev at oracle.com Thu Jul 18 14:34:01 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 18 Jul 2013 18:34:01 +0400 Subject: [8] Review request for 8010782 : clean up source files containing carriage return characters In-Reply-To: <51E6A7FE.7050607@oracle.com> References: <51E6A7FE.7050607@oracle.com> Message-ID: <51E7FCD9.5050607@oracle.com> What a nice "empty" webrev :) Could you generate the new version, with "-b" (do not ignore whitespaces) passed to the webrev script, please? Hope it helps to reveal the real changes. Thanks, Artem On 7/17/2013 6:19 PM, sergey malenkov wrote: > Hello, > > Could you please review the following fix: > fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/ > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010782 > > I removed all ^M at the end of lines. > > Thanks, > SAM From sergey.malenkov at oracle.com Thu Jul 18 14:52:40 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Thu, 18 Jul 2013 18:52:40 +0400 Subject: [8] Review request for 8010782 : clean up source files containing carriage return characters In-Reply-To: <51E7FCD9.5050607@oracle.com> References: <51E6A7FE.7050607@oracle.com> <51E7FCD9.5050607@oracle.com> Message-ID: <51E80138.2000409@oracle.com> Webrev is always empty, because "-b" affects only whitespaces, but I removed all ^M. Seems it is a problem of the Mercurial's diff. SAM On 18.07.2013 18:34, Artem Ananiev wrote: > > What a nice "empty" webrev :) Could you generate the new version, with > "-b" (do not ignore whitespaces) passed to the webrev script, please? > Hope it helps to reveal the real changes. > > Thanks, > > Artem > > On 7/17/2013 6:19 PM, sergey malenkov wrote: >> Hello, >> >> Could you please review the following fix: >> fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/ >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010782 >> >> I removed all ^M at the end of lines. >> >> Thanks, >> SAM From sergey.malenkov at oracle.com Fri Jul 19 15:08:45 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Fri, 19 Jul 2013 19:08:45 +0400 Subject: [8] Review request for 8019975: closed/javax/swing/JFileChooser/4966171/bug4966171.java throws java.io.NotSerializableException: javax.swing.plaf.basic.BasicFileChooserUI$AcceptAllFileFilter Message-ID: <51E9567D.3030406@oracle.com> Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8019975.8.0/ bug: https://jbs.oracle.com/bugs/browse/JDK-8019970 https://jbs.oracle.com/bugs/browse/JDK-8019975 This is a regression after the 8013442 fix. I missed that the default filter can be removed too. The following tests will pass after proposed changes: test/javax/swing/JFileChooser/8013442/Test8013442.java test/closed/javax/swing/JFileChooser/4163841/AcceptAllFileFilterTest.java test/closed/javax/swing/JFileChooser/4966171/bug4966171.java Thanks, SAM From alexandr.scherbatiy at oracle.com Mon Jul 22 10:39:26 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 22 Jul 2013 14:39:26 +0400 Subject: [8] Review request for 8019975: closed/javax/swing/JFileChooser/4966171/bug4966171.java throws java.io.NotSerializableException: javax.swing.plaf.basic.BasicFileChooserUI$AcceptAllFileFilter In-Reply-To: <51E9567D.3030406@oracle.com> References: <51E9567D.3030406@oracle.com> Message-ID: <51ED0BDE.8050002@oracle.com> The fix looks good for me. Thanks, Alexandr. On 7/19/2013 7:08 PM, sergey malenkov wrote: > Hello, > > Could you please review the following fix: > fix: http://cr.openjdk.java.net/~malenkov/8019975.8.0/ > bug: https://jbs.oracle.com/bugs/browse/JDK-8019970 > https://jbs.oracle.com/bugs/browse/JDK-8019975 > > This is a regression after the 8013442 fix. > I missed that the default filter can be removed too. > > The following tests will pass after proposed changes: > test/javax/swing/JFileChooser/8013442/Test8013442.java > test/closed/javax/swing/JFileChooser/4163841/AcceptAllFileFilterTest.java > test/closed/javax/swing/JFileChooser/4966171/bug4966171.java > > Thanks, > SAM From alexandr.scherbatiy at oracle.com Mon Jul 22 13:15:48 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 22 Jul 2013 17:15:48 +0400 Subject: [8] Review request for 7161568 [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails Message-ID: <51ED3084.2070405@oracle.com> Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.00 The JTabbedPane.getBoundsAt(int index) now returns null if the tab index is not currently visible in the UI. This is done according to the specification: http://docs.oracle.com/javase/6/docs/api/javax/swing/JTabbedPane.html#getBoundsAt%28int%29 The issue is covered by JCK tests so a new regression test is not added. Thanks, Alexandr. From sergey.malenkov at oracle.com Mon Jul 22 13:53:04 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Mon, 22 Jul 2013 17:53:04 +0400 Subject: [8] Review request for 8015926: NPE when using SynthTreeUI's expandPath() Message-ID: <51ED3940.3010706@oracle.com> Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8015926.8.0/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015926 The TreeUI.getPathBounds returns null if the path is not visible. So, we should check for null during painting. Thanks, SAM From sergey.malenkov at oracle.com Mon Jul 22 14:16:23 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Mon, 22 Jul 2013 18:16:23 +0400 Subject: Approved: [8] Review request for 7161568 [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails In-Reply-To: <51ED3084.2070405@oracle.com> References: <51ED3084.2070405@oracle.com> Message-ID: <51ED3EB7.30601@oracle.com> Looks good to me. Is it needed to file a new issue for JCK part? SAM On 22.07.2013 17:15, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 > webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.00 > > The JTabbedPane.getBoundsAt(int index) now returns null if the tab > index is not currently visible in the UI. > This is done according to the specification: > http://docs.oracle.com/javase/6/docs/api/javax/swing/JTabbedPane.html#getBoundsAt%28int%29 > > The issue is covered by JCK tests so a new regression test is not > added. > > Thanks, > Alexandr. > From alexandr.scherbatiy at oracle.com Mon Jul 22 14:36:37 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 22 Jul 2013 18:36:37 +0400 Subject: [8] Review request for 8015926: NPE when using SynthTreeUI's expandPath() In-Reply-To: <51ED3940.3010706@oracle.com> References: <51ED3940.3010706@oracle.com> Message-ID: <51ED4375.6070601@oracle.com> The fix looks good for me. Thanks, Alexandr. On 7/22/2013 5:53 PM, sergey malenkov wrote: > Hello, > > Could you please review the following fix: > fix: http://cr.openjdk.java.net/~malenkov/8015926.8.0/ > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015926 > > The TreeUI.getPathBounds returns null if the path is not visible. > So, we should check for null during painting. > > Thanks, > SAM From Sergey.Bylokhov at oracle.com Mon Jul 22 17:13:09 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 22 Jul 2013 21:13:09 +0400 Subject: [8] Review request for 7161568 [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails In-Reply-To: <51ED3084.2070405@oracle.com> References: <51ED3084.2070405@oracle.com> Message-ID: <51ED6825.9040806@oracle.com> Hi, Alexander. Looks like AquaTabbedPaneCopyFromBasicUI.repaintTab() is not expect null from the getTabBounds(). On 22.07.2013 17:15, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 > webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.00 > > The JTabbedPane.getBoundsAt(int index) now returns null if the tab > index is not currently visible in the UI. > This is done according to the specification: > http://docs.oracle.com/javase/6/docs/api/javax/swing/JTabbedPane.html#getBoundsAt%28int%29 > > The issue is covered by JCK tests so a new regression test is not > added. > > Thanks, > Alexandr. > -- Best regards, Sergey. From konstantin.shefov at oracle.com Tue Jul 23 09:03:47 2013 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Tue, 23 Jul 2013 13:03:47 +0400 Subject: [8] Review request for CR 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button, the case pass automatically. In-Reply-To: <51C1818C.5090001@oracle.com> References: <51C1818C.5090001@oracle.com> Message-ID: <51EE46F3.3000409@oracle.com> Please, review a test bug fix On 19-Jun-13 14:01, Konstantin Shefov wrote: > Hello, > > Please review a fix for the issue: > > 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing > 'cancel' and 'DONE' button, the case pass automatically. > > Test bug fix. > > http://bugs.sun.com/view_bug.do?bug_id=8006087 > > The webrev is: http://cr.openjdk.java.net/~kshefov/8006087/webrev.00 > > Thanks, > Konstantin From alexandr.scherbatiy at oracle.com Tue Jul 23 14:42:07 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 23 Jul 2013 18:42:07 +0400 Subject: [8] Review request for 7161568 [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails In-Reply-To: <51ED6825.9040806@oracle.com> References: <51ED3084.2070405@oracle.com> <51ED6825.9040806@oracle.com> Message-ID: <51EE963F.3050506@oracle.com> Hello, Could you review the updated fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.01 - In case if getTabBounds() returns null the repaintTab() method does nothing. The necessary test bug7161568 is added. - The getTabBounds() method should also check visibleTabState.needsScrollTabs() because in other case the necessary data is not initialized for the visibleTabState.isBefore(i)/isAfter(i) methods. - Two failed closed tests are updated and moved to the open repository. Thanks, Alexandr. On 7/22/2013 9:13 PM, Sergey Bylokhov wrote: > Hi, Alexander. > Looks like AquaTabbedPaneCopyFromBasicUI.repaintTab() is not expect > null from the getTabBounds(). > > On 22.07.2013 17:15, Alexander Scherbatiy wrote: >> >> Hello, >> >> Could you review the fix: >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 >> webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.00 >> >> The JTabbedPane.getBoundsAt(int index) now returns null if the tab >> index is not currently visible in the UI. >> This is done according to the specification: >> http://docs.oracle.com/javase/6/docs/api/javax/swing/JTabbedPane.html#getBoundsAt%28int%29 >> >> The issue is covered by JCK tests so a new regression test is not >> added. >> >> Thanks, >> Alexandr. >> > > From sergey.malenkov at oracle.com Wed Jul 24 11:23:46 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Wed, 24 Jul 2013 15:23:46 +0400 Subject: [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) Message-ID: <51EFB942.2090406@oracle.com> Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300 The focus is not moved from JComboBox to its ComboBoxEditor, so we should check that one of these components is foxused. Thanks, SAM From alexandr.scherbatiy at oracle.com Wed Jul 24 14:18:15 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 24 Jul 2013 18:18:15 +0400 Subject: [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) In-Reply-To: <51EFB942.2090406@oracle.com> References: <51EFB942.2090406@oracle.com> Message-ID: <51EFE227.3010209@oracle.com> On 7/24/2013 3:23 PM, sergey malenkov wrote: > Hello, > > Could you please review the following fix: > fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300 > > The focus is not moved from JComboBox to its ComboBoxEditor, > so we should check that one of these components is foxused. > I am not an expert in the focus area. Does the issue is applicable for the other components that use the JTextField for the text typing? Thanks, Alexandr. > Thanks, > SAM From alexandr.scherbatiy at oracle.com Wed Jul 24 14:19:33 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 24 Jul 2013 18:19:33 +0400 Subject: Approved: [8] Review request for 7161568 [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails In-Reply-To: <51ED3EB7.30601@oracle.com> References: <51ED3084.2070405@oracle.com> <51ED3EB7.30601@oracle.com> Message-ID: <51EFE275.8040209@oracle.com> On 7/22/2013 6:16 PM, sergey malenkov wrote: > Looks good to me. > Is it needed to file a new issue for JCK part? I have filed the necessary JCK issue. Thanks, Alexandr. > > SAM > > On 22.07.2013 17:15, Alexander Scherbatiy wrote: >> >> Hello, >> >> Could you review the fix: >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 >> webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.00 >> >> The JTabbedPane.getBoundsAt(int index) now returns null if the tab >> index is not currently visible in the UI. >> This is done according to the specification: >> http://docs.oracle.com/javase/6/docs/api/javax/swing/JTabbedPane.html#getBoundsAt%28int%29 >> >> The issue is covered by JCK tests so a new regression test is not >> added. >> >> Thanks, >> Alexandr. >> > From Sergey.Bylokhov at oracle.com Wed Jul 24 14:30:21 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 24 Jul 2013 18:30:21 +0400 Subject: [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) In-Reply-To: <51EFB942.2090406@oracle.com> References: <51EFB942.2090406@oracle.com> Message-ID: <51EFE4FD.8080005@oracle.com> On 24.07.2013 15:23, sergey malenkov wrote: > Hello, > > Could you please review the following fix: > fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300 > > The focus is not moved from JComboBox to its ComboBoxEditor, Why it is not moved in some cases? > so we should check that one of these components is foxused. > > Thanks, > SAM -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Wed Jul 24 14:40:58 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 24 Jul 2013 18:40:58 +0400 Subject: [8] Review request for 7161568 [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails In-Reply-To: <51EE963F.3050506@oracle.com> References: <51ED3084.2070405@oracle.com> <51ED6825.9040806@oracle.com> <51EE963F.3050506@oracle.com> Message-ID: <51EFE77A.9070008@oracle.com> Hi, Alexander. Fix looks fine. On 23.07.2013 18:42, Alexander Scherbatiy wrote: > > Hello, > > Could you review the updated fix: > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 > webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.01 > > - In case if getTabBounds() returns null the repaintTab() method > does nothing. > The necessary test bug7161568 is added. > - The getTabBounds() method should also check > visibleTabState.needsScrollTabs() because in other case > the necessary data is not initialized for the > visibleTabState.isBefore(i)/isAfter(i) methods. > - Two failed closed tests are updated and moved to the open repository. > > Thanks, > Alexandr. > > On 7/22/2013 9:13 PM, Sergey Bylokhov wrote: >> Hi, Alexander. >> Looks like AquaTabbedPaneCopyFromBasicUI.repaintTab() is not expect >> null from the getTabBounds(). >> >> On 22.07.2013 17:15, Alexander Scherbatiy wrote: >>> >>> Hello, >>> >>> Could you review the fix: >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568 >>> webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.00 >>> >>> The JTabbedPane.getBoundsAt(int index) now returns null if the tab >>> index is not currently visible in the UI. >>> This is done according to the specification: >>> http://docs.oracle.com/javase/6/docs/api/javax/swing/JTabbedPane.html#getBoundsAt%28int%29 >>> >>> The issue is covered by JCK tests so a new regression test is not >>> added. >>> >>> Thanks, >>> Alexandr. >>> >> >> > -- Best regards, Sergey. From sergey.malenkov at oracle.com Wed Jul 24 15:14:09 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Wed, 24 Jul 2013 19:14:09 +0400 Subject: [8] Review request for CR 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button, the case pass automatically. In-Reply-To: <51C1818C.5090001@oracle.com> References: <51C1818C.5090001@oracle.com> Message-ID: <51EFEF41.5030608@oracle.com> Hi Konstantin, Why you moved the JavaTest header to the HTML file? Almost all regression tests use a Java file for it. I think you should leave it "as is". Note that other HTML files in the test/javax/swing folder does not have the Oracle Copyright text. I'm not sure that we should add it into this file only. Other changes in your fix looks good for me. Thanks, SAM On 19.06.2013 14:01, Konstantin Shefov wrote: > Hello, > > Please review a fix for the issue: > > 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing > 'cancel' and 'DONE' button, the case pass automatically. > > Test bug fix. > > http://bugs.sun.com/view_bug.do?bug_id=8006087 > > The webrev is: http://cr.openjdk.java.net/~kshefov/8006087/webrev.00 > > Thanks, > Konstantin From sergey.malenkov at oracle.com Fri Jul 26 09:17:24 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Fri, 26 Jul 2013 13:17:24 +0400 Subject: [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) In-Reply-To: <51EFE227.3010209@oracle.com> References: <51EFB942.2090406@oracle.com> <51EFE227.3010209@oracle.com> Message-ID: <51F23EA4.1060906@oracle.com> > Does the issue is applicable for the other components that use the JTextField for the text typing? No, there are another approach is used. Note that editable ComboBox shows TextField always. SAM On 24.07.2013 18:18, Alexander Scherbatiy wrote: > On 7/24/2013 3:23 PM, sergey malenkov wrote: >> Hello, >> >> Could you please review the following fix: >> fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300 >> >> The focus is not moved from JComboBox to its ComboBoxEditor, >> so we should check that one of these components is foxused. >> > I am not an expert in the focus area. Does the issue is applicable > for the other components that use the JTextField for the text typing? > > Thanks, > Alexandr. > >> Thanks, >> SAM > From sergey.malenkov at oracle.com Fri Jul 26 09:24:25 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Fri, 26 Jul 2013 13:24:25 +0400 Subject: [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) In-Reply-To: <51EFE4FD.8080005@oracle.com> References: <51EFB942.2090406@oracle.com> <51EFE4FD.8080005@oracle.com> Message-ID: <51F24049.7000406@oracle.com> > Why it is not moved in some cases? Because all focus requests are executed later in the next EDT runnable. In the test we request the focus and immediately check for it. SAM On 24.07.2013 18:30, Sergey Bylokhov wrote: > On 24.07.2013 15:23, sergey malenkov wrote: >> Hello, >> >> Could you please review the following fix: >> fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300 >> >> The focus is not moved from JComboBox to its ComboBoxEditor, > Why it is not moved in some cases? >> so we should check that one of these components is foxused. >> >> Thanks, >> SAM > > From kevinarpe at gmail.com Fri Jul 26 11:27:57 2013 From: kevinarpe at gmail.com (Kevin Connor Arpe) Date: Fri, 26 Jul 2013 19:27:57 +0800 Subject: javax.swing.plaf.basic.BasicHTML.isHTMLString(String) Message-ID: Hello, This is my first post to this mailing list. I was playing around with HTML + text labels on Swing widgets today. I noticed that the sniff test for HTML is defined by this static method: javax.swing.plaf.basic.BasicHTML.isHTMLString(String) The test is quite strict. Basically, the string must start with "" -- no whitespace allowed, but it is case insensitive. If there is a good reason for this strictness, please let me know. Otherwise, I would like to submit a small patch (+ test) to improve this static method to be more forgiving. If OK, please also advise about JDK7u vs JDK8. (I don't know if a [simple] patch can be applied to both releases easily.) In Perl regex parlance, something like: m/\s*/i Of course, my solution probably wouldn't use a regex, nor Perl. =) Please share you thoughts. Thanks, Kevin Connor ARPE Hongkong -------------- next part -------------- An HTML attachment was scrubbed... URL: From tom.hawtin at oracle.com Fri Jul 26 13:14:18 2013 From: tom.hawtin at oracle.com (Tom Hawtin) Date: Fri, 26 Jul 2013 14:14:18 +0100 Subject: javax.swing.plaf.basic.BasicHTML.isHTMLString(String) In-Reply-To: References: Message-ID: <51F2762A.4070208@oracle.com> I wouldn't want the html detection to be any more lenient. It's already problematic in that programmers need to ensure that they don't allow user text to switch modes. Whilst it's best to do this with the client property, that isn't always done in practice. Currently it just requires that whoever edits the text uses the correct form, with any errors being obvious. Tom On 26/07/2013 12:27, Kevin Connor Arpe wrote: > Hello, > > This is my first post to this mailing list. > > I was playing around with HTML + text labels on Swing widgets today. I > noticed that the sniff test for HTML is defined by this static method: > javax.swing.plaf.basic.BasicHTML.isHTMLString(String) > > The test is quite strict. Basically, the string must start with > "" -- no whitespace allowed, but it is case insensitive. > > If there is a good reason for this strictness, please let me know. > Otherwise, I would like to submit a small patch (+ test) to improve this > static method to be more forgiving. If OK, please also advise about > JDK7u vs JDK8. (I don't know if a [simple] patch can be applied to both > releases easily.) > > In Perl regex parlance, something like: m/\s*/i > Of course, my solution probably wouldn't use a regex, nor Perl. =) > > Please share you thoughts. > > Thanks, > Kevin Connor ARPE > Hongkong From artem.ananiev at oracle.com Mon Jul 29 13:57:17 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 29 Jul 2013 17:57:17 +0400 Subject: [8] Review request for 8010782 : clean up source files containing carriage return characters In-Reply-To: <51E80138.2000409@oracle.com> References: <51E6A7FE.7050607@oracle.com> <51E7FCD9.5050607@oracle.com> <51E80138.2000409@oracle.com> Message-ID: <51F674BD.702@oracle.com> OK, the fix is fine (despite the webrev doesn't look fine:)) Thanks, Artem On 7/18/2013 6:52 PM, sergey malenkov wrote: > Webrev is always empty, because "-b" affects only whitespaces, but I > removed all ^M. > Seems it is a problem of the Mercurial's diff. > > SAM > > On 18.07.2013 18:34, Artem Ananiev wrote: >> >> What a nice "empty" webrev :) Could you generate the new version, with >> "-b" (do not ignore whitespaces) passed to the webrev script, please? >> Hope it helps to reveal the real changes. >> >> Thanks, >> >> Artem >> >> On 7/17/2013 6:19 PM, sergey malenkov wrote: >>> Hello, >>> >>> Could you please review the following fix: >>> fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/ >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010782 >>> >>> I removed all ^M at the end of lines. >>> >>> Thanks, >>> SAM > From alexandr.scherbatiy at oracle.com Mon Jul 29 14:40:26 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 29 Jul 2013 18:40:26 +0400 Subject: [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) In-Reply-To: <51F23EA4.1060906@oracle.com> References: <51EFB942.2090406@oracle.com> <51EFE227.3010209@oracle.com> <51F23EA4.1060906@oracle.com> Message-ID: <51F67EDA.3000206@oracle.com> On 7/26/2013 1:17 PM, sergey malenkov wrote: > > Does the issue is applicable for the other components that use the > JTextField for the text typing? > > No, there are another approach is used. > Note that editable ComboBox shows TextField always. The fix looks good for me. Please also check, that javax/swing/JComboBox tests passes with the fix and the the comboox editor always has parent. Thanks, Alexandr. > > SAM > > On 24.07.2013 18:18, Alexander Scherbatiy wrote: >> On 7/24/2013 3:23 PM, sergey malenkov wrote: >>> Hello, >>> >>> Could you please review the following fix: >>> fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300 >>> >>> The focus is not moved from JComboBox to its ComboBoxEditor, >>> so we should check that one of these components is foxused. >>> >> I am not an expert in the focus area. Does the issue is >> applicable for the other components that use the JTextField for the >> text typing? >> >> Thanks, >> Alexandr. >> >>> Thanks, >>> SAM >> > From sergey.malenkov at oracle.com Mon Jul 29 15:05:26 2013 From: sergey.malenkov at oracle.com (sergey malenkov) Date: Mon, 29 Jul 2013 19:05:26 +0400 Subject: [8] Review request for 8010782 : clean up source files containing carriage return characters In-Reply-To: <51F674BD.702@oracle.com> References: <51E6A7FE.7050607@oracle.com> <51E7FCD9.5050607@oracle.com> <51E80138.2000409@oracle.com> <51F674BD.702@oracle.com> Message-ID: <51F684B6.7090900@oracle.com> > OK, the fix is fine (despite the webrev doesn't look fine:)) But this webrev shows that nothing changed (except EOLNs ;). The resulting diff is much worse: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bf80c2965a84 Thanks, SAM On 29.07.2013 17:57, Artem Ananiev wrote: > > OK, the fix is fine (despite the webrev doesn't look fine:)) > > Thanks, > > Artem > > On 7/18/2013 6:52 PM, sergey malenkov wrote: >> Webrev is always empty, because "-b" affects only whitespaces, but I >> removed all ^M. >> Seems it is a problem of the Mercurial's diff. >> >> SAM >> >> On 18.07.2013 18:34, Artem Ananiev wrote: >>> >>> What a nice "empty" webrev :) Could you generate the new version, with >>> "-b" (do not ignore whitespaces) passed to the webrev script, please? >>> Hope it helps to reveal the real changes. >>> >>> Thanks, >>> >>> Artem >>> >>> On 7/17/2013 6:19 PM, sergey malenkov wrote: >>>> Hello, >>>> >>>> Could you please review the following fix: >>>> fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/ >>>> >>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010782 >>>> >>>> I removed all ^M at the end of lines. >>>> >>>> Thanks, >>>> SAM >> From Sergey.Bylokhov at oracle.com Tue Jul 30 11:04:40 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 30 Jul 2013 15:04:40 +0400 Subject: [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) In-Reply-To: <51F24049.7000406@oracle.com> References: <51EFB942.2090406@oracle.com> <51EFE4FD.8080005@oracle.com> <51F24049.7000406@oracle.com> Message-ID: <51F79DC8.9050103@oracle.com> Hi, Sergey. Fix looks fine. On 26.07.2013 13:24, sergey malenkov wrote: > > Why it is not moved in some cases? > > Because all focus requests are executed later in the next EDT runnable. > In the test we request the focus and immediately check for it. > > SAM > > On 24.07.2013 18:30, Sergey Bylokhov wrote: >> On 24.07.2013 15:23, sergey malenkov wrote: >>> Hello, >>> >>> Could you please review the following fix: >>> fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300 >>> >>> The focus is not moved from JComboBox to its ComboBoxEditor, >> Why it is not moved in some cases? >>> so we should check that one of these components is foxused. >>> >>> Thanks, >>> SAM >> >> > -- Best regards, Sergey. From bob.futrelle at gmail.com Tue Jul 30 18:26:57 2013 From: bob.futrelle at gmail.com (Bob Futrelle) Date: Tue, 30 Jul 2013 14:26:57 -0400 Subject: New member needs to understand interacting with HTML in Swing Message-ID: My first post here. I've used Swing for years, but my current goals call for advanced development on my part. I tokenize HTML article text from the biology research literature. When a user clicks on or selects an item in a Swing GUI, I need to know exactly which token was selected, since I keep all sorts of information about the syntax and semantics every token, phrase, etc. I am willing to use whatever HTML rendering is available in Swing editor kits. If the HTML markup strays outside of Swing's capabilities, I'm willing to alter the HTML sources as a workaround. My previous experiments in this domain were frustrating (too early a version of Java/Swing?). I intend to restart some HTML experiments soon, but would welcome any pointers you people might have. As you can see, I'm not working at a developer's level, involved with Swing implementation details, bugs, or fixes. So this may not be the best list for me. But considering the demands my system will make on Swing, this may be the only place with participants that have the needed level of expertise. Though I recently retired, I'm working harder than ever on my ambitious NLP text mining system. I currently use Java 6 and Eclipse, Mac OS 10.8.4, MacBook Pro. Thanks in advance for any advice you might provide. - Bob Futrelle Emeritus professor of computer and info science Northeastern University -------------- next part -------------- An HTML attachment was scrubbed... URL: From bob.futrelle at gmail.com Wed Jul 31 01:41:47 2013 From: bob.futrelle at gmail.com (Bob Futrelle) Date: Tue, 30 Jul 2013 21:41:47 -0400 Subject: New member needs to understand interacting with HTML in Swing In-Reply-To: References: Message-ID: I devised what I'd call a hokey workaround that enables me to find the numerical UID of any selected text token(s). It consists of adding a styled span as a prefix to every word. Each span contains the numerical UID of the token that follows it. The HTML markup is substantially elaborated as, e.g., myPane.setText("" + "0000000while 0000001having 0000002no " + "0000003effect 0000004on "+ "0000005cytochrome 0000006c"); where 'myPane' is defined as, myPane = new JEditorPane(); myPane.setContentType("text/html"); The pane displays "while having no effect on cytochrome *c*" with c in italics and the normal interword spacing. There is no evidence in the display that the numerical IDs of the tokens underlie the text. The 'Print' menu item in my little app is: else if (cmd.equals("Print")) { System.out.println(myPane.getSelectedText()); } When "cytochrome" is selected in the JEditorPane, the Print command prints 0000005cytochrome so I know precisely which token was selected, even if there were other occurrences of "cytochrome". If the pair "no effect" is selected, the output print is, 0000002no 0000003effect Such multi-word items are important in biomedical text, e.g., "propidium iodide" is a single chemical compound with a two-word name, cf. "sodium chloride". My workaround operates by massaging the HTML source. So I've used what Swing offers out of the box, avoiding possibly trickier solutions. - Bob On Tue, Jul 30, 2013 at 2:26 PM, Bob Futrelle wrote: > My first post here. > > I've used Swing for years, but my current goals call > for advanced development on my part. > I tokenize HTML article text from the biology research literature. > When a user clicks on or selects an item in a Swing GUI, I need to know > exactly which token was selected, since I keep all sorts of > information about the syntax and semantics every token, phrase, etc. > > I am willing to use whatever HTML rendering is available > in Swing editor kits. If the HTML markup strays outside > of Swing's capabilities, I'm willing to alter the HTML sources > as a workaround. > > My previous experiments in this domain were frustrating > (too early a version of Java/Swing?). > > I intend to restart some HTML experiments soon, but would welcome > any pointers you people might have. > > As you can see, I'm not working at a developer's level, > involved with Swing implementation details, bugs, or fixes. > So this may not be the best list for me. > But considering the demands my system will make on Swing, > this may be the only place with participants that have the > needed level of expertise. > > Though I recently retired, I'm working harder than ever > on my ambitious NLP text mining system. > I currently use Java 6 and Eclipse, > Mac OS 10.8.4, MacBook Pro. > > Thanks in advance for any advice you might provide. > > - Bob Futrelle > Emeritus professor of computer and info science > Northeastern University > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: