<Swing Dev> [8] Review request for 8019975: closed/javax/swing/JFileChooser/4966171/bug4966171.java throws java.io.NotSerializableException: javax.swing.plaf.basic.BasicFileChooserUI$AcceptAllFileFilter

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Mon Jul 22 10:39:26 UTC 2013


   The fix looks good for me.

    Thanks,
    Alexandr.


On 7/19/2013 7:08 PM, sergey malenkov wrote:
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8019975.8.0/
> bug: https://jbs.oracle.com/bugs/browse/JDK-8019970
>      https://jbs.oracle.com/bugs/browse/JDK-8019975
>
> This is a regression after the 8013442 fix.
> I missed that the default filter can be removed too.
>
> The following tests will pass after proposed changes:
> test/javax/swing/JFileChooser/8013442/Test8013442.java
> test/closed/javax/swing/JFileChooser/4163841/AcceptAllFileFilterTest.java
> test/closed/javax/swing/JFileChooser/4966171/bug4966171.java
>
> Thanks,
> SAM




More information about the swing-dev mailing list