<Swing Dev> [8] Review request for 7161568 [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails

[Sergey Bylokhov]

Hi, Alexander.
Fix looks fine.

On 23.07.2013 18:42, Alexander Scherbatiy wrote:
>
>    Hello,
>
>   Could you review the updated fix:
>   bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568
>   webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.01
>
>   -  In case if getTabBounds() returns null the repaintTab() method 
> does nothing.
>     The necessary test bug7161568 is added.
>   - The getTabBounds() method should also check 
> visibleTabState.needsScrollTabs() because in other case
>       the necessary  data is not initialized for the 
> visibleTabState.isBefore(i)/isAfter(i) methods.
>   - Two failed closed tests are updated and moved to the open repository.
>
>   Thanks,
>   Alexandr.
>
> On 7/22/2013 9:13 PM, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> Looks like AquaTabbedPaneCopyFromBasicUI.repaintTab() is not expect 
>> null from the getTabBounds().
>>
>> On 22.07.2013 17:15, Alexander Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161568
>>>   webrev: http://cr.openjdk.java.net/~alexsch/7161568/webrev.00
>>>
>>>   The JTabbedPane.getBoundsAt(int index) now returns null if the tab 
>>> index is not currently visible in the UI.
>>>   This is done according to the specification: 
>>> http://docs.oracle.com/javase/6/docs/api/javax/swing/JTabbedPane.html#getBoundsAt%28int%29
>>>
>>>   The issue is covered by JCK tests so a new regression test is not 
>>> added.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>>
>


-- 
Best regards, Sergey.